[GitHub] [hive] kasakrisz commented on a change in pull request #1446: HIVE-22622: Hive allows to create a struct with duplicate attribute names

2020-09-01 Thread GitBox
kasakrisz commented on a change in pull request #1446: URL: https://github.com/apache/hive/pull/1446#discussion_r480897671 ## File path: common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java ## @@ -471,6 +471,7 @@ "Not an ordered-set aggregate function: {0}. WITHIN

[GitHub] [hive] kasakrisz commented on pull request #1446: HIVE-22622: Hive allows to create a struct with duplicate attribute names

2020-09-01 Thread GitBox
kasakrisz commented on pull request #1446: URL: https://github.com/apache/hive/pull/1446#issuecomment-684505690 Adding a test case for various underlying formats doesn't make sense this case because the duplicate check is performed in the semantical analysis phase of the `create table` sta

[GitHub] [hive] aasha opened a new pull request #1452: HIVE-24102 : Add ENGINE=InnoDB for replication mysql schema changes a…

2020-09-01 Thread GitBox
aasha opened a new pull request #1452: URL: https://github.com/apache/hive/pull/1452 …nd not exists clause for the table creation ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_

[GitHub] [hive] ShubhamChaurasia commented on a change in pull request #1418: HIVE-24059: Llap external client - Initial changes for running in cloud environment

2020-09-01 Thread GitBox
ShubhamChaurasia commented on a change in pull request #1418: URL: https://github.com/apache/hive/pull/1418#discussion_r481088959 ## File path: llap-common/src/java/org/apache/hadoop/hive/llap/security/DefaultJwtSharedSecretProvider.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to

[GitHub] [hive] pgaref commented on pull request #1445: HIVE-24093: Remove unused hive.debug.localtask

2020-09-01 Thread GitBox
pgaref commented on pull request #1445: URL: https://github.com/apache/hive/pull/1445#issuecomment-684843982 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hive] jcamachor commented on a change in pull request #1437: HIVE-24081: Enable pre-materializing CTEs referenced in scalar subqueries

2020-09-01 Thread GitBox
jcamachor commented on a change in pull request #1437: URL: https://github.com/apache/hive/pull/1437#discussion_r481220742 ## File path: ql/src/test/queries/clientpositive/cte_mat_6.q ## @@ -0,0 +1,81 @@ +set hive.optimize.cte.materialize.threshold=1; + +create table t0(col0 in

[GitHub] [hive] jcamachor commented on a change in pull request #1437: HIVE-24081: Enable pre-materializing CTEs referenced in scalar subqueries

2020-09-01 Thread GitBox
jcamachor commented on a change in pull request #1437: URL: https://github.com/apache/hive/pull/1437#discussion_r481221210 ## File path: ql/src/test/results/clientpositive/llap/cte_4.q.out ## @@ -106,23 +106,17 @@ PREHOOK: query: create table s2 as with q1 as ( select key from

[GitHub] [hive] vineetgarg02 merged pull request #1440: HIVE-24087 FK side join elimination in presence of PK-FK constraint

2020-09-01 Thread GitBox
vineetgarg02 merged pull request #1440: URL: https://github.com/apache/hive/pull/1440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hive] pgaref commented on pull request #1274: HIVE-23852: add support for Date type in ReduceSink operator for native vector sink

2020-09-01 Thread GitBox
pgaref commented on pull request #1274: URL: https://github.com/apache/hive/pull/1274#issuecomment-684953747 @abstractdog could you please check this when you have a sec? This is an automated message from the Apache Git Servi

[GitHub] [hive] klcopp merged pull request #1441: HIVE-24089: Run QB compaction as table directory user with impersonation

2020-09-01 Thread GitBox
klcopp merged pull request #1441: URL: https://github.com/apache/hive/pull/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] zabetak opened a new pull request #1453: HIVE-24104: NPE due to null key columns in ReduceSink after deduplication

2020-09-01 Thread GitBox
zabetak opened a new pull request #1453: URL: https://github.com/apache/hive/pull/1453 ### What changes were proposed in this pull request? Remove double backtracking of columns inside ReduceSinkDeDuplicationUtils#ggressiveDedup. ### Why are the changes needed? To preve

[GitHub] [hive] jcamachor commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

2020-09-01 Thread GitBox
jcamachor commented on a change in pull request #1443: URL: https://github.com/apache/hive/pull/1443#discussion_r481291877 ## File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java ## @@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type)

[GitHub] [hive] thejasmn commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

2020-09-01 Thread GitBox
thejasmn commented on a change in pull request #1443: URL: https://github.com/apache/hive/pull/1443#discussion_r481295792 ## File path: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] scarlin-cloudera opened a new pull request #1454: HIVE-24105: Refactor partition pruning.

2020-09-01 Thread GitBox
scarlin-cloudera opened a new pull request #1454: URL: https://github.com/apache/hive/pull/1454 A small refactor of partition pruning. ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce

[GitHub] [hive] saihemanth-cloudera opened a new pull request #1455: Hive 21498

2020-09-01 Thread GitBox
saihemanth-cloudera opened a new pull request #1455: URL: https://github.com/apache/hive/pull/1455 ### What changes were proposed in this pull request? Thrift version upgrade ### Why are the changes needed? Version upgrade ### Does this PR introduc

[GitHub] [hive] kishendas commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

2020-09-01 Thread GitBox
kishendas commented on a change in pull request #1443: URL: https://github.com/apache/hive/pull/1443#discussion_r481415157 ## File path: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [hive] kishendas commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

2020-09-01 Thread GitBox
kishendas commented on a change in pull request #1443: URL: https://github.com/apache/hive/pull/1443#discussion_r481422408 ## File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java ## @@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type)

[GitHub] [hive] jcamachor commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

2020-09-01 Thread GitBox
jcamachor commented on a change in pull request #1443: URL: https://github.com/apache/hive/pull/1443#discussion_r481464936 ## File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java ## @@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type)

[GitHub] [hive] jcamachor merged pull request #1446: HIVE-22622: Hive allows to create a struct with duplicate attribute names

2020-09-01 Thread GitBox
jcamachor merged pull request #1446: URL: https://github.com/apache/hive/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] scarlin-cloudera closed pull request #1454: HIVE-24105: Refactor partition pruning.

2020-09-01 Thread GitBox
scarlin-cloudera closed pull request #1454: URL: https://github.com/apache/hive/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] github-actions[bot] commented on pull request #548: HIVE-21313: Use faster method to prevent copying bytes twice

2020-09-01 Thread GitBox
github-actions[bot] commented on pull request #548: URL: https://github.com/apache/hive/pull/548#issuecomment-685209614 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out

[GitHub] [hive] github-actions[bot] commented on pull request #1202: HIVE-23721 MetaStoreDirectSql.ensureDbInit() need to optimize QuerySQL

2020-09-01 Thread GitBox
github-actions[bot] commented on pull request #1202: URL: https://github.com/apache/hive/pull/1202#issuecomment-685209535 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] github-actions[bot] commented on pull request #1111: HIVE-23698: Filter PPD for probe-decode

2020-09-01 Thread GitBox
github-actions[bot] commented on pull request #: URL: https://github.com/apache/hive/pull/#issuecomment-685209559 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] github-actions[bot] commented on pull request #967: HIVE-23074: add "IF NOT EXISTS" for create & "IF EXISTS" for drop to …

2020-09-01 Thread GitBox
github-actions[bot] commented on pull request #967: URL: https://github.com/apache/hive/pull/967#issuecomment-685209595 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out

[GitHub] [hive] nrg4878 commented on pull request #1455: Hive 21498

2020-09-01 Thread GitBox
nrg4878 commented on pull request #1455: URL: https://github.com/apache/hive/pull/1455#issuecomment-685223039 Fix has been committed to master. Feel free to close this PR. This is an automated message from the Apache Git Serv

[GitHub] [hive] saihemanth-cloudera closed pull request #1455: Hive 21498

2020-09-01 Thread GitBox
saihemanth-cloudera closed pull request #1455: URL: https://github.com/apache/hive/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] saihemanth-cloudera closed pull request #1361: Exception type chhanged to TException for TestListPartitions#testList…

2020-09-01 Thread GitBox
saihemanth-cloudera closed pull request #1361: URL: https://github.com/apache/hive/pull/1361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] dengzhhu653 opened a new pull request #1456: HIVE-24106: Abort polling on the operation state when the current thr…

2020-09-01 Thread GitBox
dengzhhu653 opened a new pull request #1456: URL: https://github.com/apache/hive/pull/1456 …ead is interrupted ### What changes were proposed in this pull request? Abort polling on the operation state when the current thread is interrupted ### Why are the cha