Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487407259 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateInsertDeleteIncrementalRewritingRule.java: ## @@ -116,7 +121,7 @@ protected

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

sonarcloud[bot] commented on PR #4943: URL: https://github.com/apache/hive/pull/4943#issuecomment-1941518416 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28059: Iceberg REST Catalog [hive]

henrib commented on PR #5060: URL: https://github.com/apache/hive/pull/5060#issuecomment-1941319067 It does not seem like Gravitino exposes the Iceberg REST API; they do expose their own. ( see https://github.com/datastrato/gravitino/tree/main/docs/open-api ) -- This is an automated

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

sonarcloud[bot] commented on PR #4943: URL: https://github.com/apache/hive/pull/4943#issuecomment-1940929672 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487405424 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java: ## @@ -480,8 +515,6 @@ protected ASTNode

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487413419 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -92,86 +159,155 @@ public RelNode visit(HiveTableScan

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487412597 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -92,86 +159,155 @@ public RelNode visit(HiveTableScan

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487363349 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -92,86 +159,155 @@ public RelNode visit(HiveTableScan

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487410179 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -17,72 +17,139 @@ */ package

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487408972 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateInsertDeleteIncrementalRewritingRule.java: ## @@ -116,7 +121,7 @@ protected

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487411606 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -17,72 +17,139 @@ */ package

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487412138 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -92,86 +159,155 @@ public RelNode visit(HiveTableScan

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487406605 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java: ## @@ -322,8 +373,7 @@ private RelNode

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1487407259 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateInsertDeleteIncrementalRewritingRule.java: ## @@ -116,7 +121,7 @@ protected

Re: [PR] HIVE-27980: Hive Iceberg Compaction: add support for OPTIMIZE TABLE s… [hive]

deniskuzZ merged PR #5028: URL: https://github.com/apache/hive/pull/5028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

deniskuzZ commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1488226156 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java: ## @@ -92,86 +159,155 @@ public RelNode visit(HiveTableScan

Re: [PR] HIVE-28015: Iceberg: Add identifier-field-ids support in Hive [hive]

zhangbutao commented on PR #5047: URL: https://github.com/apache/hive/pull/5047#issuecomment-1941924222 > @zhangbutao, PR looks good, some minor stuff Thanks for your review! I've been out recently. Will come back asap.  -- This is an automated message from the Apache Git

Re: [PR] HIVE-27924: Incremental rebuild goes wrong when inserts and deletes overlap between the source tables [hive]

deniskuzZ commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1488216521 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewRewritingRelVisitor.java: ## @@ -50,7 +49,7 @@ public class

Re: [PR] HIVE-28015: Iceberg: Add identifier-field-ids support in Hive [hive]

deniskuzZ commented on PR #5047: URL: https://github.com/apache/hive/pull/5047#issuecomment-1941671311 @zhangbutao, PR looks good, some minor stuff -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] TestTxnDbUtil.queryToCsv - debug your metastore database in a csv format [hive]

InvisibleProgrammer opened a new pull request, #5083: URL: https://github.com/apache/hive/pull/5083 queryToString separates the columns with 3 spaces. It would improve the debugging experience if we have a method that shows the data in CSV format so that the output can be easily imported

Re: [PR] Hive 23690 : TestNegativeCliDriver#[external_jdbc_negative] is flaky [hive]

github-actions[bot] commented on PR #4941: URL: https://github.com/apache/hive/pull/4941#issuecomment-1942892531 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… [hive]

github-actions[bot] commented on PR #4938: URL: https://github.com/apache/hive/pull/4938#issuecomment-1942892565 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-25054: (2.3) Upgrade `jodd-core` dependency to get rid of CVE-2018-21234 [hive]

github-actions[bot] closed pull request #4923: HIVE-25054: (2.3) Upgrade `jodd-core` dependency to get rid of CVE-2018-21234 URL: https://github.com/apache/hive/pull/4923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] TestTxnDbUtil.queryToCsv - debug your metastore database in a csv format [hive]

sonarcloud[bot] commented on PR #5083: URL: https://github.com/apache/hive/pull/5083#issuecomment-1942855386 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1943126065 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27490: HPL/SQL says it support default value for parameters but not considering them when no value is passed [hive]

sonarcloud[bot] commented on PR #5084: URL: https://github.com/apache/hive/pull/5084#issuecomment-1943169250 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… [hive]

okumin commented on PR #4938: URL: https://github.com/apache/hive/pull/4938#issuecomment-1943046057 @aturoczy @InvisibleProgrammer Do you know anyone who can get this PR approved? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] HIVE-27490: HPL/SQL says it support default value for parameters but not considering them when no value is passed [hive]

mdayakar opened a new pull request, #5084: URL: https://github.com/apache/hive/pull/5084 HIVE-27490: HPL/SQL says it support default value for parameters but not considering them when no value is passed ### What changes were proposed in this pull request? The changes

Re: [PR] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… [hive]

SourabhBadhya commented on code in PR #4938: URL: https://github.com/apache/hive/pull/4938#discussion_r1488915249 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java: ## @@ -109,15 +118,15 @@ public StructObjectInspector initialize(ObjectInspector[]

Re: [PR] HIVE-28043 : Upgrade ZooKeeper to 3.8.3 [hive]

AnmolSun commented on PR #5046: URL: https://github.com/apache/hive/pull/5046#issuecomment-1943158919 Hello @ayushtkn , Could you please help in committing this once you get some time? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… [hive]

aturoczy commented on PR #4938: URL: https://github.com/apache/hive/pull/4938#issuecomment-1943092253 @SourabhBadhya @deniskuzZ @abstractdog Could you pls check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HIVE-28043 : Upgrade ZooKeeper to 3.8.3 [hive]

ayushtkn merged PR #5046: URL: https://github.com/apache/hive/pull/5046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: