zhangbutao merged PR #5024:
URL: https://github.com/apache/hive/pull/5024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##
@@ -747,4 +750,18 @@ default List
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500872749
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##
@@ -747,4 +750,18 @@ default List
thakkardharmik opened a new pull request, #3942:
URL: https://github.com/apache/hive/pull/3942
…e in oracle
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
nrg4878 commented on PR #3942:
URL: https://github.com/apache/hive/pull/3942#issuecomment-1961848660
re-opening the PR for review. We need to review and merge this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500857349
##
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java:
##
@@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) {
public RecordReader
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##
@@ -747,4 +750,18 @@ default List
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500871964
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##
@@ -747,4 +750,18 @@ default List
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500854772
##
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java:
##
@@ -370,7 +371,8 @@ private InputSplit[] getCombineSplits(JobConf job, int
numSplits,
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500818017
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##
@@ -720,4 +744,42 @@ private static FilesForCommit
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500862337
##
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java:
##
@@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) {
public RecordReader
soumyakanti3578 commented on code in PR #5092:
URL: https://github.com/apache/hive/pull/5092#discussion_r1501168235
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreClientWithLocalCache.java:
##
@@ -61,7 +61,6 @@
import
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500851164
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
zhangbutao merged PR #5087:
URL: https://github.com/apache/hive/pull/5087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500884580
##
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##
@@ -147,18 +171,23 @@ public List> getTasks(HiveConf conf, Object
objCtx) {
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500848177
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500889203
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -2021,4 +2023,34 @@ public List
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500868679
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##
@@ -747,4 +750,18 @@ default List
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500878277
##
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java:
##
@@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path
condInputPath, MoveWork
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500880192
##
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##
@@ -125,6 +133,22 @@ public ListBucketingCtx getLbCtx() {
public void
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1500852533
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
tarak271 commented on code in PR #4859:
URL: https://github.com/apache/hive/pull/4859#discussion_r1500923581
##
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java:
##
@@ -50,59 +49,53 @@
import java.io.IOException;
import
sonarcloud[bot] commented on PR #4859:
URL: https://github.com/apache/hive/pull/4859#issuecomment-1961739088
## [ {
for (String mSource :
sonarcloud[bot] commented on PR #4959:
URL: https://github.com/apache/hive/pull/4959#issuecomment-1961021208
## [