deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1512384810
##
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java:
##
@@ -691,6 +693,18 @@ Map> removeScheme(Map> pathToAliases) {
public RecordReader
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1512393832
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergStorageHandlerMergeProperties.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
cxzl25 commented on PR #5115:
URL: https://github.com/apache/hive/pull/5115#issuecomment-1978267220
cc @zhangbutao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #4761:
URL: https://github.com/apache/hive/pull/4761#issuecomment-1978205696
## [ {
LuciferYang commented on code in PR #5114:
URL: https://github.com/apache/hive/pull/5114#discussion_r1512387642
##
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##
@@ -203,100 +187,5 @@ public AppConfigurationEntry[]
getAppConfigurationEntry(String
deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1512388735
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##
@@ -178,7 +178,7 @@ public RecordReader>
getRecordReader(InputSplit
deniskuzZ commented on PR #4914:
URL: https://github.com/apache/hive/pull/4914#issuecomment-1978396992
> the upgrade order will not be `4.0.0-beta-1-to-4.1.0.hive` it would be
`4.0.0-beta-1-to-4.0.0` and then `4.0.0-to-4.1.0.hive`
thanks for spotting this, fixed
--
This is an
sonarcloud[bot] commented on PR #4914:
URL: https://github.com/apache/hive/pull/4914#issuecomment-1978529302
## [