Re: [PR] HIVE-28098: Fails to copy empty column statistics of materialized CTE [hive]

2024-03-06 Thread via GitHub
kasakrisz commented on code in PR #5106: URL: https://github.com/apache/hive/pull/5106#discussion_r1514334232 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -1600,26 +1600,35 @@ Table materializeCTE(String cteName, CTEClause cte) throws

[PR] HIVE-28107: Remove the docs directory [hive]

2024-03-06 Thread via GitHub
simhadri-g opened a new pull request, #5119: URL: https://github.com/apache/hive/pull/5119 ### What changes were proposed in this pull request? ### Why are the changes needed? The doc directory was used to host the old hive website. Since the

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #5096: URL: https://github.com/apache/hive/pull/5096#issuecomment-1981274191 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #5118: URL: https://github.com/apache/hive/pull/5118#issuecomment-1981385891 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28028: Remove duplicated proto reader/writer classes introduced in HIVE-19288 [hive]

2024-03-06 Thread via GitHub
Aggarwal-Raghav commented on code in PR #5079: URL: https://github.com/apache/hive/pull/5079#discussion_r1514878050 ## itests/hive-unit/pom.xml: ## @@ -116,6 +116,32 @@ + Review Comment: @abstractdog, apologies for delay. Can you provide your

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1981653980 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28107: Remove the docs directory [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #5119: URL: https://github.com/apache/hive/pull/5119#issuecomment-1981752880 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27663 - implement array_position UDF in Hive [hive]

2024-03-06 Thread via GitHub
saihemanth-cloudera merged PR #4653: URL: https://github.com/apache/hive/pull/4653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27746: Hive Metastore should send single AlterPartitionEvent wit… [hive]

2024-03-06 Thread via GitHub
dengzhhu653 closed pull request #4820: HIVE-27746: Hive Metastore should send single AlterPartitionEvent wit… URL: https://github.com/apache/hive/pull/4820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-06 Thread via GitHub
amansinha100 commented on code in PR #5096: URL: https://github.com/apache/hive/pull/5096#discussion_r1515630621 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewIncrementalRewritingRelVisitor.java: ## @@ -17,97 +17,255 @@ package

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-06 Thread via GitHub
amansinha100 commented on code in PR #5096: URL: https://github.com/apache/hive/pull/5096#discussion_r1515630621 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewIncrementalRewritingRelVisitor.java: ## @@ -17,97 +17,255 @@ package

Re: [PR] HIVE-27746: Hive Metastore should send single AlterPartitionEvent wit… [hive]

2024-03-06 Thread via GitHub
dengzhhu653 commented on PR #4820: URL: https://github.com/apache/hive/pull/4820#issuecomment-1982281268 > LGTM +1, Pending green ptests. The latest two runs are successful, the build failure is caused by Sonar, > [2024-03-07T00:56:43.905Z] [ERROR] Failed to execute goal

[PR] Hadoop. [hive]

2024-03-06 Thread via GitHub
ayushtkn opened a new pull request, #5120: URL: https://github.com/apache/hive/pull/5120 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27746: Hive Metastore should send single AlterPartitionEvent wit… [hive]

2024-03-06 Thread via GitHub
sonarcloud[bot] commented on PR #4820: URL: https://github.com/apache/hive/pull/4820#issuecomment-1982377053 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28105:Beeline: Show current database in prompt [hive]

2024-03-06 Thread via GitHub
InvisibleProgrammer commented on PR #5117: URL: https://github.com/apache/hive/pull/5117#issuecomment-1980337455 Interesting idea. Personally, I like it. Also, I'm not sure if the change should be a new default. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HIVE-27925: Addendum: HiveConf: unify ConfVars enum and use underscor… [hive]

2024-03-06 Thread via GitHub
InvisibleProgrammer commented on PR #5107: URL: https://github.com/apache/hive/pull/5107#issuecomment-1980371052 LGTM (Non binding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HIVE-27925: Addendum: HiveConf: unify ConfVars enum and use underscore for better readability [hive]

2024-03-06 Thread via GitHub
abstractdog merged PR #5107: URL: https://github.com/apache/hive/pull/5107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: