Re: [PR] WIP. [hive]

2024-03-07 Thread via GitHub
ayushtkn closed pull request #5120: WIP. URL: https://github.com/apache/hive/pull/5120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27671 - Implement array_append UDF to append an element to array [hive]

2024-03-07 Thread via GitHub
sonarcloud[bot] commented on PR #5121: URL: https://github.com/apache/hive/pull/5121#issuecomment-1984207723 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28105:Beeline: Show current database in prompt [hive]

2024-03-07 Thread via GitHub
tanishq-chugh commented on PR #5117: URL: https://github.com/apache/hive/pull/5117#issuecomment-1984296833 @ayushtkn Then, Are there any reasons of why aren't we keeping this functionality active by default? Because i believe it would be better if we do so. -- This is an automated

Re: [PR] HIVE-28105:Beeline: Show current database in prompt [hive]

2024-03-07 Thread via GitHub
ayushtkn commented on PR #5117: URL: https://github.com/apache/hive/pull/5117#issuecomment-1984187188 this functionallity is already there just launch beeline like ``` beeline -u 'jdbc:hive2://localhost:1/' --showDbInPrompt=true ``` ``` ayushsaxena@ayushsaxena docker %

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-03-07 Thread via GitHub
zhangbutao commented on PR #5054: URL: https://github.com/apache/hive/pull/5054#issuecomment-1985206960 > @zhangbutao : thanks for your comments, according to the last comment, I'm considering this as approved, let me know if it's otherwise Yes, free to merge this change. :) --

Re: [PR] HIVE-25799: Add java rule [hive]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #2866: URL: https://github.com/apache/hive/pull/2866#issuecomment-1984827826 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-03-07 Thread via GitHub
abstractdog merged PR #5054: URL: https://github.com/apache/hive/pull/5054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28051: LLAP: cleanup local folders on startup and periodically [hive]

2024-03-07 Thread via GitHub
abstractdog commented on PR #5054: URL: https://github.com/apache/hive/pull/5054#issuecomment-1985203059 @zhangbutao : thanks for you comments, according to the last comment, I'm considering this as approved, let me know if it's otherwise -- This is an automated message from the Apache

Re: [PR] HIVE-27741 handle Invalid timezone value in to_utc_timestamp() UDF [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5014: URL: https://github.com/apache/hive/pull/5014#discussion_r1516186663 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java: ## @@ -88,31 +88,42 @@ public Object evaluate(DeferredObject[] arguments) throws

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
InvisibleProgrammer commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516214769 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE",

Re: [PR] HIVE-28100. Fix Some Typos in CachedStore. [hive]

2024-03-07 Thread via GitHub
zhangbutao merged PR #5109: URL: https://github.com/apache/hive/pull/5109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27741 handle Invalid timezone value in to_utc_timestamp() UDF [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5014: URL: https://github.com/apache/hive/pull/5014#discussion_r1516195127 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java: ## @@ -88,31 +88,42 @@ public Object evaluate(DeferredObject[] arguments) throws

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
InvisibleProgrammer commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516203028 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE",

Re: [PR] HIVE-28105:Beeline: Show current database in prompt [hive]

2024-03-07 Thread via GitHub
tanishq-chugh commented on PR #5117: URL: https://github.com/apache/hive/pull/5117#issuecomment-1983425559 @InvisibleProgrammer This functionality is targeted to be default in this PR because the aim is to make beeline usage more user-friendly especially for the new users, and they won't

Re: [PR] HIVE-27741 handle Invalid timezone value in to_utc_timestamp() UDF [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5014: URL: https://github.com/apache/hive/pull/5014#discussion_r1516196517 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java: ## @@ -88,31 +88,42 @@ public Object evaluate(DeferredObject[] arguments) throws

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-07 Thread via GitHub
abstractdog commented on code in PR #5096: URL: https://github.com/apache/hive/pull/5096#discussion_r1515794350 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/show/ShowMaterializedViewsFormatter.java: ## @@ -136,27 +135,19 @@ void

Re: [PR] HIVE-27939: Many UNION ALL throws SemanticException when trying to remove partition predicates: fail to find child from parent [hive]

2024-03-07 Thread via GitHub
ryukobayashi closed pull request #4992: HIVE-27939: Many UNION ALL throws SemanticException when trying to remove partition predicates: fail to find child from parent URL: https://github.com/apache/hive/pull/4992 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HIVE-27939: Many UNION ALL throws SemanticException when trying to remove partition predicates: fail to find child from parent [hive]

2024-03-07 Thread via GitHub
ryukobayashi commented on PR #4992: URL: https://github.com/apache/hive/pull/4992#issuecomment-1982921778 Since it no longer occurs by setting the `hive.optimize.cte.materialize.full.aggregate.only` property to false, we will close it for now. -- This is an automated message from the

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-07 Thread via GitHub
abstractdog commented on code in PR #5096: URL: https://github.com/apache/hive/pull/5096#discussion_r1515794350 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/show/ShowMaterializedViewsFormatter.java: ## @@ -136,27 +135,19 @@ void

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-07 Thread via GitHub
abstractdog commented on PR #5096: URL: https://github.com/apache/hive/pull/5096#issuecomment-1983037854 LGTM, only a minor nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HIVE-28100. Fix Some Typos in CachedStore. [hive]

2024-03-07 Thread via GitHub
slfan1989 commented on PR #5109: URL: https://github.com/apache/hive/pull/5109#issuecomment-1982918592 @zhangbutao Thanks for reviewing this PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurreā€¦ [hive]

2024-03-07 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1982974644 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-07 Thread via GitHub
kasakrisz commented on code in PR #5096: URL: https://github.com/apache/hive/pull/5096#discussion_r1516366177 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/show/ShowMaterializedViewsFormatter.java: ## @@ -136,27 +135,19 @@ void

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516381314 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE", "MYSQL",

Re: [PR] HIVE-28006: Materialized view with aggregate function incorrectly shows it allows incremental rebuild [hive]

2024-03-07 Thread via GitHub
sonarcloud[bot] commented on PR #5096: URL: https://github.com/apache/hive/pull/5096#issuecomment-1983957754 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28037 run multiple Qtest with Postgre [hive]

2024-03-07 Thread via GitHub
zratkai commented on code in PR #5118: URL: https://github.com/apache/hive/pull/5118#discussion_r1516378255 ## itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java: ## @@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE", "MYSQL",

Re: [PR] HIVE-27741 handle Invalid timezone value in to_utc_timestamp() UDF [hive]

2024-03-07 Thread via GitHub
sonarcloud[bot] commented on PR #5014: URL: https://github.com/apache/hive/pull/5014#issuecomment-1983877559 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-27671 - Implement array_append UDF to append an element to array [hive]

2024-03-07 Thread via GitHub
tarak271 opened a new pull request, #5121: URL: https://github.com/apache/hive/pull/5121 ### What changes were proposed in this pull request? Implement array_append function in Hive ### Why are the changes needed? This enhancement is already implemented in Spark