Re: [PR] HIVE-28118: Hive Insert Into S3 with Viewfs overload scheme fails wit… [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5137: URL: https://github.com/apache/hive/pull/5137#issuecomment-2031029246 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
cxzl25 commented on code in PR #5141: URL: https://github.com/apache/hive/pull/5141#discussion_r1547103914 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1525,30 +1527,33 @@ public void visit(LeafNode

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-04-01 Thread via GitHub
shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1547115174 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test public

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5141: URL: https://github.com/apache/hive/pull/5141#issuecomment-2031094098 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28041 : Upgrade jetty to 9.4.53 due to CVE-2023-44487 [hive]

2024-04-01 Thread via GitHub
github-actions[bot] commented on PR #5044: URL: https://github.com/apache/hive/pull/5044#issuecomment-2030838165 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-27987: Implement YESTERDAY UDF in Hive [hive]

2024-04-01 Thread via GitHub
github-actions[bot] closed pull request #4985: HIVE-27987: Implement YESTERDAY UDF in Hive URL: https://github.com/apache/hive/pull/4985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] WIP [hive]

2024-04-01 Thread via GitHub
github-actions[bot] closed pull request #4380: WIP URL: https://github.com/apache/hive/pull/4380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-04-01 Thread via GitHub
shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1547102223 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
cxzl25 commented on code in PR #5141: URL: https://github.com/apache/hive/pull/5141#discussion_r1547105782 ## standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java: ## @@ -416,15 +416,31 @@ static

Re: [PR] HIVE-28042: DigestMD5 token expired or does not exist issue while opening connection to HMS [hive]

2024-04-01 Thread via GitHub
chinnaraolalam commented on code in PR #5049: URL: https://github.com/apache/hive/pull/5049#discussion_r1546734698 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ## @@ -956,14 +986,16 @@ private TTransport

Re: [PR] HIVE-28110: MetastoreConf - String casting of default values breaks Hive [hive]

2024-04-01 Thread via GitHub
tanishq-chugh commented on PR #5160: URL: https://github.com/apache/hive/pull/5160#issuecomment-2029436848 Added the Unit tests corresponding to the changes for the case specified in the JIRA. For other regular cases using the changes methods, the test named "default" in

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
ayushtkn commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546436963 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1772,6 +1772,10 @@ private List

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-04-01 Thread via GitHub
chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1546686701 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test

Re: [PR] HIVE-28042: DigestMD5 token expired or does not exist issue while opening connection to HMS [hive]

2024-04-01 Thread via GitHub
chinnaraolalam commented on code in PR #5049: URL: https://github.com/apache/hive/pull/5049#discussion_r1546738985 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java: ## @@ -103,6 +105,10

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5173: URL: https://github.com/apache/hive/pull/5173#issuecomment-2030135329 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-26986: Fix OperatorGraph when a query plan contains UnionOperator [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #3998: URL: https://github.com/apache/hive/pull/3998#issuecomment-2030259092 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-04-01 Thread via GitHub
chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1546692298 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
ayushtkn commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546891125 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1817,6 +1821,8 @@ public boolean

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546519096 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1817,6 +1821,8 @@ public boolean

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
wecharyu commented on code in PR #5141: URL: https://github.com/apache/hive/pull/5141#discussion_r1546303260 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1525,30 +1527,33 @@ public void visit(LeafNode

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5141: URL: https://github.com/apache/hive/pull/5141#issuecomment-2029844799 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
ayushtkn commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546440222 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ## @@ -2104,9 +2106,14 @@ public void

Re: [PR] HIVE-28110: MetastoreConf - String casting of default values breaks Hive [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5160: URL: https://github.com/apache/hive/pull/5160#issuecomment-2029515955 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546385912 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -1530,7 +1530,11 @@ public void truncateTable(String dbDotTableName, Map partSpec, L List

Re: [PR] HIVE-27512: CalciteSemanticException.UnsupportedFeature enum to capital [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #4894: URL: https://github.com/apache/hive/pull/4894#issuecomment-2029597631 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546375621 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ## @@ -2104,9 +2106,14 @@ public void

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546415961 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java: ## @@ -87,7 +87,7 @@ public void analyzeInternal(ASTNode root) throws

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546421228 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1772,6 +1772,10 @@ private List

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546418512 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1817,6 +1821,8 @@ public boolean

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
ayushtkn commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546434085 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1817,6 +1821,8 @@ public boolean

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
ayushtkn commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546453615 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -1530,7 +1530,11 @@ public void truncateTable(String dbDotTableName, Map partSpec, L List

Re: [PR] HIVE-28167: Iceberg: Full table deletion fails when using Copy-on-write [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5175: URL: https://github.com/apache/hive/pull/5175#issuecomment-2029637738 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546533653 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -1530,7 +1530,11 @@ public void truncateTable(String dbDotTableName, Map partSpec, L List

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546533653 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -1530,7 +1530,11 @@ public void truncateTable(String dbDotTableName, Map partSpec, L List

Re: [PR] HIVE-28118: Hive Insert Into S3 with Viewfs overload scheme fails wit… [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5137: URL: https://github.com/apache/hive/pull/5137#issuecomment-2029876660 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28166: Iceberg: Truncate on branch operates on the main table. [hive]

2024-04-01 Thread via GitHub
deniskuzZ commented on code in PR #5173: URL: https://github.com/apache/hive/pull/5173#discussion_r1546418512 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1817,6 +1821,8 @@ public boolean

Re: [PR] HIVE-28137: Append Multi-Level Partition Filtering in Direct SQL Implementation of getPartitionsByFilter [hive]

2024-04-01 Thread via GitHub
wecharyu commented on code in PR #5141: URL: https://github.com/apache/hive/pull/5141#discussion_r1546305103 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1525,30 +1527,33 @@ public void visit(LeafNode

Re: [PR] HIVE-26986: Fix OperatorGraph when a query plan contains UnionOperator [hive]

2024-04-01 Thread via GitHub
ngsg commented on code in PR #3998: URL: https://github.com/apache/hive/pull/3998#discussion_r1546273306 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java: ## @@ -1863,12 +1863,19 @@ private static boolean validPreConditions(ParseContext pctx,

Re: [PR] HIVE-26986: Fix OperatorGraph when a query plan contains UnionOperator [hive]

2024-04-01 Thread via GitHub
ngsg commented on code in PR #3998: URL: https://github.com/apache/hive/pull/3998#discussion_r1546272610 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/graph/OperatorGraph.java: ## @@ -81,183 +76,202 @@ public EdgeType getEdgeType() { } - public static interface

Re: [PR] HIVE-28121: Use direct SQL for transactional altering table parameter [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5129: URL: https://github.com/apache/hive/pull/5129#issuecomment-2029322188 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28167: Iceberg: Full table deletion fails when using Copy-on-write [hive]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #5175: URL: https://github.com/apache/hive/pull/5175#issuecomment-2029221070 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate