[PR] HIVE-28194: Regenerate HS2 thrift port in TestRetryingThriftCLIServiceClient [hive]

armitage420 opened a new pull request, #5205: URL: https://github.com/apache/hive/pull/5205 ### What changes were proposed in this pull request? Hive thrift port was hardcoded to 15000, hence port regeneration code was added here ### Why are the changes needed?

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

sonarcloud[bot] commented on PR #5191: URL: https://github.com/apache/hive/pull/5191#issuecomment-2068473576 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28207: NullPointerException is thrown when checking column uniqueness [hive]

ayushtkn commented on PR #5207: URL: https://github.com/apache/hive/pull/5207#issuecomment-2068492259 > RelMetadataQuery#areColumnsUnique returns true, false, or null. why is it returning `null`, columns can be either unique or not unique, what `null` denotes here? -- This is an

Re: [PR] HIVE-28207: NullPointerException is thrown when checking column uniqueness [hive]

okumin commented on PR #5207: URL: https://github.com/apache/hive/pull/5207#issuecomment-2068524290 @ayushtkn Calcite can express the three statuses, either of "it is definitely unique", "it is not definitely unique", or unknown. Null stands for the last case. If it is null, this PR

Re: [PR] HIVE-28194: Regenerate HS2 thrift port in TestRetryingThriftCLIServiceClient [hive]

sonarcloud[bot] commented on PR #5205: URL: https://github.com/apache/hive/pull/5205#issuecomment-2067991287 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28194: Regenerate HS2 thrift port in TestRetryingThriftCLIServiceClient [hive]

sonarcloud[bot] commented on PR #5205: URL: https://github.com/apache/hive/pull/5205#issuecomment-2068043608 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28205: Implement direct sql for get_partitions_ps_with_auth api [hive]

sonarcloud[bot] commented on PR #5206: URL: https://github.com/apache/hive/pull/5206#issuecomment-2068051112 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Update Hive version in Docker README [hive]

dengzhhu653 commented on PR #5105: URL: https://github.com/apache/hive/pull/5105#issuecomment-2068051936 @mertyyanik Thank you for the PR, we use jira for issues/case management: https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-JIRA, could you please create

Re: [PR] HIVE-28204: Remove some HMS obsolete scripts [hive]

dengzhhu653 commented on PR #5201: URL: https://github.com/apache/hive/pull/5201#issuecomment-2068048343 > > > Hi, is that some legacy way how we handled the metastore upgrade scripts at an old Hive version? > > > > > > The upgrade story is almost the same, while these deleted

[PR] HIVE-28207: NullPointerException is thrown when checking column uniqueness [hive]

okumin opened a new pull request, #5207: URL: https://github.com/apache/hive/pull/5207 ### What changes were proposed in this pull request? Add a null check when using `RelMetadataQuery#areColumnsUnique`. https://issues.apache.org/jira/browse/HIVE-28207 ### Why are the

Re: [PR] HIVE-28161: Incorrect Copyright years in META-INF/NOTICE files [hive]

dengzhhu653 commented on PR #5169: URL: https://github.com/apache/hive/pull/5169#issuecomment-2068063123 Hi @zabetak, hive-standalone-metastore-server-4.1.0-SNAPSHOT.jar this jar still has the incorrect content, cloud you please check that? thank you! ``` Copyright 2020 The Apache

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

sonarcloud[bot] commented on PR #5191: URL: https://github.com/apache/hive/pull/5191#issuecomment-2068080068 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573858388 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -133,7 +138,7 @@ private List getPartitions(Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573873316 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +55,71 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573881457 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -782,7 +782,7 @@ private void

Re: [PR] HIVE-28207: NullPointerException is thrown when checking column uniqueness [hive]

sonarcloud[bot] commented on PR #5207: URL: https://github.com/apache/hive/pull/5207#issuecomment-2068128436 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573856606 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -750,6 +750,11 @@ default boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573873316 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +55,71 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573873316 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +55,71 @@ public boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573856606 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -750,6 +750,11 @@ default boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573859264 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -61,6 +62,10 @@ public

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573856606 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -750,6 +750,11 @@ default boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573866315 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -94,10 +98,20 @@ public static ExprNodeGenericFuncDesc

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573866442 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -108,10 +122,18 @@ public static Partition getPartition(Hive db, Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573866442 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -108,10 +122,18 @@ public static Partition getPartition(Hive db, Table table,

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573884289 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1915,6 +1915,28 @@ private boolean

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1573884289 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1915,6 +1915,28 @@ private boolean

Re: [PR] HIVE-24167: TPC-DS query 14 fails while generating plan for the filter [hive]

okumin commented on PR #5077: URL: https://github.com/apache/hive/pull/5077#issuecomment-2068290571 > For instance running cbo_query23.q with the above properties set raises an exception. Thanks. Predicate Push-Down and Partition Condition Remover cause the problem. I modified it on