Re: [PR] HIVE-26926: SHOW PARTITIONS for a non partitioned table should just throw execution error instead of full stack trace. [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5164: URL: https://github.com/apache/hive/pull/5164#issuecomment-2079182789 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
soumyakanti3578 commented on code in PR #5131: URL: https://github.com/apache/hive/pull/5131#discussion_r1580694809 ## ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: ## @@ -1745,9 +1748,72 @@ public RelNode apply(RelOptCluster cluster, RelOptSchema

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5131: URL: https://github.com/apache/hive/pull/5131#issuecomment-2078942424 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5215: URL: https://github.com/apache/hive/pull/5215#issuecomment-2078942606 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28163: Upgrade apache directory server to 2.0.0-M24 [hive]

2024-04-26 Thread via GitHub
Aggarwal-Raghav commented on PR #5171: URL: https://github.com/apache/hive/pull/5171#issuecomment-2079180540 @ayushtkn, can you please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HIVE-28164: Remove log4j transitive dependency [hive]

2024-04-26 Thread via GitHub
Aggarwal-Raghav commented on PR #5172: URL: https://github.com/apache/hive/pull/5172#issuecomment-2079178282 Apologies for the late response, Have updated the PR with suggested changes. I have created a new enforcer execution step to search for transitive dependencies of log4j. The scope

Re: [PR] HIVE-27370: support 4 bytes characters [hive]

2024-04-26 Thread via GitHub
ryukobayashi commented on PR #5002: URL: https://github.com/apache/hive/pull/5002#issuecomment-2078822822 Hi @deniskuzZ I would if you could check about this when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] HIVE-28220: Reset sessionVars before updating connection params from zookeeper [hive]

2024-04-26 Thread via GitHub
wForget opened a new pull request, #5217: URL: https://github.com/apache/hive/pull/5217 ### What changes were proposed in this pull request? Reset sessionVars before updating connection params from zookeeper. ### Why are the changes needed? When jdbc connection

Re: [PR] HIVE-28220: Reset sessionVars before updating connection params from zookeeper [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5217: URL: https://github.com/apache/hive/pull/5217#issuecomment-2078808830 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]

2024-04-26 Thread via GitHub
difin opened a new pull request, #5218: URL: https://github.com/apache/hive/pull/5218 ### What changes were proposed in this pull request? Upgrading Orc version in Hive to the latest version that supports Java 8 - 1.9.3 ### Why are the changes needed? To keep

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
soumyakanti3578 commented on code in PR #5131: URL: https://github.com/apache/hive/pull/5131#discussion_r1581351989 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelJson.java: ## @@ -43,9 +127,170 @@ public Object toJson(Object value) { if (value

Re: [PR] HIVE-28164: Remove log4j transitive dependency [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5172: URL: https://github.com/apache/hive/pull/5172#issuecomment-2079746024 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Update Hive version in Docker README [hive]

2024-04-26 Thread via GitHub
mertyyanik commented on PR #5105: URL: https://github.com/apache/hive/pull/5105#issuecomment-2079970218 I requested an account 4 days ago and waiting. When the account arrives, I will create a case. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
kasakrisz commented on code in PR #5131: URL: https://github.com/apache/hive/pull/5131#discussion_r1580753007 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelJson.java: ## @@ -43,9 +127,170 @@ public Object toJson(Object value) { if (value instanceof

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
soumyakanti3578 commented on code in PR #5131: URL: https://github.com/apache/hive/pull/5131#discussion_r1581513228 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelPlanParser.java: ## @@ -0,0 +1,477 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2080191445 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #5131: URL: https://github.com/apache/hive/pull/5131#issuecomment-2080142518 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

2024-04-26 Thread via GitHub
soumyakanti3578 commented on code in PR #5131: URL: https://github.com/apache/hive/pull/5131#discussion_r1581522802 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelPlanParser.java: ## @@ -0,0 +1,477 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under