Re: [PR] [Test] branch-4.0 [hive]

2024-07-18 Thread via GitHub
dengzhhu653 merged PR #5356: URL: https://github.com/apache/hive/pull/5356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-28374: Iceberg: Handle change of default format-version. [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5351: URL: https://github.com/apache/hive/pull/5351#issuecomment-2235838535 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

[PR] HIVE-27032: Introduce liquibase for HMS schema evolution [hive]

2024-07-18 Thread via GitHub
kuczoram opened a new pull request, #5357: URL: https://github.com/apache/hive/pull/5357 (cherry picked from commit 35756040ae865154dae7061d515a0e52eee7d0d9) ### What changes were proposed in this pull request? ### Why are the changes needed? ### D

Re: [PR] [WIP] Digest md5 issue duplicate [hive]

2024-07-18 Thread via GitHub
vikramahuja1001 closed pull request #5353: [WIP] Digest md5 issue duplicate URL: https://github.com/apache/hive/pull/5353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [WIP] Digest md5 issue duplicate [hive]

2024-07-18 Thread via GitHub
vikramahuja1001 opened a new pull request, #5358: URL: https://github.com/apache/hive/pull/5358 Do not review ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

Re: [PR] HIVE-28042: DigestMD5 token expired or does not exist issue while opening connection to HMS [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5303: URL: https://github.com/apache/hive/pull/5303#issuecomment-2236141138 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27032: Introduce liquibase for HMS schema evolution [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5357: URL: https://github.com/apache/hive/pull/5357#issuecomment-2236185409 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] [WIP] Digest md5 issue duplicate [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5358: URL: https://github.com/apache/hive/pull/5358#issuecomment-2236231690 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27855: Create external tables for Hive and Tez protologging events [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5036: URL: https://github.com/apache/hive/pull/5036#issuecomment-2236363883 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

[PR] HIVE-28375:Upgrade Nimbus-JOSE-JWT to 9.37.3 [hive]

2024-07-18 Thread via GitHub
devaspatikrishnatri opened a new pull request, #5359: URL: https://github.com/apache/hive/pull/5359 ### What changes were proposed in this pull request? Upgrades nimbus-jose-jwt to 9.37.3 and removes the older versions being pulled in transitively. ### Why are the chang

Re: [PR] HIVE-28042: DigestMD5 token expired or does not exist issue while opening connection to HMS [hive]

2024-07-18 Thread via GitHub
vikramahuja1001 closed pull request #5303: HIVE-28042: DigestMD5 token expired or does not exist issue while opening connection to HMS URL: https://github.com/apache/hive/pull/5303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HIVE-28375:Upgrade Nimbus-JOSE-JWT to 9.37.3 [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5359: URL: https://github.com/apache/hive/pull/5359#issuecomment-2236663465 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-26473 WIP: Dont review [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2236866602 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28321 Support select alias in the having clause for CBO [hive]

2024-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #5294: URL: https://github.com/apache/hive/pull/5294#issuecomment-2237069356 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28208: WITH column list doesn't work with CTE materialization [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on PR #5232: URL: https://github.com/apache/hive/pull/5232#issuecomment-2237354747 cc @zabetak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1683375579 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test public vo

Re: [PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5262: URL: https://github.com/apache/hive/pull/5262#discussion_r1683425280 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateReduceFunctionsRule.java: ## @@ -540,7 +546,7 @@ private RexNode reduceStddev( final

Re: [PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5262: URL: https://github.com/apache/hive/pull/5262#discussion_r1683425280 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateReduceFunctionsRule.java: ## @@ -540,7 +546,7 @@ private RexNode reduceStddev( final

Re: [PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5262: URL: https://github.com/apache/hive/pull/5262#discussion_r1683432966 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateReduceFunctionsRule.java: ## @@ -517,6 +517,12 @@ private RexNode reduceStddev( re

Re: [PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5262: URL: https://github.com/apache/hive/pull/5262#discussion_r1683432966 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateReduceFunctionsRule.java: ## @@ -517,6 +517,12 @@ private RexNode reduceStddev( re

Re: [PR] HIVE-28347: Make a UDAF 'collect_set' work with complex types, even when map-side aggregation is disabled. [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on code in PR #5323: URL: https://github.com/apache/hive/pull/5323#discussion_r1683445393 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java: ## @@ -62,22 +62,16 @@ public ObjectInspector init(Mode m, ObjectInspector[]

Re: [PR] HIVE-28358: Enable JDBC getClob retrieval from String columns [hive]

2024-07-18 Thread via GitHub
deniskuzZ commented on PR #5336: URL: https://github.com/apache/hive/pull/5336#issuecomment-2237531108 @vpinna80, could you please add tests for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] HIVE-28372: No need to update partitions stats when renaming table [hive]

2024-07-18 Thread via GitHub
dengzhhu653 merged PR #5329: URL: https://github.com/apache/hive/pull/5329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-28350: Drop remote database should succeed deleting data under d… [hive]

2024-07-18 Thread via GitHub
dengzhhu653 commented on PR #5322: URL: https://github.com/apache/hive/pull/5322#issuecomment-2237833634 I'm not sure how the fix can solve the problem, might the `mdb.getLocationUri()` or `mdb.getManagedLocationUri()` is null for remote database? -- This is an automated message from the

Re: [PR] HIVE-28347: Make a UDAF 'collect_set' work with complex types, even when map-side aggregation is disabled. [hive]

2024-07-18 Thread via GitHub
JeongDaeKim commented on code in PR #5323: URL: https://github.com/apache/hive/pull/5323#discussion_r1683714535 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java: ## @@ -62,22 +62,16 @@ public ObjectInspector init(Mode m, ObjectInspector[

Re: [PR] HIVE-28347: Make a UDAF 'collect_set' work with complex types, even when map-side aggregation is disabled. [hive]

2024-07-18 Thread via GitHub
JeongDaeKim commented on code in PR #5323: URL: https://github.com/apache/hive/pull/5323#discussion_r1683714535 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java: ## @@ -62,22 +62,16 @@ public ObjectInspector init(Mode m, ObjectInspector[

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-07-18 Thread via GitHub
shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1683756644 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test public vo

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-07-18 Thread via GitHub
chinnaraolalam commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2238168629 +1 Thanks for the review Ayush Saxena, Denys Kuzmenko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL