[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r455136416 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java ## @@ -207,4 +217,20 @@ public ReplicationMetricCollector

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454940146 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454929778 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454928086 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileListStreamer.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454926767 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java ## @@ -1559,6 +1645,76 @@ public void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454923611 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java ## @@ -165,4 +178,83 @@ private void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454923124 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java ## @@ -165,4 +178,83 @@ private void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454921294 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java ## @@ -207,4 +217,20 @@ public ReplicationMetricCollector

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454919825 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java ## @@ -210,6 +210,66 @@ public

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454918458 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java ## @@ -210,6 +210,66 @@ public

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454909369 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java ## @@ -1559,6 +1645,76 @@ public void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454907711 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/util/TestFileList.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454907220 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java ## @@ -165,4 +178,83 @@ private void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r453587433 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/InsertHandler.java ## @@ -76,16 +77,29 @@ public void handle(Context

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r453254993 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java ## @@ -165,4 +175,92 @@ private void

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452816736 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java ## @@ -330,6 +333,20 @@ a database ( directory ) return 0; } +

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452816170 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileListStreamer.java ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452815690 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileListStreamer.java ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452813518 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileListStreamer.java ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452812877 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452812525 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452812001 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452811664 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java ## @@ -591,14 +590,25 @@ private Long incrementalDump(Path dumpRoot,

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452810700 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/FileList.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] pkumarsinha commented on a change in pull request #1225: HIVE-23069 Memory efficient iterator should be used during replicatio…

pkumarsinha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r452810053 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java ## @@ -465,9 +463,13 @@ private Long incrementalDump(Path dumpRoot,