[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-14 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then embeds

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313731994 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313731994 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313739151 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313739151 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313765154 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
michaelandrepearce opened a new pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796 @jbertram this is partially what i was trying to explain as an alternative approach to simply remove the need for the cache

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-14 Thread GitBox
michaelandrepearce edited a comment on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313731994 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313740128 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313731309 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313740128 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313765154 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313734672 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313734672 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313726708 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313730591 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-14 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521142429 Just to be clear this is not a negative vote but more im trying to invoke a discussion as there

[GitHub] [activemq-artemis] jbertram closed pull request #2797: Travis test

2019-08-14 Thread GitBox
jbertram closed pull request #2797: Travis test URL: https://github.com/apache/activemq-artemis/pull/2797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [activemq-artemis] jbertram opened a new pull request #2798: NO-JIRA fix failing Travis build

2019-08-14 Thread GitBox
jbertram opened a new pull request #2798: NO-JIRA fix failing Travis build URL: https://github.com/apache/activemq-artemis/pull/2798 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [activemq-artemis] jbertram commented on issue #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
jbertram commented on issue #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#issuecomment-521398595 Closing in favor of #2796. This is an automated message from the

[GitHub] [activemq-artemis] jbertram closed pull request #2794: ARTEMIS-2451 limit size of destination cache

2019-08-14 Thread GitBox
jbertram closed pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521398981 BTW, the issue I saw wasn't a leak, per se. It was simply unwanted accumulation based on the way it was designed.

[GitHub] [activemq-artemis] jbertram opened a new pull request #2797: Travis test

2019-08-14 Thread GitBox
jbertram opened a new pull request #2797: Travis test URL: https://github.com/apache/activemq-artemis/pull/2797 I'm doing some testing to try to fix the Travis build. Do not merge. This is an automated message from the Apache

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#discussion_r314044717 ## File path:

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#discussion_r314044316 ## File path:

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#discussion_r314044552 ## File path:

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on a change in pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#discussion_r314044808 ## File path:

[GitHub] [activemq-artemis] gemmellr commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-14 Thread GitBox
gemmellr commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521271924 I think this is a reasonable enough thing to do in the circumstance. The properties that would be created

[GitHub] [activemq-artemis] jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

2019-08-14 Thread GitBox
jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521365341 At first glance this looks like a clever solution and better than the one I came up with. Let me review it in more