[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314189516 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027 Yes, sure and will provide proper test coverage too as it deserves :) Thanks for the suggestions

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted accumulation

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit

cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-521632602 Hey I found that the provider sends transfer frames on a sender link as settled even when the link sender settled mode is Unsettled. This is against

[GitHub] [activemq] coheigea opened a new pull request #389: AMQ-7275 - Update Commons BeanUtils

coheigea opened a new pull request #389: AMQ-7275 - Update Commons BeanUtils URL: https://github.com/apache/activemq/pull/389 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE

michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314189108 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397 Why not have a setting that makes it behave as old version, then once all servers uograded the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521554151 Also why would having old logic break new? Another option is to version the message, and if you get

[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521559226 I understand your comment now, my comment was related to the code itself,not the feature as a whole: I see

[GitHub] [activemq-artemis] michaelandrepearce merged pull request #2798: NO-JIRA fix failing Travis build

michaelandrepearce merged pull request #2798: NO-JIRA fix failing Travis build URL: https://github.com/apache/activemq-artemis/pull/2798 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2798: NO-JIRA fix failing Travis build

michaelandrepearce commented on issue #2798: NO-JIRA fix failing Travis build URL: https://github.com/apache/activemq-artemis/pull/2798#issuecomment-521561991 Nice +1 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314189923 ## File path:

[GitHub] [activemq-artemis] jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521549275 Ok, I can move it there. I saw some java classes with quite extensive Javadoc, and I felt that explaining

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521560596 @franz1981 i assume you're going to have a think on this and re-work bits? e.g. no further comments

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers

michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-521531183 @franz1981 @wy96f @clebertsuconic as no further comments/feedback will merge this tomorrow.

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521557724 The feature of shared store colocated is not totally broken, but the shared store colocation using group

[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027 Yes, sure and will provide proper yes and coverage too as it deserves :) Thanks for the suggestions

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521562542 @jbertram this was a quick scrap togeather of what i was trying to describe in review comment on your

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521562542 @jbertram this was a quick scrap togeather of what i was trying to describe in review comment on your pr. Im

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE

michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314188891 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE

michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314188595 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314212795 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443 The version proposal is probably the best solution indeed: the reason why the old logic breaks the new one

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443 The version proposal is probably the best solution indeed: the reason why the old logic breaks the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521533815 Its important broker can be rolling upgraded, e.g. old broker instance can talk with new without

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397 Why not have a setting that makes it behave as old version, then once all servers uograded

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

franz1981 commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314213953 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce edited a comment on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891 Well it can't be totally broken, theres users out there using it (mostly because they are

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup

michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891 Well it can't be totally broken, theres users out there using it (mostly because they are forming

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

michaelandrepearce edited a comment on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521563091 @jbertram re: > BTW, the issue I saw wasn't a leak, per se. It was simply unwanted

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

clebertsuconic commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314363282 ## File path:

[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521689923 I think what you wrote looks good. I wouldn't go as far as saying that using a `ThreadLocal` is a *good* idea, but

[GitHub] [activemq-artemis] asfgit merged pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

asfgit merged pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache

jbertram commented on issue #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796#issuecomment-521683921 It's *possible* that `tempQueues` could grow like `knownDestinations`. However, entries are only added to `tempQueues`

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

jbertram commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314367295 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

clebertsuconic commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314370749 ## File path:

[GitHub] [activemq-artemis] jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

jdanekrh commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521680441 (Does it look reasonable so far, what I wrote? Especially that using ThreadLocal is a good idea?)

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

clebertsuconic opened a new pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799 This is an automated message from the Apache

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2798: NO-JIRA fix failing Travis build

clebertsuconic commented on issue #2798: NO-JIRA fix failing Travis build URL: https://github.com/apache/activemq-artemis/pull/2798#issuecomment-521799929 For that reason I only use the scripts. This is an automated message

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2798: NO-JIRA fix failing Travis build

clebertsuconic commented on issue #2798: NO-JIRA fix failing Travis build URL: https://github.com/apache/activemq-artemis/pull/2798#issuecomment-521799868 @michaelandrepearce did you use the merge button on github? Be careful with merge commits, they are the worst.

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314566368 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314566358 ## File path:

[GitHub] [activemq-artemis] wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers

wy96f commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-521883667 @michaelandrepearce Can you wait a moment? When the browse cursor iterators(like the one created by

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

michaelandrepearce commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314583108 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE

wy96f commented on a change in pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314557230 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314581735 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers

michaelandrepearce commented on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-521882489 @wy96f can you squash commits so we can merge?