[GitHub] [activemq-artemis] MrEasy commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers

2019-09-12 Thread GitBox
MrEasy commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r323786778 ## File path: pom.xml ## @@ -90,6 +90,7 @@ 3.6.13.Final

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on a change in pull request #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
cjwmorgan-sol commented on a change in pull request #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323753116 ## File path: src/NMS.AMQP/Transport/TransportContext.cs ## @@ -56,7 +56,6 @@ static TransportContext()

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972823 no worries This is an automated message from the Apache

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323929755 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530996473 The new check for serialized dotnet content type should never be true while the annotation is set to reflect a JMS

[GitHub] [activemq-nms-amqp] Havret commented on issue #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
Havret commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530996289 Added. This is an automated message from the Apache Git Service. To

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`.

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was to key on the content type and if java serialized,

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was when msg type =obj then also key on the

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970167 Yes and this is how I've implemented it. Still I am not particularly happy with it. :(

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488 thus if no content type (assumed AmqpTypedObject) then return obj, if content type is set, then you only

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062 what you do is: if (properties.hasProperty(content type) ) { if (property.getProperty(content

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684 very poor but quick pseudo code (sorry)

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type` object type and do not have neither `application/x-java-serialized-object` nor

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and do not have neither `application/x-java-serialized-object`

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323926285 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@ -55,16 +55,19 @@

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@ -55,16 +55,19 @@

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927309 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323927693 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@ -55,16 +55,19 @@

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618 so frame tracing should be at TRACE level, it should be expected than you run with this off, and you'd enable change your apps logging level to

[GitHub] [activemq-nms-amqp] Havret commented on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
Havret commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log to this scenario:

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log this scenario:

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971944 Because they have `x-opt-jms-msg-type=object` type and have neither `application/x-java-serialized-object` nor

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bringing back the initial solution.

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-531002896 @Havret i dont see any update on the readme did you commit it?

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531003774 @gemmellr why cant .net have its own content type? theres no restriction on content type can be set to.

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#discussion_r323945589 ## File path: README.md ## @@ -1,4 +1,7 @@ # Apache-NMS-AMQP + +[![Build

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages, the condition ``` case

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007429 So as we are not setting `x-opt-jms-msg-type` at all for .net serializable messages the condition ``` case

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007181 as i said to support NMSObjectMessage (aka .net type) we can simply check content type before bothering with

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread

2019-09-12 Thread GitBox
michaelandrepearce merged pull request #30: AMQNET-611: Apache.NMS.IllegalStateException is throw on transport thread URL: https://github.com/apache/activemq-nms-amqp/pull/30 This is an automated message from the Apache Git

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969057 I've pushed the changes that @gemmellr suggested. It should work now. But personally I think this is a bit odd

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969057 I've pushed the changes that @gemmellr suggested. It should work now. But I personally I think this is a bit odd and

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type.

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type. Thus then you

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971002 Unfortunately I cannot, because it would exclud AmqpTypedObjects which don't have .net content type.

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971166 why would it exclude those? This is an

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978953 You tell me. Does it look better to you? 0f0c557 This

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978350 Made sense? This is an automated message

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323925428 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928708 ## File path: test/Apache-NMS-AMQP-Test/Provider/Amqp/AmqpCodecTest.cs ##

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928933 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, e.g. have we added a badge to the readme for master build?

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, e.g. have we added a badge to the readme?

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemmellr

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531004899 I believe we can have our own content type, but we cannot use it alongside with `x-opt-jms-msg-type`. @gemme

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928453 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@ -55,16 +55,19 @@

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323928092 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530989618 so frame tracing should be at TRACE level, it should be expected than you run with this off, and you'd enable change your apps logging

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#issuecomment-530990560 Do we have link to the CI build, have we added a badge to the readme?

[GitHub] [activemq-nms-amqp] Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
Havret commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531001279 So it seems we are bring back the initial solution.

[GitHub] [activemq-nms-amqp] Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration

2019-09-12 Thread GitBox
Havret commented on a change in pull request #27: NO-JIRA: Configure continuous integration URL: https://github.com/apache/activemq-nms-amqp/pull/27#discussion_r323945589 ## File path: README.md ## @@ -1,4 +1,7 @@ # Apache-NMS-AMQP + +[![Build

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on a change in pull request #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323945364 ## File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs ## @@

[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005976 If the JMS Message type annotation is set, to say it is a JMS ObjectMessage compatible message, then thecontent type

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, if content type =

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce edited a comment on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, (before any of the switching) if

[GitHub] [activemq-nms-amqp] gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
gemmellr commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531008470 Bingo. This is an automated message from the Apache