[GitHub] [activemq-artemis] assens opened a new pull request #2837: fix for #ARTEMIS-2476

2019-09-16 Thread GitBox
assens opened a new pull request #2837: fix for #ARTEMIS-2476 URL: https://github.com/apache/activemq-artemis/pull/2837 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [activemq-artemis] wy96f commented on issue #2836: [ARTEMIS-2487] Updated to org.jctools:jctools-core:2.1.2

2019-09-16 Thread GitBox
wy96f commented on issue #2836: [ARTEMIS-2487] Updated to org.jctools:jctools-core:2.1.2 URL: https://github.com/apache/activemq-artemis/pull/2836#issuecomment-531677394 Good job! This is an automated message from the Apache

[GitHub] [activemq-artemis] wy96f commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

2019-09-16 Thread GitBox
wy96f commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-531688339 As you said, size of tiny/small/medium caches is quite small. Even if not freed in time, the impact is very little comp

[GitHub] [activemq-artemis] franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

2019-09-16 Thread GitBox
franz1981 commented on issue #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-531690229 @wy96f fair enough :) Still waiting some results from the integration tests on the CI and will be ready to be me

[GitHub] [activemq-artemis] lulf commented on issue #2834: ARTEMIS-2488: Handle the case where source address is null

2019-09-16 Thread GitBox
lulf commented on issue #2834: ARTEMIS-2488: Handle the case where source address is null URL: https://github.com/apache/activemq-artemis/pull/2834#issuecomment-531700383 @clebertsuconic @michaelandrepearce Updated with your suggestions.

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.

2019-09-16 Thread GitBox
michaelandrepearce commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#issuecomment-531705224 Whilst im not an mqtt person so cannot review code from a correctness pov,

[GitHub] [activemq-artemis] bs-logisoft opened a new pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions

2019-09-16 Thread GitBox
bs-logisoft opened a new pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions URL: https://github.com/apache/activemq-artemis/pull/2838 This is an automated message from the Apache Git Service. To respond t

[GitHub] [activemq-artemis] assens commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.

2019-09-16 Thread GitBox
assens commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#issuecomment-531716019 > Whilst im not an mqtt person so cannot review code from a correctness pov, will need

[GitHub] [activemq-artemis-native] MrEasy commented on issue #4: ARTEMIS-2426 Added Bundle-Native code header

2019-09-16 Thread GitBox
MrEasy commented on issue #4: ARTEMIS-2426 Added Bundle-Native code header URL: https://github.com/apache/activemq-artemis-native/pull/4#issuecomment-531727160 @clebertsuconic Could you consider this for inclusion in next Artemis release? --

[GitHub] [activemq-artemis] MrEasy opened a new pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message

2019-09-16 Thread GitBox
MrEasy opened a new pull request #2839: [ARTEMIS-2490] Prevent NumberFormatExc when reading large message URL: https://github.com/apache/activemq-artemis/pull/2839 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

2019-09-16 Thread GitBox
wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r324656398 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

2019-09-16 Thread GitBox
wy96f commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r324656398 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/

[GitHub] [activemq-artemis] asfgit closed pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions

2019-09-16 Thread GitBox
asfgit closed pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions URL: https://github.com/apache/activemq-artemis/pull/2838 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [activemq-artemis] asfgit merged pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions

2019-09-16 Thread GitBox
asfgit merged pull request #2838: NO-JIRA Add 2.10.0 entry with upgrade instructions URL: https://github.com/apache/activemq-artemis/pull/2838 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [activemq-artemis] assens commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.

2019-09-16 Thread GitBox
assens commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#issuecomment-531769456 I've provided the MQTTRetainMessageManagerTest which asserts that retained messages re

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers

2019-09-16 Thread GitBox
franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large messages could leak native ByteBuffers URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r324693072 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/i

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.

2019-09-16 Thread GitBox
clebertsuconic commented on a change in pull request #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#discussion_r324710564 ## File path: artemis-protocols/artemis-mqtt-protoco

[GitHub] [activemq-artemis] gaohoward opened a new pull request #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs

2019-09-16 Thread GitBox
gaohoward opened a new pull request #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs URL: https://github.com/apache/activemq-artemis/pull/2840 When an openwire client closes the session, the broker doesn't clean up its server consumer references even though the co

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2841: Simplifying Scale down remove queue logic

2019-09-16 Thread GitBox
clebertsuconic opened a new pull request #2841: Simplifying Scale down remove queue logic URL: https://github.com/apache/activemq-artemis/pull/2841 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs

2019-09-16 Thread GitBox
clebertsuconic commented on issue #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs URL: https://github.com/apache/activemq-artemis/pull/2840#issuecomment-532043791 I'm running whole testsuite before we can merge this.

[GitHub] [activemq-artemis] gaohoward commented on issue #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs

2019-09-16 Thread GitBox
gaohoward commented on issue #2840: ARTEMIS-2493 OpenWire session close doesn't cleanup consumer refs URL: https://github.com/apache/activemq-artemis/pull/2840#issuecomment-532044831 thanks @clebertsuconic This is an automat

[GitHub] [activemq-artemis] assens commented on a change in pull request #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.

2019-09-16 Thread GitBox
assens commented on a change in pull request #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#discussion_r324993925 ## File path: artemis-protocols/artemis-mqtt-protocol/src/te