[GitHub] [activemq-nms-amqp] Havret commented on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
Havret commented on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533868994 I ignored failing test. It should be restored after https://github.com/vromero/activemq-artemis-docker/pull/124 is merged and we can use

[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533874887 @ehsavoie @clebertsuconic This version is not failing anymore the wildfly tests on

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326896884 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326897522 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533881207 @wy96f I remember you've provided some numbers for ARTEMIS-2336 using one of yours load

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533881207 @wy96f I remember you've provided some numbers for ARTEMIS-2336 using one of your

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326896991 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326903252 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
clebertsuconic commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533884923 lets wait the release I'm doing on monday before we can start considering this? We

[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533885763 @clebertsuconic yes, agree and I would like to run a soak test + wait @wy96f results as well

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533885763 @clebertsuconic yes, agree and I would like to run a soak test + wait @wy96f results

[GitHub] [activemq-nms-amqp] Havret commented on issue #28: NO-JIRA: Extend logging

2019-09-22 Thread GitBox
Havret commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533896432 @cjwmorgan-sol Thank you very much for your feedback. I've added message tracing support to our backlog https://issues.apache.org/jira/browse/AMQNET-613

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-22 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533896432 @cjwmorgan-sol Thank you very much for your feedback.  I've added message tracing support to our backlog

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-533874887 @ehsavoie @clebertsuconic FYI this version is not failing anymore the wildfly tests

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
clebertsuconic commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326903004 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326903252 ## File path:

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #35: Pingpong benchmark

2019-09-22 Thread GitBox
Havret opened a new pull request #35: Pingpong benchmark URL: https://github.com/apache/activemq-nms-amqp/pull/35 This is a simple pingpong benchmark that I am using to check if changes I'm making have any impact on performance.

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931 @wy96f @clebertsuconic Just for completeness that's what would change: -

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

2019-09-22 Thread GitBox
franz1981 opened a new pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845 I've opened this PR for discussion: I would like to re-introduce ARTEMIS-2336, but I've allowed wildfly or

[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #33: NO-JIRA: Update docs

2019-09-22 Thread GitBox
michaelandrepearce merged pull request #33: NO-JIRA: Update docs URL: https://github.com/apache/activemq-nms-amqp/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #33: NO-JIRA: Update docs

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #33: NO-JIRA: Update docs URL: https://github.com/apache/activemq-nms-amqp/pull/33#issuecomment-533917913 Ill merge this but anything more than a few lines change does typically need a jira

[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
michaelandrepearce edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533917673 @havret we should use the apache artemis docker build. Not an external one. If features or parts are missing they

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
Havret edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533919613 @michaelandrepearce Is it available on docker hub? This is an

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #28: NO-JIRA: Extend logging

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533918205 Jira item needed. Also squash commits pls This is an automated message from

[GitHub] [activemq-artemis] gaohoward opened a new pull request #2846: ARTEMIS-2500 CoreMessage doesn't make a ful copy of its props

2019-09-22 Thread GitBox
gaohoward opened a new pull request #2846: ARTEMIS-2500 CoreMessage doesn't make a ful copy of its props URL: https://github.com/apache/activemq-artemis/pull/2846 When CoreMessage is doing copyHeadersAndProperties() it doesn't make a full copy of its properties (a TypedProperties

[GitHub] [activemq-nms-amqp] Havret opened a new pull request #36: [WIP] Transaction Integration Tests

2019-09-22 Thread GitBox
Havret opened a new pull request #36: [WIP] Transaction Integration Tests URL: https://github.com/apache/activemq-nms-amqp/pull/36 As we have testing framework finally available (new TestAmqpPeer implementation), I started adding missing integration tests for transactions.

[GitHub] [activemq-nms-amqp] Havret commented on issue #28: AMQNET-614: Extend logging

2019-09-22 Thread GitBox
Havret commented on issue #28: AMQNET-614: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533964508 Done. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533918027 https://github.com/apache/activemq-artemis/tree/master/artemis-docker

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533963429 No but you can build on fly or work with artemis for next release to get it so

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533906809 I'm going to "tune" the optimization while reading/writing RandonAccessFile in chunks of

[GitHub] [activemq-artemis] franz1981 commented on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers

2019-09-22 Thread GitBox
franz1981 commented on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533906809 I'm going to "tune" the optimization while reading/writing RandonAccessFile in chunks of 8192,

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
michaelandrepearce commented on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533917673 @havret we should use the apache artemis docker build. Not an external one

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers

2019-09-22 Thread GitBox
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533906809 I'm going to "tune" differently the optimization while reading/writing RandonAccessFile in

[GitHub] [activemq-nms-amqp] Havret commented on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
Havret commented on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533919613 It it available on docker hub? This is an automated message from the

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis

2019-09-22 Thread GitBox
Havret edited a comment on issue #34: NO-JIRA: Enable interop tests for Travis URL: https://github.com/apache/activemq-nms-amqp/pull/34#issuecomment-533919613 @michaelandrepearce It it available on docker hub? This is an