[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
wy96f commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#discussion_r06857 ## File path:

[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
gaohoward commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#discussion_r11392 ## File path:

[GitHub] [activemq-artemis] wy96f commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages

2019-10-09 Thread GitBox
wy96f commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages URL: https://github.com/apache/activemq-artemis/pull/2855#issuecomment-539882836 > @wy96f what about not use the page Executor for the delete? > > The page executor was meant for

[GitHub] [activemq-artemis] gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#issuecomment-539996782 pls hold this, it's getting test failures in jenkins.

[GitHub] [activemq-website] ullgren opened a new pull request #16: Specify language in codeblocks so rouge does have to guess.

2019-10-09 Thread GitBox
ullgren opened a new pull request #16: Specify language in codeblocks so rouge does have to guess. URL: https://github.com/apache/activemq-website/pull/16 When building with the official container `jekyll/jekyll:4` the build results in the error ```

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
wy96f commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#discussion_r333012845 ## File path:

[GitHub] [activemq-artemis] brusdev opened a new pull request #2860: NO-JIRA Fixing shared-storage-static-cluster parent

2019-10-09 Thread GitBox
brusdev opened a new pull request #2860: NO-JIRA Fixing shared-storage-static-cluster parent URL: https://github.com/apache/activemq-artemis/pull/2860 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq-artemis] gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#issuecomment-540072662 I'll run jenkins again. This is an

[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match

2019-10-09 Thread GitBox
brusdev commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r333078297 ## File path:

[GitHub] [activemq-artemis] gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
gaohoward commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#issuecomment-540063855 @clebertsuconic Yes I'm fixing it. Also same issue with hornetq. I'll fix that too.

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
clebertsuconic commented on issue #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#issuecomment-540050231 There are files leaking in your test.

[GitHub] [activemq-artemis] asfgit closed pull request #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages

2019-10-09 Thread GitBox
asfgit closed pull request #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages URL: https://github.com/apache/activemq-artemis/pull/2855 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] asfgit closed pull request #2860: NO-JIRA Fixing shared-storage-static-cluster parent

2019-10-09 Thread GitBox
asfgit closed pull request #2860: NO-JIRA Fixing shared-storage-static-cluster parent URL: https://github.com/apache/activemq-artemis/pull/2860 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads

2019-10-09 Thread GitBox
gaohoward commented on a change in pull request #2859: ARTEMIS-2513 Large message's copy may be interfered by other threads URL: https://github.com/apache/activemq-artemis/pull/2859#discussion_r333093509 ## File path:

[GitHub] [activemq-website] clebertsuconic merged pull request #16: Specify language in codeblocks so rouge does have to guess.

2019-10-09 Thread GitBox
clebertsuconic merged pull request #16: Specify language in codeblocks so rouge does have to guess. URL: https://github.com/apache/activemq-website/pull/16 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses

2019-10-09 Thread GitBox
jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-540147310 @michaelandrepearce, try it now. I eliminated the copy when populating the new queue with the old messages.