[GitHub] [activemq-artemis] clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages

2019-10-07 Thread GitBox
clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages URL: https://github.com/apache/activemq-artemis/pull/2855#issuecomment-539163812 hold a future waiting for the result has the same result as using the main thread anyway, right?

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages

2019-10-07 Thread GitBox
clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages URL: https://github.com/apache/activemq-artemis/pull/2855#issuecomment-539034933 I don't understand why we are using an executor now for removing? why not just remove the locks a

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages

2019-10-07 Thread GitBox
clebertsuconic commented on issue #2855: ARTEMIS-2508 Crititical analyser trigger shutdown if removeAllMessages URL: https://github.com/apache/activemq-artemis/pull/2855#issuecomment-539034551 @wy96f what about not use the page Executor for the delete? The page executor was meant for