[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314212795
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ColocatedHAManager.java
##
@@ -163,6 +174,23 @@ private synchronized boolean
activateSharedStoreBackup(String journalDirectory,
return true;
}
+ private TopologyMember validateBackupGroupName(SimpleString nodeID) {
+ // Older versions of artemis don't send the nodeID in
BackupRequestMessage:
+ // in this case we cannot trust the request, making the requesting server
Review comment:
Why can't we, we know we had old servers and setups working fine, as such
why be so strict, simply fail back (or even tter have a v1 and v2 version of
the message, that way if all v2 cluster you can be fully strict, else in a
v1/v2 mix you can be less strict
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
##
@@ -34,12 +34,14 @@ public BackupRequestMessage() {
}
public BackupRequestMessage(int backupSize,
+ SimpleString nodeID,
String journalDirectory,
String bindingsDirectory,
String largeMessagesDirectory,
String pagingDirectory) {
super(BACKUP_REQUEST);
this.backupSize = backupSize;
+ this.nodeID = nodeID;
Review comment:
Please make a v2 version, this would be a breaking change, for anyone with
existing clusters
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
##
@@ -34,12 +34,14 @@ public BackupRequestMessage() {
}
public BackupRequestMessage(int backupSize,
+ SimpleString nodeID,
String journalDirectory,
String bindingsDirectory,
String largeMessagesDirectory,
String pagingDirectory) {
super(BACKUP_REQUEST);
this.backupSize = backupSize;
+ this.nodeID = nodeID;
Review comment:
Please make a v2 version, this would be a breaking change, for anyone with
existing clusters
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
