[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-524365392 @clebertsuconic its not ready for merge anhow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521560596 @franz1981 i assume you're going to have a think on this and re-work bits? e.g. no further comments needed for now right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891 Well it can't be totally broken, theres users out there using it (mostly because they are forming single groups or ensuring clusters are rign fenced), yes theres a bug thats not ideal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521554151 Also why would having old logic break new? Another option is to version the message, and if you get v1 do old logic, if you get new v2 message do new. Then no need even for a flag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397 Why not have a setting that makes it behave as old version, then once all servers uograded the setting can change to strict and then simply another round or rolling bounces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup
michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521533815 Its important broker can be rolling upgraded, e.g. old broker instance can talk with new without issue so zero downtime upgrades can occur. I think the issue you called out must be addressed before this can merge, if it breaks that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
