[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-14 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521142429 Just to be clear this is not a negative vote but more im trying to invoke a discussion as there wil

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-13 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then embeds i

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-13 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521005728 Rather than this, would it not be better address those then to avoid the conversion. I know clebert

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

2019-08-13 Thread GitBox
michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-520926445 Im a bit lost why this is needed. I thought if amqp in and amqp out we did no conversion -