[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

2019-09-18 Thread GitBox
michaelandrepearce commented on issue #2842: ARTEMIS-2495 
ReplicationSyncFileMessage last packet should be encoded
URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532759528
 
 
   Good to see we are reaching out to @wy96f, It be great if we have a test to 
reproduce obviously our existing tests didnt catch, but also to avoid such in 
future catching us. I guess wildfly caught it via their testing


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2842: ARTEMIS-2495 ReplicationSyncFileMessage last packet should be encoded

2019-09-18 Thread GitBox
michaelandrepearce commented on issue #2842: ARTEMIS-2495 
ReplicationSyncFileMessage last packet should be encoded
URL: https://github.com/apache/activemq-artemis/pull/2842#issuecomment-532746924
 
 
   @franz1981 i know you closed it, but a test case to reproduce and confirm 
any fix would be needed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services