[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

2019-09-11 Thread GitBox
michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530462233 Ok. Just remember there will always be bugs. We do want to cut a release at somepoint. Once we have a release done

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

2019-09-11 Thread GitBox
michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530456020 Cool was this the only blocker for CI? Or more issues you want to fix. Just trying to gauge when to cut release

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

2019-09-11 Thread GitBox
michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530446482 @HavretGC did we resolve the issue robbie raised in dev mail list re object msg -

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation

2019-09-09 Thread GitBox
michaelandrepearce commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-529483580 LGTM, will give it another 24hrs before merging so @cjwmorgan-sol gets a chance to look