[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-13 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531356195 @gemmellr i think were all agreed now, but could you just give a +1 that your happy with the change before i

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007181 as i said to support NMSObjectMessage (aka .net type) we can simply check content type before bothering with

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, if content type =

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531003774 @gemmellr why cant .net have its own content type? theres no restriction on content type can be set to.

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530978350 Made sense? This is an automated message

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488 thus if no content type (assumed AmqpTypedObject) then return obj, if content type is set, then you only

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684 very poor but quick pseudo code (sorry)

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062 what you do is: if (properties.hasProperty(content type) ) { if (property.getProperty(content

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530971166 why would it exclude those? This is an

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type.

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set

2019-09-12 Thread GitBox
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was to key on the content type and if java serialized,