[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531356195 @gemmellr i think were all agreed now, but could you just give a +1 that your happy with the change before i merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531007181 as i said to support NMSObjectMessage (aka .net type) we can simply check content type before bothering with msg types checks. And then we can remove the check in msg type cases , and simply make it that if msgtype is jms-obj and content type is set we return byte msg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-531005790 right, so what we can do then, is first check content type, if content type = application/x-net-serialized-object then its object message, else then we check the msg type. and then when msg-type = jms obj we only return object if no content type (aka the Amqp varient) else we return byte msg for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972488 thus if no content type (assumed AmqpTypedObject) then return obj, if content type is set, then you only return obj if it was of .net type. returning byte for all other This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972684 very poor but quick pseudo code (sorry) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't
have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530972062
what you do is:
if (properties.hasProperty(content type) ) {
if (property.getProperty(content type) == ".net") {
return obj msg
} else {
return byte msg
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530970373 Well you can invert the logic, you return object only if also the .net content type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set
michaelandrepearce commented on issue #31: AMQNET-612: ObjectMessage shouldn't have jms-msg-type set URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530969794 x-opt-jms-msg-type should be honoured, his suggestion was to key on the content type and if java serialized, you return a bytemessage in .net This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
