Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-11 Thread via GitHub
thezbyg closed pull request #1198: AMQ-9472 Add test for wildcard producer breaking authorization URL: https://github.com/apache/activemq/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-10 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2047943899 Bug fix PR opened at https://github.com/apache/activemq/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-10 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2047728387 @thezbyg thank you for the detailed report and staying with it while we work through your scenario to find the bug. A tricky edge case! -- This is an automated message from the

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-10 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2047625950 @thezbyg - That is interesting, I do not see that happen when testing some of the Java STOMP tests we have but it could depend on the client. Regardless, that processConsumerControl()

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-09 Thread via GitHub
thezbyg commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2046523027 > So this is just how the broker currently works to handle wildcard subscriptions, since you are publishing to a wildcard topic then any subscription that matches needs to also

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-09 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2045239359 Looking at the use case, I don't see a scenario where using a wildcard _topic_ makes the most sense. Topics already of subscriptions, so instead of creating additional _destinations_

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043874595 I think that the behavior should match the destination policy. 1. Wildcard 2. Fully qualified name (authoritative) I agree, it should be a new flag since we would not

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043856614 The only other thing i can think of is we could technically change the behavior of the authorization broker plugin because you could make an argument that any matching wildcard should

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043790765 In terms of working around this, the options are pretty much: 1. If you are going to create topics then you need to make sure you have proper ACLs set up for those topics

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
cshannon commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2043752900 This is not really a bug to me, it's a side effect of how wild card subscriptions work in the broker. The issue here is not with the authorization plugin or logic but with how

Re: [PR] AMQ-9472 Add test for wildcard producer breaking authorization [activemq]

2024-04-08 Thread via GitHub
mattrpav commented on PR #1198: URL: https://github.com/apache/activemq/pull/1198#issuecomment-2042861290 I was able to reproduce using a stock Apache v6.1.1 build. This appears to be a 'does not permit' issue and not a 'does not restrict' issue. -- This is an automated message from the