Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic merged PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567752253 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567726290 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567720798 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567719937 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567717178 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567717178 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567714521 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567713737 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567709683 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567706638 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567705435 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567656042 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
tabish121 commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567621714 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567586092 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567585396 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
gemmellr commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567477400 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@ protected

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567358070 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
clebertsuconic commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567358918 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
gemmellr commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567054654 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@ protected

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
gemmellr commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1566979146 ## tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/MirroredVersionTest.java: ## @@ -106,7 +110,6 @@ public void

Re: [PR] ARTEMIS-4725 AMQP Delivery reencoding before getDeliverBuffer [activemq-artemis]

2024-04-16 Thread via GitHub
erwindon commented on code in PR #4888: URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567052835 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java: ## @@ -825,8 +826,14 @@ protected