[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447465847 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2264,6 +2255,8 @@

[GitHub] [hive] kasakrisz merged pull request #1188: HIVE-19549: Enable TestAcidOnTez#testCtasTezUnion

2020-06-30 Thread GitBox
kasakrisz merged pull request #1188: URL: https://github.com/apache/hive/pull/1188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk commented on pull request #1187: HIVE-23772. Reallocate calcite-core to prevent NoSuchFiledError.

2020-06-30 Thread GitBox
kgyrtkirk commented on pull request #1187: URL: https://github.com/apache/hive/pull/1187#issuecomment-651580913 iirc the point where the switch to the "non-shaded calcite-core" happens is when the jdbc driver is loaded

[GitHub] [hive] ayushtkn commented on pull request #1187: HIVE-23772. Reallocate calcite-core to prevent NoSuchFiledError.

2020-06-30 Thread GitBox
ayushtkn commented on pull request #1187: URL: https://github.com/apache/hive/pull/1187#issuecomment-651592714 The assertion error is due to the fact both shaded and non shaded jars are there in classpath. ``` Caused by: java.lang.AssertionError at

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447468545 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] ayushtkn edited a comment on pull request #1187: HIVE-23772. Reallocate calcite-core to prevent NoSuchFiledError.

2020-06-30 Thread GitBox
ayushtkn edited a comment on pull request #1187: URL: https://github.com/apache/hive/pull/1187#issuecomment-651592714 The assertion error is due to the fact both shaded and non shaded jars are there in classpath. ``` Caused by: java.lang.AssertionError at

[GitHub] [hive] ayushtkn edited a comment on pull request #1187: HIVE-23772. Reallocate calcite-core to prevent NoSuchFiledError.

2020-06-30 Thread GitBox
ayushtkn edited a comment on pull request #1187: URL: https://github.com/apache/hive/pull/1187#issuecomment-651592714 The assertion error is due to the fact both shaded and non shaded jars are there in classpath. ``` Caused by: java.lang.AssertionError at

[GitHub] [hive] klcopp merged pull request #1085: Hive 22255 : Hive don't trigger Major Compaction automatically if table contains only base files

2020-06-30 Thread GitBox
klcopp merged pull request #1085: URL: https://github.com/apache/hive/pull/1085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447462171 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447033768 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java ## @@ -429,6 +451,75 @@ void

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447477522 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447483691 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] John1Tang commented on pull request #967: HIVE-23074: add "IF NOT EXISTS" for create & "IF EXISTS" for drop to …

2020-06-30 Thread GitBox
John1Tang commented on pull request #967: URL: https://github.com/apache/hive/pull/967#issuecomment-651657855 my pull request only changed the postgres schematool, this test failed with hive jdbc storage handler... This is

[GitHub] [hive] dengzhhu653 commented on pull request #1191: HIVE-23779: BasicStatsTask Info is not getting printed in beeline console

2020-06-30 Thread GitBox
dengzhhu653 commented on pull request #1191: URL: https://github.com/apache/hive/pull/1191#issuecomment-651699390 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447480415 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447478910 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447484200 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2032,28 +2077,61 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447484596 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2032,28 +2077,61 @@ public

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447547869 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -900,13 +898,6 @@ private

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447476089 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java ## @@ -313,6 +313,41 @@ private

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447550132 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -851,8 +851,6 @@ private

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447509066 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2032,28 +2077,61 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447480415 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447472989 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -383,6 +475,7 @@ public Void

[GitHub] [hive] deniskuzZ commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

2020-06-30 Thread GitBox
deniskuzZ commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r447482052 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447984350 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2264,6 +2255,8 @@

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447984106 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -900,13 +898,6 @@ private

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447999634 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -1566,160 +1643,6 @@

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447985240 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2264,6 +2255,8 @@ private

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447985439 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -136,17 +129,19 @@

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447985504 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -900,13 +898,6 @@ private

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447987117 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -1566,160 +1643,6 @@

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447983144 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -900,13 +898,6 @@ private

[GitHub] [hive] zabetak commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
zabetak commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r447999118 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -136,17 +129,19 @@

[GitHub] [hive] github-actions[bot] closed pull request #987: HIVE-23235 Fix checkpointing for ORC Tables

2020-06-30 Thread GitBox
github-actions[bot] closed pull request #987: URL: https://github.com/apache/hive/pull/987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] github-actions[bot] closed pull request #977: HIVE-23040 : Checkpointing for repl dump incremental phase

2020-06-30 Thread GitBox
github-actions[bot] closed pull request #977: URL: https://github.com/apache/hive/pull/977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r448023085 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -136,17 +129,19 @@

[GitHub] [hive] kishendas commented on a change in pull request #1186: Hive 23768: Metastore's update service wrongly strips partition column stats from the cache

2020-06-30 Thread GitBox
kishendas commented on a change in pull request #1186: URL: https://github.com/apache/hive/pull/1186#discussion_r448023056 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java ## @@ -1566,160 +1643,6 @@

[GitHub] [hive] pkumarsinha commented on a change in pull request #1193: HIVE-23784 : Fix Replication Metrics Sink to DB

2020-06-30 Thread GitBox
pkumarsinha commented on a change in pull request #1193: URL: https://github.com/apache/hive/pull/1193#discussion_r448113867 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricSink.java ## @@ -64,8 +64,10 @@ public static MetricSink getInstance() {