[GitHub] [hive] deniskuzZ merged pull request #1371: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

2020-08-07 Thread GitBox
deniskuzZ merged pull request #1371: URL: https://github.com/apache/hive/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] deniskuzZ commented on pull request #1371: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

2020-08-07 Thread GitBox
deniskuzZ commented on pull request #1371: URL: https://github.com/apache/hive/pull/1371#issuecomment-670383666 @pvargacl could you please review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] pvargacl commented on pull request #1371: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

2020-08-07 Thread GitBox
pvargacl commented on pull request #1371: URL: https://github.com/apache/hive/pull/1371#issuecomment-670383718 LGTM. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] ArkoSharma opened a new pull request #1376: Hive 24014 : Need to delete DumpDirectoryCleanerTask

2020-08-07 Thread GitBox
ArkoSharma opened a new pull request #1376: URL: https://github.com/apache/hive/pull/1376 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

[GitHub] [hive] ArkoSharma closed pull request #1376: Hive 24014 : Need to delete DumpDirectoryCleanerTask

2020-08-07 Thread GitBox
ArkoSharma closed pull request #1376: URL: https://github.com/apache/hive/pull/1376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467005926 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467058365 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467010382 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ## @@ -5685,6 +5706,67 @@ private

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467007215 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467012433 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ## @@ -5685,6 +5706,67 @@ private

[GitHub] [hive] ArkoSharma closed pull request #1377: HIVE-24014

2020-08-07 Thread GitBox
ArkoSharma closed pull request #1377: URL: https://github.com/apache/hive/pull/1377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467009533 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ## @@ -240,6 +247,20 @@ private

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467008407 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -2454,10 +2467,14 @@ PartitionsResponse

[GitHub] [hive] ArkoSharma opened a new pull request #1377: HIVE-24014

2020-08-07 Thread GitBox
ArkoSharma opened a new pull request #1377: URL: https://github.com/apache/hive/pull/1377 ([HIVE-24014: Need to delete DumpDirectoryCleanerTask](https://issues.apache.org/jira/browse/HIVE-24014)) This is an automated

[GitHub] [hive] klcopp closed pull request #1368: HIVE-24001: Don't cache MapWork in tez/ObjectCache during query-based compaction

2020-08-07 Thread GitBox
klcopp closed pull request #1368: URL: https://github.com/apache/hive/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] bmaidics commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

2020-08-07 Thread GitBox
bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r466993241 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{

[GitHub] [hive] saihemanth-cloudera opened a new pull request #1380: Show tables in database with owner policy

2020-08-07 Thread GitBox
saihemanth-cloudera opened a new pull request #1380: URL: https://github.com/apache/hive/pull/1380 ### What changes were proposed in this pull request? Owner of the tables in DB will be able to see the tables while issuing the command "Show tables in database" without the

[GitHub] [hive] risdenk commented on pull request #1342: HIVE-23958: HiveServer2 should support additional keystore/truststore types besides JKS

2020-08-07 Thread GitBox
risdenk commented on pull request #1342: URL: https://github.com/apache/hive/pull/1342#issuecomment-670584707 > The HttpServer has a Builder class that does not have support for setting the keystore type. Should we add a method to the builder to be able to build with a KS type and/or

[GitHub] [hive] ayushtkn commented on pull request #1321: HIVE-23935. Fetching primaryKey through beeline fails with NPE.

2020-08-07 Thread GitBox
ayushtkn commented on pull request #1321: URL: https://github.com/apache/hive/pull/1321#issuecomment-670603579 @kgyrtkirk @belugabehr can you help review!!! This is an automated message from the Apache Git Service. To

[GitHub] [hive] abstractdog opened a new pull request #1379: HIVE-23408: Hive on Tez : Kafka storage handler broken in secure envi…

2020-08-07 Thread GitBox
abstractdog opened a new pull request #1379: URL: https://github.com/apache/hive/pull/1379 …ronment Change-Id: I486e9169279765b8a695d27264b770c8db92128f ### What changes were proposed in this pull request? ### Why are the changes needed?

[GitHub] [hive] jcamachor merged pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

2020-08-07 Thread GitBox
jcamachor merged pull request #1357: URL: https://github.com/apache/hive/pull/1357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] vihangk1 commented on a change in pull request #1355: send tableId to get_partition APIs

2020-08-07 Thread GitBox
vihangk1 commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r467264742 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreClientApiArgumentsChecker.java ## @@ -0,0 +1,140 @@ +/* + * Licensed to the

[GitHub] [hive] mustafaiman opened a new pull request #1381: HIVE-24011: Flaky test AsyncResponseHandlerTest

2020-08-07 Thread GitBox
mustafaiman opened a new pull request #1381: URL: https://github.com/apache/hive/pull/1381 Timeout is too low. Also retry logic could cause "java.lang.IllegalArgumentException: timeout value is negative" Change-Id: I3b40dad06889e0e6582d61a8f031fbaba6d06cc3

[GitHub] [hive] vihangk1 merged pull request #1355: send tableId to get_partition APIs

2020-08-07 Thread GitBox
vihangk1 merged pull request #1355: URL: https://github.com/apache/hive/pull/1355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

2020-08-07 Thread GitBox
zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r467318625 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

2020-08-07 Thread GitBox
zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r467318270 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] jcamachor commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

2020-08-07 Thread GitBox
jcamachor commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r467343664 ## File path: ql/src/test/results/clientpositive/perf/tez/cbo_query16_anti_join.q.out ## @@ -0,0 +1,99 @@ +PREHOOK: query: explain cbo +select +

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

2020-08-07 Thread GitBox
zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r467319212 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] jcamachor merged pull request #1147: HIVE-23716: Support Anti Join in Hive

2020-08-07 Thread GitBox
jcamachor merged pull request #1147: URL: https://github.com/apache/hive/pull/1147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch

2020-08-07 Thread GitBox
sunchao commented on pull request #1365: URL: https://github.com/apache/hive/pull/1365#issuecomment-670807908 It seems the patch approach also doesn't work. ping @pvary @kgyrtkirk : do you know a way to trigger tests? thanks.