[GitHub] [hive] belugabehr closed pull request #2309: HIVE-25151: Remove Unused Interner from HiveMetastoreChecker

belugabehr closed pull request #2309: URL: https://github.com/apache/hive/pull/2309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] belugabehr commented on pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp

belugabehr commented on pull request #2002: URL: https://github.com/apache/hive/pull/2002#issuecomment-846606241 @miklosgergely :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-846585770 @kgyrtkirk Adding struct UniqueConstraintsRequest { 1: TableReference table; } Above change will not be compatible with older HMS client. Should I

[GitHub] [hive] ashish-kumar-sharma edited a comment on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

ashish-kumar-sharma edited a comment on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-846585770 @kgyrtkirk struct UniqueConstraintsRequest { 1: TableReference table; } Above change will not be compatible with older HMS client. Should I

[GitHub] [hive] belugabehr commented on pull request #2299: HIVE-25141: Review Error Level Logging in HMS Module

belugabehr commented on pull request #2299: URL: https://github.com/apache/hive/pull/2299#issuecomment-846605840 @miklosgergely I made a couple of changes to get tests to pass. Can you please take a quick look to validate the change? Thanks! -- This is an automated message from the

[GitHub] [hive] pgaref commented on pull request #2310: HIVE-25152: Remove Superfluous Logging Code

pgaref commented on pull request #2310: URL: https://github.com/apache/hive/pull/2310#issuecomment-846543650 > ... continued... > > That is to say: > > ```java > LOG.info("New Final Path: FS " + fsp.finalPaths[filesIdx]); > LOG.info("New Final Path: FS {}",

[GitHub] [hive] belugabehr commented on pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp

belugabehr commented on pull request #2002: URL: https://github.com/apache/hive/pull/2002#issuecomment-846656268 @pgaref If you are available for a quick review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hive] belugabehr merged pull request #2309: HIVE-25151: Remove Unused Interner from HiveMetastoreChecker

belugabehr merged pull request #2309: URL: https://github.com/apache/hive/pull/2309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] belugabehr merged pull request #2310: HIVE-25152: Remove Superfluous Logging Code

belugabehr merged pull request #2310: URL: https://github.com/apache/hive/pull/2310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] aasha commented on a change in pull request #2240: HIVE-25086: Create Ranger Deny Policy for replication db in all cases.

aasha commented on a change in pull request #2240: URL: https://github.com/apache/hive/pull/2240#discussion_r637674090 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java ## @@ -79,6 +74,7 @@ private static final String

[GitHub] [hive] ramesh0201 commented on a change in pull request #2286: HIVE-25117 Vector PTF ClassCastException with Decimal64

ramesh0201 commented on a change in pull request #2286: URL: https://github.com/apache/hive/pull/2286#discussion_r637668639 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFOperator.java ## @@ -250,13 +253,16 @@ protected VectorizedRowBatch

[GitHub] [hive] ramesh0201 commented on pull request #2286: HIVE-25117 Vector PTF ClassCastException with Decimal64

ramesh0201 commented on pull request #2286: URL: https://github.com/apache/hive/pull/2286#issuecomment-846728695 None of the vector PTF decimal operators have support for decimal64. Like we need to have corresponding decimal64 version for VectorPTFEvaluatorDecimalSum and similar classes.

[GitHub] [hive] ramesh0201 commented on a change in pull request #2286: HIVE-25117 Vector PTF ClassCastException with Decimal64

ramesh0201 commented on a change in pull request #2286: URL: https://github.com/apache/hive/pull/2286#discussion_r637686832 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java ## @@ -4962,9 +4969,8 @@ private static void

[GitHub] [hive] maheshk114 commented on a change in pull request #2266: HIVE-24663 : Batch process in ColStatsProcessor for partitions

maheshk114 commented on a change in pull request #2266: URL: https://github.com/apache/hive/pull/2266#discussion_r637691746 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java ## @@ -213,11 +214,14 @@ private void

[GitHub] [hive] hmangla98 commented on a change in pull request #2240: HIVE-25086: Create Ranger Deny Policy for replication db in all cases.

hmangla98 commented on a change in pull request #2240: URL: https://github.com/apache/hive/pull/2240#discussion_r637698171 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java ## @@ -420,8 +458,8 @@ boolean checkConnectionPlain(String

[GitHub] [hive] hmangla98 commented on a change in pull request #2240: HIVE-25086: Create Ranger Deny Policy for replication db in all cases.

hmangla98 commented on a change in pull request #2240: URL: https://github.com/apache/hive/pull/2240#discussion_r637697872 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java ## @@ -444,7 +482,7 @@ boolean checkConnectionPlain(String

[GitHub] [hive] maheshk114 commented on a change in pull request #2266: HIVE-24663 : Batch process in ColStatsProcessor for partitions

maheshk114 commented on a change in pull request #2266: URL: https://github.com/apache/hive/pull/2266#discussion_r637691386 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -5390,6 +5406,493 @@ public