[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

2021-07-10 Thread GitBox
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-877577635 @kishendas I have re run the jenkin got green build. Previous test failures was due to some flaky test cases. -- This is an automated message from the Apache Git

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

2021-05-23 Thread GitBox
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-846585770 @kgyrtkirk Adding struct UniqueConstraintsRequest { 1: TableReference table; } Above change will not be compatible with older HMS client. Should I

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

2021-05-05 Thread GitBox
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832540166 > Sending ValidWriteIdList and tableId as part of get_*_constraints HMS api to validate _whether_ data stored in HMS cached Store is stale or latest. ( You don't need

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

2021-05-05 Thread GitBox
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832539913 > Where are the tests to ensure that we are sending tableId and validWriteIdList to get constraint APIs ? This PR is more around changing signature of various

[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

2021-05-02 Thread GitBox
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-830789617 @kishendas Can you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the