[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-877577635 @kishendas I have re run the jenkin got green build. Previous test failures was due to some flaky test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
ashish-kumar-sharma commented on pull request #2211:
URL: https://github.com/apache/hive/pull/2211#issuecomment-846585770
@kgyrtkirk Adding
struct UniqueConstraintsRequest {
1: TableReference table;
}
Above change will not be compatible with older HMS client. Should I go
ahead and implement the above change as part of this PR or Should I create a
epic for cleaning up the deprecated api in metastore and move all api to
request model where we can have common models for multiple api?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832540166 > Sending ValidWriteIdList and tableId as part of get_*_constraints HMS api to validate _whether_ data stored in HMS cached Store is stale or latest. ( You don't need a ? at the end ) Latest and complete changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-832539913 > Where are the tests to ensure that we are sending tableId and validWriteIdList to get constraint APIs ? This PR is more around changing signature of various method and send table Id to metastore. I am waiting for https://github.com/apache/hive/pull/2128 to get merge. After that I can put a check of tableId and validwriteId in metastore and write all test cases around that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] ashish-kumar-sharma commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
ashish-kumar-sharma commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-830789617 @kishendas Can you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
