[GitHub] [hive] kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases
kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases URL: https://github.com/apache/hive/pull/819#discussion_r338550843 ## File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out ## @@ -4990,38 +4990,44 @@ Vertex dependency in root stage Reducer 2 <- Map 1 (SIMPLE_EDGE) Reducer 3 <- Reducer 2 (SIMPLE_EDGE) Reducer 4 <- Reducer 3 (SIMPLE_EDGE) +Reducer 5 <- Reducer 4 (SIMPLE_EDGE) Review comment: I agree; that was something I was not consideringI'll change the groupbyoperator acceptor - to recognize gby operators in "complete mode" - right now I think only those which can be accepted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases
kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases URL: https://github.com/apache/hive/pull/819#discussion_r337506882 ## File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out ## @@ -4990,38 +4990,44 @@ Vertex dependency in root stage Reducer 2 <- Map 1 (SIMPLE_EDGE) Reducer 3 <- Reducer 2 (SIMPLE_EDGE) Reducer 4 <- Reducer 3 (SIMPLE_EDGE) +Reducer 5 <- Reducer 4 (SIMPLE_EDGE) Review comment: I have to say that I was not expecting these changes - in this case the "grouping of key2/key3" is removed; so I'm not sure in the absencce of those columns from partitioning the GBY will work as expected I've attached a screenshot from the diff where the changes could be seen better:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases
kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases URL: https://github.com/apache/hive/pull/819#discussion_r337499849 ## File path: ql/src/test/results/clientpositive/autoColumnStats_7.q.out ## @@ -48,7 +48,7 @@ STAGE PLANS: Reduce Output Operator key expressions: _col0 (type: string), _col1 (type: string) sort order: ++ -Map-reduce partition columns: _col0 (type: string) +Map-reduce partition columns: _col0 (type: string), _col1 (type: string) Review comment: hmm...there is also a `count(DISTINCT substr(src_temp.value,5))` and the `_col1` grouping seems to be working on `substr(src_temp.value,5)` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
