[GitHub] [hive] miklosgergely commented on a change in pull request #821: HIVE-22311

2019-10-30 Thread GitBox
miklosgergely commented on a change in pull request #821: HIVE-22311
URL: https://github.com/apache/hive/pull/821#discussion_r340602838
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 ##
 @@ -2115,6 +2133,8 @@ public Object process(Node nd, Stack stack, 
NodeProcessorCtx procCtx,
 pred = jop.getConf().getResidualFilterExprs().get(0);
   }
   // evaluate filter expression and update statistics
+  final boolean uniformWithinRange = HiveConf.getBoolVar(
 
 Review comment:
   This seems to be unused.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org



[GitHub] [hive] miklosgergely commented on a change in pull request #821: HIVE-22311

2019-10-30 Thread GitBox
miklosgergely commented on a change in pull request #821: HIVE-22311
URL: https://github.com/apache/hive/pull/821#discussion_r340594059
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 ##
 @@ -338,6 +338,19 @@ private ColumnStatisticsData getStatistics(FieldSchema 
column, List

[GitHub] [hive] miklosgergely commented on a change in pull request #821: HIVE-22311

2019-10-30 Thread GitBox
miklosgergely commented on a change in pull request #821: HIVE-22311
URL: https://github.com/apache/hive/pull/821#discussion_r340602551
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 ##
 @@ -2022,6 +2038,8 @@ public Object process(Node nd, Stack stack, 
NodeProcessorCtx procCtx,
 pred = jop.getConf().getResidualFilterExprs().get(0);
   }
   // evaluate filter expression and update statistics
+  final boolean uniformWithinRange = HiveConf.getBoolVar(
 
 Review comment:
   This seems to be unused.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org