Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
difin merged PR #6157: URL: https://github.com/apache/hive/pull/6157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
zhangbutao commented on PR #6157: URL: https://github.com/apache/hive/pull/6157#issuecomment-3479685680 > According to my memory, removing this part of the code means the coloring output only means that the header has different font type than the result set data. As I mentioned, this part of the code relates to the primary key and has never taken effect in Hive beeline, so I'm not very clear about the color or font of its output display. > What about removing the coloring functionality at all? With this change Beeline still accepts the color parameter. But what is the effect of that parameter? Regarding whether to remove the entire coloring functionality code, I'm not entirely sure if there are real-world users who actually use the color option. However, through a Google search for the keyword `beeline --color`, I found many related articles. Therefore, I assume that the existence of the --color option is meaningful, and there is no need to completely remove the coloring functionality at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
InvisibleProgrammer commented on PR #6157: URL: https://github.com/apache/hive/pull/6157#issuecomment-3472389839 According to my memory, removing this part of the code means the coloring output only means that the header has different font type than the result set data. What about removing the coloring functionality at all? With this change Beeline still accepts the color parameter. But what is the effect of that parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
zhangbutao commented on PR #6157: URL: https://github.com/apache/hive/pull/6157#issuecomment-3470923502 > why not simply revert JIRA that introduced PK fetching? The code for PK in Beeline was introduced during the implementation of HS2, rather than being implemented through a separate JIRA. See https://github.com/apache/hive/commit/96083e71710ac11b6cf511d23ebb6d855974f98d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
deniskuzZ commented on PR #6157: URL: https://github.com/apache/hive/pull/6157#issuecomment-3467767434 why not simply revert JIRA that introduced PK fetching? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
sonarqubecloud[bot] commented on PR #6157: URL: https://github.com/apache/hive/pull/6157#issuecomment-3466023262 ## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6157) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6157&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6157&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6157&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6157&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6157&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6157) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29296: Remove getPrimaryKeys codes from beeline module [hive]
zhangbutao commented on code in PR #6157:
URL: https://github.com/apache/hive/pull/6157#discussion_r2476268703
##
beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java:
##
@@ -122,18 +122,10 @@ ColorBuffer getOutputString(Rows rows, Rows.Row row,
String delim) {
if (row.isMeta) {
v = beeLine.getColorBuffer().center(row.values[i], row.sizes[i]);
-if (beeLine.getOpts().getColor() && rows.isPrimaryKeyCol(i)) {
- buf.cyan(v.getMono());
Review Comment:
Retrieving the primary key in Beeline is just for coloring the output.
Removing this code blocks is safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
