Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
deniskuzZ merged PR #6160: URL: https://github.com/apache/hive/pull/6160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
sonarqubecloud[bot] commented on PR #6160: URL: https://github.com/apache/hive/pull/6160#issuecomment-3474319924 ## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
sonarqubecloud[bot] commented on PR #6160: URL: https://github.com/apache/hive/pull/6160#issuecomment-3473591471 ## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
sonarqubecloud[bot] commented on PR #6160: URL: https://github.com/apache/hive/pull/6160#issuecomment-3472287692 ## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
kuczoram commented on code in PR #6160:
URL: https://github.com/apache/hive/pull/6160#discussion_r2480570824
##
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##
@@ -1052,10 +1052,25 @@ public static Path toTaskTempPath(Path orig) {
}
public static Path toTempPath(Path orig) {
-if (orig.getName().indexOf(tmpPrefix) == 0) {
+return toTempPath(orig, tmpPrefix);
+ }
+
+ public static Path toTempPath(Path orig, String prefix) {
+if (orig.getName().indexOf(prefix) == 0) {
return orig;
}
-return new Path(orig.getParent(), tmpPrefix + orig.getName());
+return new Path(orig.getParent(), prefix + orig.getName());
+ }
+
+ /**
+ * This method is to convert a path into a temporary path for the direct
insert manifest files.
+ * It is important to use a prefix which starts with '_', like '_tmp.', so
the content of this
+ * directory would be filtered out by the AcidUtils.acidHiddenFileFilter.
+ * @param orig
+ * @return
+ */
+ public static Path toTempPathForManifestDir(String orig) {
Review Comment:
yeah, sounds good. fixed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
kuczoram commented on code in PR #6160:
URL: https://github.com/apache/hive/pull/6160#discussion_r2480566776
##
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##
@@ -1052,10 +1052,25 @@ public static Path toTaskTempPath(Path orig) {
}
public static Path toTempPath(Path orig) {
-if (orig.getName().indexOf(tmpPrefix) == 0) {
+return toTempPath(orig, tmpPrefix);
+ }
+
+ public static Path toTempPath(Path orig, String prefix) {
Review Comment:
sure, fixed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
deniskuzZ commented on code in PR #6160:
URL: https://github.com/apache/hive/pull/6160#discussion_r2477986891
##
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##
@@ -1052,10 +1052,25 @@ public static Path toTaskTempPath(Path orig) {
}
public static Path toTempPath(Path orig) {
-if (orig.getName().indexOf(tmpPrefix) == 0) {
+return toTempPath(orig, tmpPrefix);
+ }
+
+ public static Path toTempPath(Path orig, String prefix) {
Review Comment:
could we keep it private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
deniskuzZ commented on code in PR #6160:
URL: https://github.com/apache/hive/pull/6160#discussion_r2477983839
##
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##
@@ -1052,10 +1052,25 @@ public static Path toTaskTempPath(Path orig) {
}
public static Path toTempPath(Path orig) {
-if (orig.getName().indexOf(tmpPrefix) == 0) {
+return toTempPath(orig, tmpPrefix);
+ }
+
+ public static Path toTempPath(Path orig, String prefix) {
+if (orig.getName().indexOf(prefix) == 0) {
return orig;
}
-return new Path(orig.getParent(), tmpPrefix + orig.getName());
+return new Path(orig.getParent(), prefix + orig.getName());
+ }
+
+ /**
+ * This method is to convert a path into a temporary path for the direct
insert manifest files.
+ * It is important to use a prefix which starts with '_', like '_tmp.', so
the content of this
+ * directory would be filtered out by the AcidUtils.acidHiddenFileFilter.
+ * @param orig
+ * @return
+ */
+ public static Path toTempPathForManifestDir(String orig) {
Review Comment:
maybe `toManifestDirTempPath` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] HIVE-29297: The directory of the direct insert manifest files should … [hive]
sonarqubecloud[bot] commented on PR #6160: URL: https://github.com/apache/hive/pull/6160#issuecomment-3466973688 ## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6160&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6160&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6160&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6160) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
