github-actions[bot] commented on pull request #7255:
URL: https://github.com/apache/arrow/pull/7255#issuecomment-633156895
https://issues.apache.org/jira/browse/ARROW-8913
This is an automated message from the Apache Git
kou opened a new pull request #7255:
URL: https://github.com/apache/arrow/pull/7255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7254:
URL: https://github.com/apache/arrow/pull/7254#issuecomment-633154973
https://issues.apache.org/jira/browse/ARROW-8912
This is an automated message from the Apache Git
kou opened a new pull request #7254:
URL: https://github.com/apache/arrow/pull/7254
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633154141
I'd like to work on a couple follow-up PRs tomorrow, so in order to unblock
these PRs so that they can be reviewed, this PR will have to be merged first.
So I would like to do that
houqp commented on pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#issuecomment-633146402
Since integer to float conversion can also cause data loss, do we want to
leave that to explicit cast path as well?
andygrove commented on pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#issuecomment-633144310
@houqp I pushed more changes. There will be more to do but for now,
DataFusion will only add implicit casts when safe (so no more conversions
between signed and unsigned int
andygrove commented on a change in pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#discussion_r429578850
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -725,36 +725,47 @@ impl fmt::Debug for LogicalPlan {
/// Verify a given type cast can be
andygrove closed pull request #7230:
URL: https://github.com/apache/arrow/pull/7230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
houqp commented on a change in pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#discussion_r429575153
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -725,36 +725,47 @@ impl fmt::Debug for LogicalPlan {
/// Verify a given type cast can be performed
houqp commented on a change in pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#discussion_r429569531
##
File path: rust/datafusion/src/optimizer/utils.rs
##
@@ -131,116 +131,90 @@ pub fn exprlist_to_fields(expr: &[Expr], input_schema:
) -> Result Result {
-
houqp commented on a change in pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#discussion_r429568842
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -725,36 +725,47 @@ impl fmt::Debug for LogicalPlan {
/// Verify a given type cast can be performed
emkornfield commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-633101224
If there is a mechanism to fail the build with these rules I would recommend
trying to add it to the list for check to avoid regressions
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429553399
##
File path: cpp/src/jni/dataset/jni_wrapper.cpp
##
@@ -0,0 +1,517 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429552386
##
File path: cpp/src/arrow/dataset/file_base.h
##
@@ -290,5 +290,35 @@ class ARROW_DS_EXPORT WritePlan {
std::vector paths;
};
+class
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429551637
##
File path: cpp/.gitignore
##
@@ -24,6 +24,8 @@ cmake_install.cmake
build/
*-build/
Testing/
+cmake-build-debug/
Review comment:
OK.
andygrove commented on pull request #7230:
URL: https://github.com/apache/arrow/pull/7230#issuecomment-633059601
@houqp Could you review if you have time.
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#issuecomment-633054362
https://issues.apache.org/jira/browse/ARROW-4957
This is an automated message from the Apache Git
andygrove opened a new pull request #7253:
URL: https://github.com/apache/arrow/pull/7253
Re-implement get_supertype so that it is complete and easier to comprehend.
This is an automated message from the Apache Git Service.
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633051554
The build is passing (the Travis thing is a flake on ARM architecture),
thanks @kou for your help with that! I think we should merge this today and I
will continue to address
jorisvandenbossche commented on a change in pull request #7180:
URL: https://github.com/apache/arrow/pull/7180#discussion_r429523732
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -1468,6 +1468,7 @@ def test_parquet_dataset_factory(tempdir):
root_path = tempdir
21 matches
Mail list logo
