[GitHub] [arrow] houqp commented on pull request #7324: ARROW-9005: [Rust] [Datafusion] support sort expression

2020-06-07 Thread GitBox
houqp commented on pull request #7324: URL: https://github.com/apache/arrow/pull/7324#issuecomment-640380594 alright, i have added nulls ordering support through sqlparser 0.2.6. only thing left is waiting for merge of #7365.

[GitHub] [arrow] emkornfield commented on pull request #7110: ARROW-8952: [C++] WIP Support for textual, JSON schema representation

2020-06-07 Thread GitBox
emkornfield commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-640346575 @chish42 I don't have a lot of expertise in CMake. Not sure if it helps but we've already checked in generated flatbuffers header files checked in

[GitHub] [arrow] andygrove commented on pull request #7324: ARROW-9005: [Rust] [Datafusion] support sort expression

2020-06-07 Thread GitBox
andygrove commented on pull request #7324: URL: https://github.com/apache/arrow/pull/7324#issuecomment-640336526 @houqp I released sqlparser 0.2.6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] andygrove commented on a change in pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method

2020-06-07 Thread GitBox
andygrove commented on a change in pull request #7371: URL: https://github.com/apache/arrow/pull/7371#discussion_r436435692 ## File path: rust/datafusion/src/execution/table_impl.rs ## @@ -131,6 +132,11 @@ impl Table for TableImpl { ) -> Result> {

[GitHub] [arrow] liyafan82 commented on pull request #7354: ARROW-8909: [Java] Out of order writes using setSafe

2020-06-07 Thread GitBox
liyafan82 commented on pull request #7354: URL: https://github.com/apache/arrow/pull/7354#issuecomment-640323257 > +1 > > Do we ever want to support out of order writes? @rymurr Thanks a lot for your comments. I am not sure, as writing a value out of order may require moving

[GitHub] [arrow] liyafan82 commented on a change in pull request #7354: ARROW-8909: [Java] Out of order writes using setSafe

2020-06-07 Thread GitBox
liyafan82 commented on a change in pull request #7354: URL: https://github.com/apache/arrow/pull/7354#discussion_r436429167 ## File path: docs/source/java/vector.rst ## @@ -118,6 +118,28 @@ Some points to note about the steps above: no longer used, to avoid resource leak.

[GitHub] [arrow] github-actions[bot] commented on pull request #7372: ARROW-9061: [Packaging][APT][Yum][GLib] Add Apache Arrow Datasets GLib

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7372: URL: https://github.com/apache/arrow/pull/7372#issuecomment-640306153 Revision: 0f9c61c6719dcc78cfe4adb91ffaa1fd554219fa Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7372: ARROW-9061: [Packaging][APT][Yum][GLib] Add Apache Arrow Datasets GLib

2020-06-07 Thread GitBox
kou commented on pull request #7372: URL: https://github.com/apache/arrow/pull/7372#issuecomment-640305823 @github-actions crossbow submit -g linux This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou opened a new pull request #7372: ARROW-9061: [Packaging][APT][Yum][GLib] Add Apache Arrow Datasets GLib

2020-06-07 Thread GitBox
kou opened a new pull request #7372: URL: https://github.com/apache/arrow/pull/7372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kou closed pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou closed pull request #7370: URL: https://github.com/apache/arrow/pull/7370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640297404 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7371: URL: https://github.com/apache/arrow/pull/7371#issuecomment-640288022 https://issues.apache.org/jira/browse/ARROW-8736 This is an automated message from the Apache Git

[GitHub] [arrow] kyle-mccarthy opened a new pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method

2020-06-07 Thread GitBox
kyle-mccarthy opened a new pull request #7371: URL: https://github.com/apache/arrow/pull/7371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640284750 Revision: 516b7be6e3e1a48d58a76899cd60a2da0b01b85b Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640284572 @github-actions crossbow submit -g linux This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640283866 Revision: f32d9807ae6dfb9a3c706dee6103d930009ca7f4 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640283675 @github-actions crossbow submit -g wheel This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640283653 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kszucs commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kszucs commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640280052 @kou I set up the environment variables using my credentials, both env variables should be available now in the travis, azure and github builds.

[GitHub] [arrow] github-actions[bot] commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640279770 Revision: aa9b75f5ce41359a6f8cdb0ab9b8043c4bb5a53f Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640279549 @github-actions crossbow submit -g linux This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640277036 @kszucs Could you set `ARCHERY_DOCKER_USER` and `ARCHERY_DOCKER_PASSWORD` environment variables to https://dev.azure.com/ursa-labs/crossbow/ ? If we have them, images for wheels can

[GitHub] [arrow] github-actions[bot] commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640275418 https://issues.apache.org/jira/browse/ARROW-9060 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640274913 Revision: aa9b75f5ce41359a6f8cdb0ab9b8043c4bb5a53f Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou commented on pull request #7370: URL: https://github.com/apache/arrow/pull/7370#issuecomment-640274678 @github-actions crossbow submit debian-buster-amd64 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou opened a new pull request #7370: ARROW-9060: [GLib] Add support for building Apache Arrow Datasets GLib with non-installed Apache Arrow Datasets

2020-06-07 Thread GitBox
kou opened a new pull request #7370: URL: https://github.com/apache/arrow/pull/7370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm commented on pull request #7240: ARROW-8792: [C++][Python][R][GLib] New Array compute kernels implementation and execution framework

2020-06-07 Thread GitBox
wesm commented on pull request #7240: URL: https://github.com/apache/arrow/pull/7240#issuecomment-640250180 Closing the PR again. Please open JIRA issues or review other PRs to provide more feedback. This is an automated

[GitHub] [arrow] wesm closed pull request #7240: ARROW-8792: [C++][Python][R][GLib] New Array compute kernels implementation and execution framework

2020-06-07 Thread GitBox
wesm closed pull request #7240: URL: https://github.com/apache/arrow/pull/7240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7369: ARROW-9059 [RUST] Fix sign in array slice_data_docstring

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7369: URL: https://github.com/apache/arrow/pull/7369#issuecomment-640249069 https://issues.apache.org/jira/browse/ARROW-9059 This is an automated message from the Apache Git

[GitHub] [arrow] robert-wagner opened a new pull request #7369: ARROW-9059 [RUST] Fix sign in array slice_data_docstring

2020-06-07 Thread GitBox
robert-wagner opened a new pull request #7369: URL: https://github.com/apache/arrow/pull/7369 Change the panic behavior in the docstring to reflect the panic behavior in the code This is an automated message from the Apache

[GitHub] [arrow] wesm closed pull request #7280: ARROW-8157: [C++][Gandiva] Support building with LLVM 9

2020-06-07 Thread GitBox
wesm closed pull request #7280: URL: https://github.com/apache/arrow/pull/7280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] fsaintjacques closed pull request #7353: ARROW-9037: [C++] C-ABI: do not error out when importing array with null_count == -1

2020-06-07 Thread GitBox
fsaintjacques closed pull request #7353: URL: https://github.com/apache/arrow/pull/7353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nevi-me commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-07 Thread GitBox
nevi-me commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436354577 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +632,81 @@ where self } +/// Appends data from other arrays into the builder

[GitHub] [arrow] github-actions[bot] commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640180883 https://issues.apache.org/jira/browse/ARROW-9058 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640180722 Revision: 9287230aaf8b33352e4666494e6b72e507fc1aa3 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640180695 Or should we mirror Boost 1.68.0 at https://dl.bintray.com/ursalabs/arrow-boost/ ? This is an automated message from

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640180469 @github-actions crossbow submit -g wheel This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou opened a new pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

2020-06-07 Thread GitBox
kou opened a new pull request #7368: URL: https://github.com/apache/arrow/pull/7368 Because dl.bintray.com/boostorg/ sometimes reaches limitation. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-07 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436336846 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +632,81 @@ where self } +/// Appends data from other arrays into the builder +

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-07 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436335986 ## File path: rust/arrow/src/array/builder.rs ## @@ -841,12 +1048,91 @@ impl ArrayBuilder for StringBuilder { } } +// Helper function for appending

[GitHub] [arrow] github-actions[bot] commented on pull request #7367: ARROW-9057: [Rust][Datafusion] fix projection on in memory scan

2020-06-07 Thread GitBox
github-actions[bot] commented on pull request #7367: URL: https://github.com/apache/arrow/pull/7367#issuecomment-640170791 https://issues.apache.org/jira/browse/ARROW-9057 This is an automated message from the Apache Git

[GitHub] [arrow] houqp opened a new pull request #7367: ARROW-9057: [Rust][Datafusion] fix projection on in memory scan

2020-06-07 Thread GitBox
houqp opened a new pull request #7367: URL: https://github.com/apache/arrow/pull/7367 This fixes the `ArrowError::InvalidArgumentError` returned by `RecordBatch::try_new`. This is an automated message from the Apache Git