[GitHub] [arrow] tianchen92 commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

2020-06-14 Thread GitBox
tianchen92 commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-643892709 Thanks @rymurr for the review. @emkornfield Do you have other comments? otherwise I'll merge this in several days later.

[GitHub] [arrow] liyafan82 commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-06-14 Thread GitBox
liyafan82 commented on pull request #6729: URL: https://github.com/apache/arrow/pull/6729#issuecomment-643872298 > This breaks Spark: https://github.com/ursa-labs/crossbow/runs/769424833#step:6:13025 > > ``` > [ERROR] [Error]

[GitHub] [arrow] wesm closed pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-14 Thread GitBox
wesm closed pull request #7417: URL: https://github.com/apache/arrow/pull/7417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7421: ARROW-9030: [Python] Remove pyarrow/compat.py, move some oft-used utility functions to pyarrow.lib

2020-06-14 Thread GitBox
wesm commented on pull request #7421: URL: https://github.com/apache/arrow/pull/7421#issuecomment-643865571 That's unfortunate. We can restore pyarrow.compat with wrappers for the functions that have deprecation warnings. I opened https://issues.apache.org/jira/browse/ARROW-9130

[GitHub] [arrow] kou closed pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

2020-06-14 Thread GitBox
kou closed pull request #7433: URL: https://github.com/apache/arrow/pull/7433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

2020-06-14 Thread GitBox
kou commented on pull request #7433: URL: https://github.com/apache/arrow/pull/7433#issuecomment-643824491 +1 The error has gone but new errors are appeared: https://github.com/ursa-labs/crossbow/runs/770616977?check_suite_focus=true#step:6:10042 ```text >

[GitHub] [arrow] kou commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-06-14 Thread GitBox
kou commented on pull request #6729: URL: https://github.com/apache/arrow/pull/6729#issuecomment-643823860 This breaks Spark: https://github.com/ursa-labs/crossbow/runs/769424833#step:6:13025 ```text [ERROR] [Error]

[GitHub] [arrow] kou commented on pull request #7335: ARROW-9018: [C++] Remove APIs that were marked as deprecated in 0.17.0 and prior

2020-06-14 Thread GitBox
kou commented on pull request #7335: URL: https://github.com/apache/arrow/pull/7335#issuecomment-643822639 This breaks Turbodbc: https://github.com/dask/dask/blob/master/dask/dataframe/io/parquet/arrow.py#L9 Turbodbc uses `Status AllocateResizableBuffer(MemoryPool* pool, ...)`:

[GitHub] [arrow] kou commented on pull request #7421: ARROW-9030: [Python] Remove pyarrow/compat.py, move some oft-used utility functions to pyarrow.lib

2020-06-14 Thread GitBox
kou commented on pull request #7421: URL: https://github.com/apache/arrow/pull/7421#issuecomment-643821762 This breaks Dask: https://github.com/ursa-labs/crossbow/runs/769427250#step:6:12381 Because Dask depends on `pyarrow.compat`:

[GitHub] [arrow] github-actions[bot] commented on pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

2020-06-14 Thread GitBox
github-actions[bot] commented on pull request #7433: URL: https://github.com/apache/arrow/pull/7433#issuecomment-643821823 https://issues.apache.org/jira/browse/ARROW-9129 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

2020-06-14 Thread GitBox
github-actions[bot] commented on pull request #7433: URL: https://github.com/apache/arrow/pull/7433#issuecomment-643821184 Revision: 4fd9f1696970c48eb9ceeca3fef975fcd9905be9 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou opened a new pull request #7433: ARROW-9129: [Python][JPype] Remove JPype version check

2020-06-14 Thread GitBox
kou opened a new pull request #7433: URL: https://github.com/apache/arrow/pull/7433 Because we only run the test with the latest JPype. Error details: https://github.com/ursa-labs/crossbow/runs/769433714#step:6:7995 ```text > if jpype.__version_info__ >= (0,

[GitHub] [arrow] kiszk commented on a change in pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-14 Thread GitBox
kiszk commented on a change in pull request #7402: URL: https://github.com/apache/arrow/pull/7402#discussion_r439854412 ## File path: cpp/src/gandiva/precompiled/string_ops_test.cc ## @@ -426,6 +426,33 @@ TEST(TestStringOps, TestReverse) { ctx.Reset(); }

[GitHub] [arrow] github-actions[bot] commented on pull request #7432: ARROW-9127: [Rust] Update thrift dependency to 0.13 (latest)

2020-06-14 Thread GitBox
github-actions[bot] commented on pull request #7432: URL: https://github.com/apache/arrow/pull/7432#issuecomment-643753938 https://issues.apache.org/jira/browse/ARROW-9127 This is an automated message from the Apache Git

[GitHub] [arrow] alamb opened a new pull request #7432: ARROW-8124: [Rust] Update thrift dependency to 0.13 (latest)

2020-06-14 Thread GitBox
alamb opened a new pull request #7432: URL: https://github.com/apache/arrow/pull/7432 Update to latest version of apache thrift (1.3) Rationale: We were trying to update the version of `byteorder` that an internal project used, but arrow/parquet -> depends on parquet-format-rs ->