jorgecarleitao commented on a change in pull request #7876:
URL: https://github.com/apache/arrow/pull/7876#discussion_r469002405
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -0,0 +1,185 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-672568598
Thanks, @andygrove . This is now rebased.
This is an automated message from the Apache Git Service.
To
andygrove commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-672564651
I did a quick review of this PR and it looks good I think. @jorgecarleitao
would you mind rebasing it and I'll find time this week for a more thorough
review.
andygrove commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-672564300
@jorgecarleitao So I saw that #7799 was merged. What does that mean for this
PR now?
This is an automated
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r468987274
##
File path: java/vector/src/main/java/org/apache/arrow/vector/VectorUnloader.java
##
@@ -76,6 +97,10 @@ private void appendNodes(FieldVector vector,
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r468987159
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtil.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r468986947
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##
@@ -408,11 +408,15 @@ public static
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r468986440
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/DefaultCompressionCodec.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r468986032
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/DefaultCompressionCodec.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
andygrove closed pull request #7930:
URL: https://github.com/apache/arrow/pull/7930
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7935:
URL: https://github.com/apache/arrow/pull/7935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7924:
URL: https://github.com/apache/arrow/pull/7924
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7936:
URL: https://github.com/apache/arrow/pull/7936#issuecomment-672408880
https://issues.apache.org/jira/browse/ARROW-9679
This is an automated message from the Apache Git
andygrove commented on pull request #7936:
URL: https://github.com/apache/arrow/pull/7936#issuecomment-672393908
@alamb @jorgecarleitao @houqp fyi, since you've all been contributing to
DataFusion lately
This is an
andygrove opened a new pull request #7936:
URL: https://github.com/apache/arrow/pull/7936
This isn't quite there yet. I hope to wrap this up tomorrow.
This is an automated message from the Apache Git Service.
To respond to
mrkn edited a comment on pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#issuecomment-672392348
@pitrou @wesm I found that `DictionaryBuilderCase` rejects that the value
type is `NullType` though there is the specialization of
`DictionaryBuilderBase` with `T=NullType`.
mrkn commented on pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#issuecomment-672392348
@pitrou @wesm I found that DictionaryBuilderCase rejects that the value type
is NullType though there is the specialization of DictionaryBuilderBase with
T=NullType. Is this
github-actions[bot] commented on pull request #7935:
URL: https://github.com/apache/arrow/pull/7935#issuecomment-672284943
https://issues.apache.org/jira/browse/ARROW-9696
This is an automated message from the Apache Git
mcassels opened a new pull request #7935:
URL: https://github.com/apache/arrow/pull/7935
Nested binary expressions like `(a+b)/2` were previously supported and were
broken by the upgrade to sqlparser 0.6.1.
This is an
github-actions[bot] commented on pull request #7934:
URL: https://github.com/apache/arrow/pull/7934#issuecomment-672264125
https://issues.apache.org/jira/browse/ARROW-9695
This is an automated message from the Apache Git
alamb opened a new pull request #7934:
URL: https://github.com/apache/arrow/pull/7934
While reviewing the DataFusion code more (thanks again for this great piece
of work) I have some small suggestions on improving the documentation that I
would have personally appreciated while reading
nealrichardson closed pull request #7929:
URL: https://github.com/apache/arrow/pull/7929
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pitrou closed pull request #7931:
URL: https://github.com/apache/arrow/pull/7931
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-672166964
+1, will merge
This is an automated message from the Apache Git Service.
To respond to the message, please log on
corleyma commented on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-672112334
> @corleyma Can you apply this patch?
https://gist.github.com/pitrou/0dc970a2238b9c19b5f8fb991d2fb8f7
Whoops, didn't notice you were playing in this fork too. I'll quit
kszucs commented on pull request #7933:
URL: https://github.com/apache/arrow/pull/7933#issuecomment-672077311
I was using `-X theirs` during the cherry-pick which I'm going to remove to
have explicit resolution about possible cherry-pick conflicts.
github-actions[bot] commented on pull request #7933:
URL: https://github.com/apache/arrow/pull/7933#issuecomment-672062600
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
kszucs opened a new pull request #7933:
URL: https://github.com/apache/arrow/pull/7933
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7932:
URL: https://github.com/apache/arrow/pull/7932#issuecomment-672039769
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
kszucs opened a new pull request #7932:
URL: https://github.com/apache/arrow/pull/7932
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou closed pull request #7920:
URL: https://github.com/apache/arrow/pull/7920
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7909:
URL: https://github.com/apache/arrow/pull/7909#issuecomment-672026104
This PR is definitely a bit ad hoc, but it's required to fix the observed
regression. I think we need to find a strategy later on for dealing with
manipulations of GPU-located
pitrou commented on pull request #7909:
URL: https://github.com/apache/arrow/pull/7909#issuecomment-672024248
I rebased and added some changes.
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-672007067
Revision: 8175df5754f677e213629e360e20611a492b9921
Submitted crossbow builds: [ursa-labs/crossbow @
mrkn commented on a change in pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#discussion_r468657312
##
File path: cpp/src/arrow/array/builder_dict.h
##
@@ -409,6 +409,10 @@ class DictionaryBuilder : public
internal::DictionaryBuilderBase;
using
pitrou commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-672005624
@github-actions crossbow submit -g wheel
This is an automated message from the Apache Git Service.
To respond to
mrkn commented on a change in pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#discussion_r468656539
##
File path: cpp/src/arrow/array/array_dict_test.cc
##
@@ -22,6 +22,8 @@
#include
#include
+#include
Review comment:
This should be removed
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-672004398
> If I disable the arrow unity build, then it succeeds in linking aws-sdk,
but then it fails building the vendored jemalloc. If I disable both jemalloc
and unity-build,
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-672004049
In https://travis-ci.org/github/ursa-labs/crossbow/builds/716930465 it seems
that cmake can't find aws-c-common, though I see it is downloaded, so I wonder
if we're
jorgecarleitao commented on pull request #7930:
URL: https://github.com/apache/arrow/pull/7930#issuecomment-672001189
LGTM!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
andygrove commented on pull request #7930:
URL: https://github.com/apache/arrow/pull/7930#issuecomment-671999147
@alamb @jorgecarleitao fyi
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove closed pull request #7918:
URL: https://github.com/apache/arrow/pull/7918
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7925:
URL: https://github.com/apache/arrow/pull/7925
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeroen commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671994419
If I disable the arrow unity build, then it succeeds in linking aws-sdk, but
then it fails building the vendored jemalloc. If I disable both jemalloc and
unity-build, then
github-actions[bot] commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-671982553
https://issues.apache.org/jira/browse/ARROW-9692
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468626923
##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake
github-actions[bot] commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-671980613
Revision: 8175df5754f677e213629e360e20611a492b9921
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671979365
Revision: 3e72b7ad35355b66ae9b34d2d26dbcb879d19f82
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7931:
URL: https://github.com/apache/arrow/pull/7931#issuecomment-671977144
@github-actions crossbow submit -g python
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468620814
##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake
pitrou opened a new pull request #7931:
URL: https://github.com/apache/arrow/pull/7931
Setuptools should be imported before distutils.
This is an automated message from the Apache Git Service.
To respond to the message,
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671975955
@github-actions crossbow submit homebrew-cpp-autobrew
This is an automated message from the Apache Git
jeroen commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671973724
Maybe there is a problem with the unity builds of aws-sdk-cpp or arrow
This is an automated message from the
pitrou commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r468605319
##
File path: cpp/src/arrow/filesystem/s3fs_test.cc
##
@@ -197,6 +201,44 @@ TEST(S3Options, FromUri) {
ASSERT_RAISES(Invalid,
pitrou edited a comment on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671959521
> Is there anything I need to do to get the CI systems to pick up the new
conda-forge packages?
I don't think so, perhaps there is a CDN in-between that delays the
pitrou edited a comment on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671963588
@corleyma Can you apply this patch?
https://gist.github.com/pitrou/0dc970a2238b9c19b5f8fb991d2fb8f7
This
github-actions[bot] commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671963778
Revision: 9a8364dd3e89052f2925f34fc591f5e17563ab90
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671963588
@corleyma Can you apply this patch?
This is an automated message from the Apache Git Service.
To respond to the
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671961594
@github-actions crossbow submit homebrew-cpp-autobrew
This is an automated message from the Apache Git
pitrou commented on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671961201
@corleyma Hmm, it seems that by force-pushing you deleted the changes I made
yesterday.
This is an automated
pitrou commented on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671959521
> Is there anything I need to do to get the CI systems to pick up the new
conda-forge packages?
I don't think so, perhaps there is a CDN in-between that delays the package
pitrou commented on pull request #7920:
URL: https://github.com/apache/arrow/pull/7920#issuecomment-671958639
Rebased and pushed a tiny change. Will merge if/when CI is green.
This is an automated message from the Apache Git
nevi-me commented on a change in pull request #7876:
URL: https://github.com/apache/arrow/pull/7876#discussion_r468582014
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -0,0 +1,185 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
nevi-me commented on a change in pull request #7876:
URL: https://github.com/apache/arrow/pull/7876#discussion_r468581694
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -0,0 +1,185 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
github-actions[bot] commented on pull request #7930:
URL: https://github.com/apache/arrow/pull/7930#issuecomment-671948694
https://issues.apache.org/jira/browse/ARROW-9691
This is an automated message from the Apache Git
andygrove opened a new pull request #7930:
URL: https://github.com/apache/arrow/pull/7930
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wesm closed issue #7910:
URL: https://github.com/apache/arrow/issues/7910
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-671932929
No idea. Can we have the entire output from `make`?
This is an automated message from the Apache Git Service.
To
rymurr commented on a change in pull request #7768:
URL: https://github.com/apache/arrow/pull/7768#discussion_r468539432
##
File path:
java/memory/memory-core/src/main/java/org/apache/arrow/memory/BufferAllocator.java
##
@@ -126,6 +134,30 @@ BufferAllocator newChildAllocator(
pitrou commented on pull request #7908:
URL: https://github.com/apache/arrow/pull/7908#issuecomment-671836605
No urgency at all. This is just an improvement in development comfort.
This is an automated message from the
emkornfield commented on pull request #7908:
URL: https://github.com/apache/arrow/pull/7908#issuecomment-671835723
Is there an urgency for this? Have my hands full at work today and tomorrow
at least, i can try to look later in the week?
pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468419449
##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <-
pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468418886
##
File path: r/tools/linuxlibs.R
##
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <-
corleyma edited a comment on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671774899
> I've submitted a PR for conda-forge at
[conda-forge/aws-sdk-cpp-feedstock#124](https://github.com/conda-forge/aws-sdk-cpp-feedstock/pull/124)
Thanks for that
corleyma commented on pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#issuecomment-671774899
> I've submitted a PR for conda-forge at
[conda-forge/aws-sdk-cpp-feedstock#124](https://github.com/conda-forge/aws-sdk-cpp-feedstock/pull/124)
Thanks for that @pitrou.
corleyma commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r468369686
##
File path: cpp/src/arrow/filesystem/s3fs.h
##
@@ -62,10 +75,18 @@ struct ARROW_EXPORT S3Options {
void ConfigureAnonymousCredentials();
///
kiszk commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-671751774
@kou I addressed your two comments.
This is an automated message from the Apache Git Service.
To respond to the
77 matches
Mail list logo
