[GitHub] [arrow] alamb commented on a change in pull request #7880: ARROW-9619: [Rust] [DataFusion] Add predicate push-down

2020-08-18 Thread GitBox
alamb commented on a change in pull request #7880: URL: https://github.com/apache/arrow/pull/7880#discussion_r472133640 ## File path: rust/datafusion/src/optimizer/filter_push_down.rs ## @@ -0,0 +1,631 @@ +// regarding copyright ownership. The ASF licenses this file +// to

[GitHub] [arrow] alamb commented on pull request #7971: ARROW-9752: [Rust] [DataFusion] Add support for aggregate UDFs

2020-08-18 Thread GitBox
alamb commented on pull request #7971: URL: https://github.com/apache/arrow/pull/7971#issuecomment-675442799 Looking briefly at Spark, it seems that user defined aggregates have a single defined return type: https://docs.databricks.com/spark/latest/spark-sql/udaf-scala.html ```

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7921: ARROW-9658: [Python] Python bindings for dataset writing

2020-08-18 Thread GitBox
jorisvandenbossche commented on a change in pull request #7921: URL: https://github.com/apache/arrow/pull/7921#discussion_r472119868 ## File path: python/pyarrow/_dataset.pyx ## @@ -2022,3 +2022,66 @@ def _get_partition_keys(Expression partition_expression):

[GitHub] [arrow] github-actions[bot] commented on pull request #7917: ARROW-8423: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
github-actions[bot] commented on pull request #7917: URL: https://github.com/apache/arrow/pull/7917#issuecomment-675430328 https://issues.apache.org/jira/browse/ARROW-8423 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r472106770 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r472105674 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] github-actions[bot] commented on pull request #7986: ARROW-9781: [C++] Fix valgrind uninitialized value warnings

2020-08-18 Thread GitBox
github-actions[bot] commented on pull request #7986: URL: https://github.com/apache/arrow/pull/7986#issuecomment-675418952 https://issues.apache.org/jira/browse/ARROW-9781 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7986: ARROW-9781: [C++] Fix valgrind uninitialized value warnings

2020-08-18 Thread GitBox
github-actions[bot] commented on pull request #7986: URL: https://github.com/apache/arrow/pull/7986#issuecomment-675416885 Revision: 8a188f07e5958bc50f54d7977046c3230245b517 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kszucs commented on pull request #7986: ARROW-9781: [C++] Fix valgrind uninitialized value warnings

2020-08-18 Thread GitBox
kszucs commented on pull request #7986: URL: https://github.com/apache/arrow/pull/7986#issuecomment-675414540 @github-actions crossbow submit test-conda-cpp-valgrind This is an automated message from the Apache Git

[GitHub] [arrow] kszucs opened a new pull request #7986: ARROW-9781: [C++] Fix valgrind uninitialized value warnings

2020-08-18 Thread GitBox
kszucs opened a new pull request #7986: URL: https://github.com/apache/arrow/pull/7986 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7985: [WIP][Release] Verify 1.0.1 release candidate RC0

2020-08-18 Thread GitBox
github-actions[bot] commented on pull request #7985: URL: https://github.com/apache/arrow/pull/7985#issuecomment-675395644 Revision: a14b77583dd307c1960bb08f36033621a85dc2d6 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kszucs commented on pull request #7985: [WIP][Release] Verify 1.0.1 release candidate RC0

2020-08-18 Thread GitBox
kszucs commented on pull request #7985: URL: https://github.com/apache/arrow/pull/7985#issuecomment-675392498 @github-actions crossbow submit verify-rc-source-* verify-rc-binaries-* verify-rc-wheels-* This is an automated

[GitHub] [arrow] kszucs opened a new pull request #7985: [WIP][Release] Verify 1.0.1 release candidate RC0

2020-08-18 Thread GitBox
kszucs opened a new pull request #7985: URL: https://github.com/apache/arrow/pull/7985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] jorisvandenbossche commented on pull request #7891: ARROW-9629: [Python] Fix kartothek integration tests by fixing dependencies

2020-08-18 Thread GitBox
jorisvandenbossche commented on pull request #7891: URL: https://github.com/apache/arrow/pull/7891#issuecomment-675350758 @fjetter Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] fjetter commented on pull request #7891: ARROW-9629: [Python] Fix kartothek integration tests by fixing dependencies

2020-08-18 Thread GitBox
fjetter commented on pull request #7891: URL: https://github.com/apache/arrow/pull/7891#issuecomment-675336307 @jorisvandenbossche We've had a few issues with pandas 1.1.0. I'll ping again once we have a compatible release. Thanks for looking into this! xref

[GitHub] [arrow] sunchao commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
sunchao commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r471972373 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r471964910 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] github-actions[bot] commented on pull request #7984: ARROW-9779: [Rust] [DataFusion] Increase stability of average accumulator

2020-08-18 Thread GitBox
github-actions[bot] commented on pull request #7984: URL: https://github.com/apache/arrow/pull/7984#issuecomment-675283219 https://issues.apache.org/jira/browse/ARROW-9779 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao opened a new pull request #7984: ARROW-9779: [Rust] [DataFusion] Increase stability of average accumulator

2020-08-18 Thread GitBox
jorgecarleitao opened a new pull request #7984: URL: https://github.com/apache/arrow/pull/7984 I benchmarked this on my computer and there is no performance change. However, my computer is prob not a good representative (MacBook Pro from 2017). This method is recommended in Knuth,

<    1   2