winningsix commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-697141258
@xieqi How about the on-disk path? How does user determine whether to use a
customized codec for a given compression codec?
github-actions[bot] commented on pull request #8244:
URL: https://github.com/apache/arrow/pull/8244#issuecomment-697136388
https://issues.apache.org/jira/browse/ARROW-8355
This is an automated message from the Apache Git
arw2019 opened a new pull request #8244:
URL: https://github.com/apache/arrow/pull/8244
xref https://github.com/apache/arrow/pull/6849#discussion_r404160096
This is a minor refactor. The changes are to replace uses of `pandas`
dataframes with `pa.Table(...)` wherever possible.
lwxown commented on issue #8137:
URL: https://github.com/apache/arrow/issues/8137#issuecomment-697134880
I also met the same problem,who can solve?
This is an automated message from the Apache Git Service.
To respond to the
xieqi commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-697120706
@pitrou
For Parquet write, the end-user still use the standard GZip as the
compression codec, we add a compression_plugin API in parquet WriterProperties
Builder, the end-user
emkornfield commented on a change in pull request #7214:
URL: https://github.com/apache/arrow/pull/7214#discussion_r493188671
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
##
@@ -844,7 +844,7 @@ public void setValueCount(int
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-697114813
Thank you all for the fruitful discussion.
One small reminder for @josiahyan : to cache the buffer capacity, it is
sufficient to use an `int` instead of a `long`
liyafan82 commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-697118857
@kiszk Thank you for doing this.
Please note that when running the benchmarks, some flags should be
configured properly.
They can be set through environmental variables:
kiszk edited a comment on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-697119568
@liyafan82 Thank you for your comment. I will set these two properties as
default for Java benchmarking
.
emkornfield closed pull request #7326:
URL: https://github.com/apache/arrow/pull/7326
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andygrove commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-697101767
This looks good to me conceptually at least. I wasn't too involved in this
part of the codebase so I think it would be best to see if @nevi-me can review.
kiszk commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-697119568
@liyafan82 Thank you for your comment. I will set these two properties as
default.
This is an automated message
emkornfield commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r493187630
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r492506544
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
kszucs commented on pull request #8238:
URL: https://github.com/apache/arrow/pull/8238#issuecomment-696697010
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sbinet commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r491881927
##
File path: go/arrow/flight/client.go
##
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
github-actions[bot] commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-696821165
https://issues.apache.org/jira/browse/ARROW-10065
This is an automated message from the Apache Git
wesm closed pull request #7789:
URL: https://github.com/apache/arrow/pull/7789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jacques-n commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696453930
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jorgecarleitao commented on a change in pull request #8236:
URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876
##
File path: rust/datafusion/src/physical_plan/merge.rs
##
@@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec {
let
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r492540735
##
File path: cpp/src/parquet/encryption/remote_kms_client.h
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
vertexclique commented on pull request #8237:
URL: https://github.com/apache/arrow/pull/8237#issuecomment-696687042
@andygrove Can I get a review for this one too? Thanks.
This is an automated message from the Apache Git
kszucs closed pull request #8228:
URL: https://github.com/apache/arrow/pull/8228
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
emkornfield commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492461706
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
xhochy closed pull request #8239:
URL: https://github.com/apache/arrow/pull/8239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jhorstmann commented on pull request #8223:
URL: https://github.com/apache/arrow/pull/8223#issuecomment-696754781
@nevi-me can you point me to the part of the parquet code that you have in
mind? I found the `BitReader` used by bit packed encoding but that seems to
solve a more general
wesm commented on pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#issuecomment-696368598
@xhochy might be the only one. I can do my best to provide some comments
This is an automated message from the
kszucs commented on pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#issuecomment-696797135
@github-actions crossbow submit test-spark
This is an automated message from the Apache Git Service.
To respond to
emkornfield commented on pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#issuecomment-696503073
@xhochy did you want to review?
This is an automated message from the Apache Git Service.
To respond to the
xhochy commented on pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#issuecomment-696610675
I reserved my self an hour tomorrow to review this. I haven't touched this
code for over a year but this is the code path that actually got me into
Arrow/Parquet project, so I'm
xhochy commented on a change in pull request #8235:
URL: https://github.com/apache/arrow/pull/8235#discussion_r492772505
##
File path: r/README.md
##
@@ -102,6 +102,43 @@ elsewhere, you’ll need to build it from source too.
First, install the C++ library. See the [developer
pitrou closed pull request #8196:
URL: https://github.com/apache/arrow/pull/8196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arw2019 commented on pull request #8145:
URL: https://github.com/apache/arrow/pull/8145#issuecomment-696882474
This is ready for re-review.
I believe that I've addressed the feedback from previous reviews. I've also
now exposed all the option classes so that all the kernels listed
bkietz commented on a change in pull request #8240:
URL: https://github.com/apache/arrow/pull/8240#discussion_r492829401
##
File path: cpp/src/arrow/util/thread_pool.cc
##
@@ -168,9 +174,11 @@ Status ThreadPool::SetCapacity(int threads) {
CollectFinishedWorkersUnlocked();
github-actions[bot] commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-696821164
https://issues.apache.org/jira/browse/ARROW-10054
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8235:
URL: https://github.com/apache/arrow/pull/8235#issuecomment-696431010
https://issues.apache.org/jira/browse/ARROW-10059
This is an automated message from the Apache Git
TheNeuralBit commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492822710
##
File path: js/test/unit/ipc/helpers.ts
##
@@ -54,13 +54,13 @@ export abstract class ArrowIOTestHelper {
await testFn(await
BatmanAoD commented on a change in pull request #3031:
URL: https://github.com/apache/arrow/pull/3031#discussion_r492955163
##
File path: rust/src/lib.rs
##
@@ -15,6 +15,8 @@
// specific language governing permissions and limitations
// under the License.
andygrove closed pull request #8237:
URL: https://github.com/apache/arrow/pull/8237
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696458726
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pitrou edited a comment on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-696630511
Need to add a test with the legacy file in
https://github.com/apache/arrow-testing/pull/47 . Edit: done (the file was
instead moved to parquet-testing).
t829702 commented on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
cyb70289 commented on a change in pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#discussion_r492543154
##
File path: cpp/src/arrow/compute/kernel.h
##
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
using ScalarAggregateConsume =
cyb70289 commented on pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#issuecomment-696485953
CI failure is about flight test. Looks not related.
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35331179/job/i7l5oi2mxnwytd4q#L1788
alamb commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-696842287
@drusso I think you are correct that we would need a separate group by
operator for each count distinct and then combine them together:
so `SELECT c1, COUNT(DISTINCT c2),
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r492648007
##
File path: cpp/src/arrow/util/converter.h
##
@@ -0,0 +1,353 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
kszucs commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-696598247
@jorgecarleitao could you rebase on top of the master? I'm unable to push to
your fork, but the build failures should be resolved after a rebase.
pitrou closed pull request #8136:
URL: https://github.com/apache/arrow/pull/8136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493036448
##
File path: js/test/inference/column.ts
##
@@ -33,33 +33,6 @@ const boolColumn = new Column(new Field('bool', boolType), [
expect(typeof
andygrove closed pull request #8233:
URL: https://github.com/apache/arrow/pull/8233
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696370510
@wesm as far as i can tell the two checks that are failing are unrelated to
this PR.
I have ideas for further exploring / adding more functionality for the
FlightRPC
drusso commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r492692158
##
File path: rust/datafusion/src/physical_plan/distinct_expressions.rs
##
@@ -0,0 +1,303 @@
+// Licensed to the Apache Software Foundation (ASF) under one
jorisvandenbossche commented on pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#issuecomment-696688370
It seems the crashing test is:
https://github.com/apache/arrow/blob/40d64756dc3b2c51489b48362d0f04ee3e2a7388/python/pyarrow/tests/test_parquet.py#L3389-L3414
pitrou commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r492627002
##
File path: cpp/src/arrow/util/compression.h
##
@@ -30,7 +30,18 @@ namespace arrow {
struct Compression {
/// \brief Compression algorithm
- enum
kszucs closed pull request #7797:
URL: https://github.com/apache/arrow/pull/7797
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on pull request #8196:
URL: https://github.com/apache/arrow/pull/8196#issuecomment-696675621
> Wow, did you report the `peer()` issue to gRPC?
Not yet - I need to reproduce it in a VM first (probably with just base gRPC
instead of trying to set up Arrow).
github-actions[bot] commented on pull request #8236:
URL: https://github.com/apache/arrow/pull/8236#issuecomment-696484939
https://issues.apache.org/jira/browse/ARROW-10060
This is an automated message from the Apache Git
nealrichardson commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697054182
Ok, with that SEMICOLON change, the Ubuntu R job successfully compiles the
C++ library, but the R package can't use it because it created a shared library
for aws-sdk-cpp
jorisvandenbossche edited a comment on pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#issuecomment-696688370
It seems the crashing test is:
wesm commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492407465
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
}
pitrou commented on pull request #8196:
URL: https://github.com/apache/arrow/pull/8196#issuecomment-696561450
Wow, did you report the `peer()` issue to gRPC?
This is an automated message from the Apache Git Service.
To
praveenbingo commented on a change in pull request #8095:
URL: https://github.com/apache/arrow/pull/8095#discussion_r492681566
##
File path: cpp/src/gandiva/to_date_holder.cc
##
@@ -47,18 +47,23 @@ Status ToDateHolder::Make(const FunctionNode& node,
}
auto pattern =
pitrou closed pull request #8234:
URL: https://github.com/apache/arrow/pull/8234
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8237:
URL: https://github.com/apache/arrow/pull/8237#issuecomment-696681860
https://issues.apache.org/jira/browse/ARROW-10062
This is an automated message from the Apache Git
pitrou commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492558115
##
File path: cpp/src/parquet/column_writer.cc
##
@@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
GPSnoopy commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r492615499
##
File path: cpp/src/arrow/util/compression.h
##
@@ -30,7 +30,18 @@ namespace arrow {
struct Compression {
/// \brief Compression algorithm
- enum
nealrichardson commented on a change in pull request #8235:
URL: https://github.com/apache/arrow/pull/8235#discussion_r492820728
##
File path: r/README.md
##
@@ -102,6 +102,43 @@ elsewhere, you’ll need to build it from source too.
First, install the C++ library. See the
jacques-n edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696459730
> I think there are two opportunities here - simply optimizing setSafe,
which can be done by either specializing for the power-of-two size where
possible, or by caching
andygrove commented on pull request #8204:
URL: https://github.com/apache/arrow/pull/8204#issuecomment-696744882
@jhorstmann Looks like there is cargo fmt issue
This is an automated message from the Apache Git Service.
To
pitrou commented on a change in pull request #8235:
URL: https://github.com/apache/arrow/pull/8235#discussion_r492536697
##
File path: r/README.md
##
@@ -102,6 +102,43 @@ elsewhere, you’ll need to build it from source too.
First, install the C++ library. See the [developer
bkietz commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r492838013
##
File path: cpp/src/arrow/array/array_list_test.cc
##
@@ -508,6 +534,8 @@ TYPED_TEST(TestListArray, ValidateOffsets) {
this->TestValidateOffsets(); }
alamb edited a comment on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-696842287
@drusso I think you are correct that we would need a separate group by
operator for each count distinct and then combine them together:
so `SELECT c1, COUNT(DISTINCT
nevi-me commented on pull request #8223:
URL: https://github.com/apache/arrow/pull/8223#issuecomment-696669012
@jhorstmann can I close this PR, and rely on your implementation when ready?
Also, do you think we'd be able to use your implementation in `parquet`, as we
might need that for
github-actions[bot] commented on pull request #8240:
URL: https://github.com/apache/arrow/pull/8240#issuecomment-696730535
https://issues.apache.org/jira/browse/ARROW-10038
This is an automated message from the Apache Git
kou commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on pull request #8239:
URL: https://github.com/apache/arrow/pull/8239#issuecomment-696702368
https://issues.apache.org/jira/browse/ARROW-10064
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697027877
https://issues.apache.org/jira/browse/ARROW-10068
This is an automated message from the Apache Git
kou edited a comment on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532
For the aws-sdk headers, the following patch will fix them:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-696593899
The methods of `ParquetFileReader` no longer use tidyselect, i.e. you can
use `$ReadTable()` or `$ReadTable(column_indices)` with an 0-based integer
vector so this does
pitrou commented on pull request #8136:
URL: https://github.com/apache/arrow/pull/8136#issuecomment-696686570
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pitrou commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-696630511
Need to add a test with the legacy file in
https://github.com/apache/arrow-testing/pull/47
This is an automated
andygrove closed pull request #8236:
URL: https://github.com/apache/arrow/pull/8236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zeroshade commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r492737156
##
File path: go/arrow/flight/client.go
##
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
wesm commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r492965387
##
File path: cpp/src/arrow/util/compression.h
##
@@ -30,7 +30,18 @@ namespace arrow {
struct Compression {
/// \brief Compression algorithm
- enum
drusso commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-696689994
Thanks for the review/feedback all!
@jorgecarleitao:
> it may be worth take a look at #8172 , where we are trying to improve how
to declare and run aggregate
github-actions[bot] commented on pull request #8238:
URL: https://github.com/apache/arrow/pull/8238#issuecomment-696690267
https://issues.apache.org/jira/browse/ARROW-10063
This is an automated message from the Apache Git
kou commented on a change in pull request #8234:
URL: https://github.com/apache/arrow/pull/8234#discussion_r492378032
##
File path: LICENSE.txt
##
@@ -849,9 +849,9 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.
nealrichardson commented on a change in pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#discussion_r492850251
##
File path: r/R/parquet.R
##
@@ -409,10 +420,20 @@ ParquetFileWriter$create <- function(schema,
#'
#' @section Methods:
#'
-#' -
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696381588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pitrou commented on a change in pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#discussion_r492540465
##
File path: cpp/src/arrow/compute/kernel.h
##
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
using ScalarAggregateConsume =
jorisvandenbossche commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r492666980
##
File path: python/pyarrow/array.pxi
##
@@ -21,28 +21,28 @@ import warnings
cdef _sequence_to_array(object sequence, object mask, object
josiahyan edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696381588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xieqi commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-697120706
@pitrou
For Parquet write, the end-user still use the standard GZip as the
compression codec, we add a compression_plugin API in parquet WriterProperties
Builder, the end-user
kiszk commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-697119568
@liyafan82 Thank you for your comment. I will set these two properties as
default.
This is an automated message
liyafan82 commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-697118857
@kiszk Thank you for doing this.
Please note that when running the benchmarks, some flags should be
configured properly.
They can be set through environmental variables:
cyb70289 commented on a change in pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#discussion_r493150346
##
File path: cpp/src/arrow/compute/kernel.h
##
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
using ScalarAggregateConsume =
nealrichardson commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697054182
Ok, with that SEMICOLON change, the Ubuntu R job successfully compiles the
C++ library, but the R package can't use it because it created a shared library
for aws-sdk-cpp
kou commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697049024
Ah, we can use `$`
https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#escaped-characters
instead of `LIST_SEPARATOR` like TileDB does:
kou edited a comment on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532
For the aws-sdk headers, the following patch will fix them:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
1 - 100 of 215 matches
Mail list logo
