Re: [PR] GH-44622: [DOCS][Python] Update `python_test.cc` reference [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44622: URL: https://github.com/apache/arrow/pull/44622#issuecomment-2452891872 :warning: GitHub issue #44622 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] [DOCS][Python] Update `python_test.cc` reference [arrow]

2024-11-01 Thread via GitHub
emmanuel-ferdman opened a new pull request, #44622: URL: https://github.com/apache/arrow/pull/44622 ### Rationale for this change Commit 21dbf4ac09583651899232c9a80b3f5d6580a588 moved the location of `python_test.cc`. ### What changes are included in this PR? PR

Re: [PR] [DOCS][Python] Update `python_test.cc` reference [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44622: URL: https://github.com/apache/arrow/pull/44622#issuecomment-2452890005 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

Re: [I] [C++] Test failures for libarrow in conda-forge [arrow]

2024-11-01 Thread via GitHub
h-vetinari commented on issue #35587: URL: https://github.com/apache/arrow/issues/35587#issuecomment-2452888609 I updated https://github.com/conda-forge/arrow-cpp-feedstock/pull/1058 for v18, opened a [PR](https://github.com/apache/arrow/pull/44621) for the failure of `TimestampParser.Strpt

Re: [PR] GH-43808: [C++] set kStrptimeSupportsZone to false for old glibc [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44621: URL: https://github.com/apache/arrow/pull/44621#issuecomment-2452887780 :warning: GitHub issue #43808 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-43808: [C++] set kStrptimeSupportsZone to false for old glibc [arrow]

2024-11-01 Thread via GitHub
h-vetinari opened a new pull request, #44621: URL: https://github.com/apache/arrow/pull/44621 ### Rationale for this change Enable tests for libarrow in conda-forge: https://github.com/apache/arrow/issues/35587 ### What changes are included in this PR? ol

Re: [PR] GH-44603: [GLib] Add GArrowDecimal64Array and GArrowDecimal64ArrayBuilder [arrow]

2024-11-01 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44605: URL: https://github.com/apache/arrow/pull/44605#issuecomment-2452885737 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 11c11a48234a7f49e0585f5762b3a6332ac7622a. There were no

Re: [PR] GH-44601: [GLib] Fix the wrong GARROW_AVAILABLE_IN declaration [arrow]

2024-11-01 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44602: URL: https://github.com/apache/arrow/pull/44602#issuecomment-2452873406 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 277df0ec4bdc0e9bc4557ce40d38fcf921396683. There was 1 b

Re: [PR] GH-44618: [GLib] Add GArrowDecimal64Scalar [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44620: URL: https://github.com/apache/arrow/pull/44620#issuecomment-2452851187 :warning: GitHub issue #44618 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-44618: [GLib] Add GArrowDecimal64Scalar [arrow]

2024-11-01 Thread via GitHub
hiroyuki-sato opened a new pull request, #44620: URL: https://github.com/apache/arrow/pull/44620 ### Rationale for this change The `arrow::Decimal64Scalar` has been released. GLib needs to implement `GArrowDecimal64Scalar`. ### What changes are included in thi

Re: [I] [C#] Consider replacing LINQ expression when accessing columns by name [arrow]

2024-11-01 Thread via GitHub
CurtHagenlocher commented on issue #44575: URL: https://github.com/apache/arrow/issues/44575#issuecomment-2452823798 Issue resolved by pull request 44576 https://github.com/apache/arrow/pull/44576 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] Fix issues identified by the cudf clang-tidy run [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot commented on issue #662: URL: https://github.com/apache/arrow-nanoarrow/issues/662#issuecomment-2452800125 Let me know if that works and/or is an acceptable solution! We could also make the public define something like `NANOARROW_CLANG_TIDY` in case we want to separate the thin

Re: [PR] GH-44604: [GLib] Add Decimal32Array [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44617: URL: https://github.com/apache/arrow/pull/44617#issuecomment-2452752750 :warning: GitHub issue #44604 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Fix issues identified by the cudf clang-tidy run [arrow-nanoarrow]

2024-11-01 Thread via GitHub
vyasr commented on issue #662: URL: https://github.com/apache/arrow-nanoarrow/issues/662#issuecomment-2452754806 Ah I see. Is `NANOARROW_DEBUG` intended to be part of the public build interface? If so, we can certainly try that for these jobs. We can't switch to a full debug build because

[PR] GH-44604: [GLib] Add Decimal32Array [arrow]

2024-11-01 Thread via GitHub
hiroyuki-sato opened a new pull request, #44617: URL: https://github.com/apache/arrow/pull/44617 ### Rationale for this change The `arrow::Decimal32Array` has been released. The `GArrowDecimal32Array` class must be implemented in the GLib. ### What changes are

Re: [I] [Java] Gandiva Tests are failing due to linking issues [arrow]

2024-11-01 Thread via GitHub
lriggs commented on issue #43576: URL: https://github.com/apache/arrow/issues/43576#issuecomment-2452735001 Hi, I work with @laurentgo at Dremio and I've started looking into this issue. Let me know if there is a better format for this discussion (email vs GH issue, etc). I wanted to summar

Re: [PR] GH-41706: [C++][Acero][Followup] Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output` [arrow]

2024-11-01 Thread via GitHub
EnricoMi commented on PR #44616: URL: https://github.com/apache/arrow/pull/44616#issuecomment-2452718109 @westonpace are you happy with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [C++][Parquet] Remove deprecated APIs [arrow]

2024-11-01 Thread via GitHub
h-vetinari commented on issue #44079: URL: https://github.com/apache/arrow/issues/44079#issuecomment-2452696643 FWIW, a number of projects in conda-forge seem to be running into failures caused by these removals. Not sure how visible the warnings were, but just FYI: - https://github.com/c

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2452666759 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f3abc6802a94a1a4202c710c236a24a137e0a0d7. There were no

Re: [I] [GLib] Add GArrowDecimal64Array [arrow]

2024-11-01 Thread via GitHub
kou commented on issue #44603: URL: https://github.com/apache/arrow/issues/44603#issuecomment-2452654851 Issue resolved by pull request 44605 https://github.com/apache/arrow/pull/44605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-44603: [GLib] Add GArrowDecimal64Array and GArrowDecimal64ArrayBuilder [arrow]

2024-11-01 Thread via GitHub
kou merged PR #44605: URL: https://github.com/apache/arrow/pull/44605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [GLib] Fix the wrong GARROW_AVAILABLE_IN declaration in GArrowDecimal64 [arrow]

2024-11-01 Thread via GitHub
kou commented on issue #44601: URL: https://github.com/apache/arrow/issues/44601#issuecomment-2452651430 Issue resolved by pull request 44602 https://github.com/apache/arrow/pull/44602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-44601: [GLib] Fix the wrong GARROW_AVAILABLE_IN declaration [arrow]

2024-11-01 Thread via GitHub
kou merged PR #44602: URL: https://github.com/apache/arrow/pull/44602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] Arrow Flight Performance -- Rust vs Python (C++) [arrow-rs]

2024-11-01 Thread via GitHub
tustvold commented on issue #6670: URL: https://github.com/apache/arrow-rs/issues/6670#issuecomment-2452611067 Perhaps you could capture a trace of the Rust server using hotspot or similar, it may show where the bottleneck is -- This is an automated message from the Apache Git Service. To

Re: [PR] chore(csharp): bump Arrow to 18.0.0 [arrow-adbc]

2024-11-01 Thread via GitHub
CurtHagenlocher merged PR #2299: URL: https://github.com/apache/arrow-adbc/pull/2299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[PR] chore(csharp): bump Arrow to 18.0.0 [arrow-adbc]

2024-11-01 Thread via GitHub
CurtHagenlocher opened a new pull request, #2299: URL: https://github.com/apache/arrow-adbc/pull/2299 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] refactor: Split up nanoarrow.hpp into multiple .hpp files [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot merged PR #668: URL: https://github.com/apache/arrow-nanoarrow/pull/668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [PR] clean: Assorted Meson and clang-tidy fixes [arrow-nanoarrow]

2024-11-01 Thread via GitHub
WillAyd commented on code in PR #673: URL: https://github.com/apache/arrow-nanoarrow/pull/673#discussion_r1826270960 ## src/nanoarrow/ipc/decoder_test.cc: ## @@ -856,14 +856,14 @@ TEST_P(ArrowTypeParameterizedTestFixture, NanoarrowIpcNanoarrowArrayRoundtrip) { EXPECT_EQ(Ar

Re: [PR] refactor: Split up nanoarrow.hpp into multiple .hpp files [arrow-nanoarrow]

2024-11-01 Thread via GitHub
WillAyd commented on code in PR #668: URL: https://github.com/apache/arrow-nanoarrow/pull/668#discussion_r1826277119 ## meson.build: ## @@ -210,7 +232,7 @@ if get_option('tests') ipc_test_files = { 'ipc-decoder': { 'src': 'decoder', -

Re: [PR] GH-41706: [C++][Acero] Enhance asof_join to work in multi-threaded execution by sequencing input [arrow]

2024-11-01 Thread via GitHub
EnricoMi commented on PR #44083: URL: https://github.com/apache/arrow/pull/44083#issuecomment-2452553750 @gitmodimo I have reworked some of this PR's changes in #44616 and added some of my code from #44470. Please have a look. -- This is an automated message from the Apache Git Service. T

Re: [PR] Fix string view LIKE checks with NULL values [arrow-rs]

2024-11-01 Thread via GitHub
findepi commented on code in PR #6662: URL: https://github.com/apache/arrow-rs/pull/6662#discussion_r1826277398 ## arrow-string/src/predicate.rs: ## @@ -116,10 +116,17 @@ impl<'a> Predicate<'a> { }), Predicate::Contains(finder) => { if

[PR] clean: Assorted Meson and clang-tidy fixes [arrow-nanoarrow]

2024-11-01 Thread via GitHub
WillAyd opened a new pull request, #673: URL: https://github.com/apache/arrow-nanoarrow/pull/673 closes https://github.com/apache/arrow-nanoarrow/issues/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] clang-tidy issue for decimal implementation [arrow-nanoarrow]

2024-11-01 Thread via GitHub
WillAyd commented on issue #672: URL: https://github.com/apache/arrow-nanoarrow/issues/672#issuecomment-2452534926 Ah I see...I think the Meson configuration is just missing that. PR coming soon -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] clang-tidy issue for decimal implementation [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot commented on issue #672: URL: https://github.com/apache/arrow-nanoarrow/issues/672#issuecomment-2452511255 ...it also should be said that the macro will only expand when `NANOARROW_DEBUG` is defined, and sometimes it can be a trick to let clang-tidy know to compile it with that

[I] Need a mechanism to handle schema changes due to dictionary hydration in FlightSQL server implementations [arrow-rs]

2024-11-01 Thread via GitHub
nathanielc opened a new issue, #6672: URL: https://github.com/apache/arrow-rs/issues/6672 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I am implementing a flight sql server using datafusion. See [this](https://github.co

Re: [I] Add possibility to extract spans/byte offsets directly for `compute.extract_regext` [arrow]

2024-11-01 Thread via GitHub
rtbs-dev commented on issue #44615: URL: https://github.com/apache/arrow/issues/44615#issuecomment-2452482292 Linking to an issue I opened with arrow-rs, which uses a rust regex implementation iirc, when I was only considering polars use-cases. But I'm now not sure how I would implement thi

Re: [I] clang-tidy issue for decimal implementation [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot commented on issue #672: URL: https://github.com/apache/arrow-nanoarrow/issues/672#issuecomment-2452480552 To get the first round to pass I added: https://github.com/apache/arrow-nanoarrow/blob/d9cc16420f932b62aa63da9e9ca7d249898742cf/src/nanoarrow/common/utils.c#L359

Re: [PR] Support `Utf8View` for string function `bit_length()` [arrow-rs]

2024-11-01 Thread via GitHub
austin362667 commented on code in PR #6671: URL: https://github.com/apache/arrow-rs/pull/6671#discussion_r1826217680 ## arrow-string/src/length.rs: ## @@ -137,6 +137,10 @@ pub fn bit_length(array: &dyn Array) -> Result { let list = array.as_string::();

Re: [I] Arrow Flight Performance -- Rust vs Python (C++) [arrow-rs]

2024-11-01 Thread via GitHub
tustvold commented on issue #6670: URL: https://github.com/apache/arrow-rs/issues/6670#issuecomment-2452421114 Just to double check, did you compile the Rust code in release mode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Fix string view LIKE checks with NULL values [arrow-rs]

2024-11-01 Thread via GitHub
tustvold commented on code in PR #6662: URL: https://github.com/apache/arrow-rs/pull/6662#discussion_r1826175583 ## arrow-string/src/predicate.rs: ## @@ -116,10 +116,17 @@ impl<'a> Predicate<'a> { }), Predicate::Contains(finder) => { if

Re: [PR] Fix string view LIKE checks with NULL values [arrow-rs]

2024-11-01 Thread via GitHub
tustvold commented on code in PR #6662: URL: https://github.com/apache/arrow-rs/pull/6662#discussion_r1826175583 ## arrow-string/src/predicate.rs: ## @@ -116,10 +116,17 @@ impl<'a> Predicate<'a> { }), Predicate::Contains(finder) => { if

Re: [PR] Support `Utf8View` for string function `bit_length()` [arrow-rs]

2024-11-01 Thread via GitHub
tustvold commented on code in PR #6671: URL: https://github.com/apache/arrow-rs/pull/6671#discussion_r1826172416 ## arrow-string/src/length.rs: ## @@ -137,6 +137,10 @@ pub fn bit_length(array: &dyn Array) -> Result { let list = array.as_string::(); Ok(b

[PR] Support `Utf8View` for string function `bit_length()` [arrow-rs]

2024-11-01 Thread via GitHub
austin362667 opened a new pull request, #6671: URL: https://github.com/apache/arrow-rs/pull/6671 # Which issue does this PR close? Closes https://github.com/apache/datafusion/issues/13195 # Rationale for this change Thanks to @jayzhan211 , he noticed following issue, arr

[I] clang-tidy issue for decimal implementation [arrow-nanoarrow]

2024-11-01 Thread via GitHub
WillAyd opened a new issue, #672: URL: https://github.com/apache/arrow-nanoarrow/issues/672 Running clang-tidy locally I get the following error: ``` /home/willayd/clones/arrow-nanoarrow/builddir/../src/nanoarrow/common/utils.c:387:32: warning: The left operand of '!=' is

[I] Arrow Flight Performance -- Rust vs Python (C++) [arrow-rs]

2024-11-01 Thread via GitHub
vichry2 opened a new issue, #6670: URL: https://github.com/apache/arrow-rs/issues/6670 **Which part is this question about** Arrow flight, FlightDataEncoderBuilder, do_get **Describe your question** Is it expected that Arrow's Python (C++) Flight implementation encodes data more

Re: [PR] feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion [arrow-adbc]

2024-11-01 Thread via GitHub
CurtHagenlocher merged PR #2296: URL: https://github.com/apache/arrow-adbc/pull/2296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion [arrow-adbc]

2024-11-01 Thread via GitHub
birschick-bq commented on code in PR #2296: URL: https://github.com/apache/arrow-adbc/pull/2296#discussion_r1826123907 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs: ## @@ -178,6 +189,18 @@ internal static Date32Array ConvertToDate32(StringArray array, IArrowType _)

Re: [PR] GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc [arrow]

2024-11-01 Thread via GitHub
assignUser commented on PR #43123: URL: https://github.com/apache/arrow/pull/43123#issuecomment-2452295686 Just for completeness sake: Yes committers can push to PRs from third parties as long as they have set the 'Maintainers are allowed to edit this pull request.' option (which is on by d

Re: [PR] GH-44606: [C++] Add find module for abseil that handles missing version [arrow]

2024-11-01 Thread via GitHub
assignUser commented on PR #44613: URL: https://github.com/apache/arrow/pull/44613#issuecomment-2452303417 I don't think another crossbow run will give us anything more than the normal PR CI. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Fix issues identified by the cudf clang-tidy run [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot commented on issue #662: URL: https://github.com/apache/arrow-nanoarrow/issues/662#issuecomment-2452251134 I was going to try to reproduce this but have discovered that a driver update seems to have borked any ability to do GPU things today :slightly_frowning_face: I see

Re: [PR] MINOR: [JS] Bump memfs from 4.9.2 to 4.12.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] commented on PR #44282: URL: https://github.com/apache/arrow/pull/44282#issuecomment-2452141578 Superseded by #44609. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [C++][regression] Error when building Arrow v18.0.0 against non-LTS absl, abseil-cpp [arrow]

2024-11-01 Thread via GitHub
assignUser commented on issue #44606: URL: https://github.com/apache/arrow/issues/44606#issuecomment-2452176375 cc @kou @raulcd > absl themselves encourage people to use cutting-edge version built from the latest commit, so it will cause problems for many Arrow consumers. Even

[PR] GH-44606: [C++] Add find module for abseil that handles missing version [arrow]

2024-11-01 Thread via GitHub
assignUser opened a new pull request, #44613: URL: https://github.com/apache/arrow/pull/44613 ### Rationale for this change Abseil's recommended usage is to build from trunk, this version does not provide a package version in CMake which breaks `resolve_dependency`. ### What change

Re: [PR] GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc [arrow]

2024-11-01 Thread via GitHub
zanmato1984 commented on PR #43123: URL: https://github.com/apache/arrow/pull/43123#issuecomment-2452193543 > Hi @flashzxi , I've created a PR in your fork [flashzxi#1](https://github.com/flashzxi/arrow/pull/1) which includes my test to reproduce the issue and verify the fix. Could you merg

Re: [PR] GH-44606: [C++] Add find module for abseil that handles missing version [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44613: URL: https://github.com/apache/arrow/pull/44613#issuecomment-2452185406 Revision: 93daa9286f70f548f6936ae8b4f4bae5569acf6c Submitted crossbow builds: [ursacomputing/crossbow @ actions-e8ea175dd2](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-44606: [C++] Add find module for abseil that handles missing version [arrow]

2024-11-01 Thread via GitHub
assignUser commented on PR #44613: URL: https://github.com/apache/arrow/pull/44613#issuecomment-2452179432 @github-actions crossbow submit -g cpp r-binary-packages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] GH-44606: [C++] Add find module for abseil that handles missing version [arrow]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #44613: URL: https://github.com/apache/arrow/pull/44613#issuecomment-2452175920 :warning: GitHub issue #44606 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list [arrow]

2024-11-01 Thread via GitHub
wgtmac commented on code in PR #43995: URL: https://github.com/apache/arrow/pull/43995#discussion_r1826026018 ## cpp/src/parquet/arrow/arrow_schema_test.cc: ## @@ -1846,7 +1953,9 @@ TEST_F(TestLevels, ListErrors) { { ::arrow::Status error = MaybeSetParquetSchema(GroupNod

Re: [PR] GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc [arrow]

2024-11-01 Thread via GitHub
mapleFU commented on PR #43123: URL: https://github.com/apache/arrow/pull/43123#issuecomment-2452154253 https://github.com/apache/arrow/pull/43123/commits/bf2aff0822764279eb6834c3346c7c4e684d0b2b Didn't you updated this successfully? -- This is an automated message from the Apache

Re: [PR] MINOR: [JS] Bump webpack from 5.91.0 to 5.95.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] commented on PR #44284: URL: https://github.com/apache/arrow/pull/44284#issuecomment-2452145536 Superseded by #44612. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: [JS] Bump webpack from 5.91.0 to 5.95.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] closed pull request #44284: MINOR: [JS] Bump webpack from 5.91.0 to 5.95.0 in /js URL: https://github.com/apache/arrow/pull/44284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] MINOR: [JS] Bump webpack from 5.91.0 to 5.96.1 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] opened a new pull request, #44612: URL: https://github.com/apache/arrow/pull/44612 Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.96.1. Release notes Sourced from https://github.com/webpack/webpack/releases";>webpack's releases. v5.96.1

[PR] MINOR: [JS] Bump tslib from 2.6.3 to 2.8.1 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] opened a new pull request, #44611: URL: https://github.com/apache/arrow/pull/44611 Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.3 to 2.8.1. Release notes Sourced from https://github.com/Microsoft/tslib/releases";>tslib's releases. v2.8.1 What

Re: [PR] MINOR: [JS] Bump tslib from 2.6.3 to 2.7.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] commented on PR #44105: URL: https://github.com/apache/arrow/pull/44105#issuecomment-2452143387 Superseded by #44611. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: [JS] Bump rollup from 4.22.4 to 4.24.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] closed pull request #44304: MINOR: [JS] Bump rollup from 4.22.4 to 4.24.0 in /js URL: https://github.com/apache/arrow/pull/44304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] MINOR: [JS] Bump tslib from 2.6.3 to 2.7.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] closed pull request #44105: MINOR: [JS] Bump tslib from 2.6.3 to 2.7.0 in /js URL: https://github.com/apache/arrow/pull/44105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: [JS] Bump rollup from 4.22.4 to 4.24.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] commented on PR #44304: URL: https://github.com/apache/arrow/pull/44304#issuecomment-2452142921 Superseded by #44610. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: [JS] Bump rollup from 4.22.4 to 4.24.3 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] opened a new pull request, #44610: URL: https://github.com/apache/arrow/pull/44610 Bumps [rollup](https://github.com/rollup/rollup) from 4.22.4 to 4.24.3. Release notes Sourced from https://github.com/rollup/rollup/releases";>rollup's releases. v4.24.3 4.24

Re: [PR] Fix string view LIKE checks with NULL values [arrow-rs]

2024-11-01 Thread via GitHub
alamb commented on code in PR #6662: URL: https://github.com/apache/arrow-rs/pull/6662#discussion_r1826003382 ## arrow-string/src/predicate.rs: ## @@ -116,10 +116,17 @@ impl<'a> Predicate<'a> { }), Predicate::Contains(finder) => { if le

Re: [PR] MINOR: [JS] Bump memfs from 4.9.2 to 4.12.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] closed pull request #44282: MINOR: [JS] Bump memfs from 4.9.2 to 4.12.0 in /js URL: https://github.com/apache/arrow/pull/44282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] MINOR: [JS] Bump memfs from 4.9.2 to 4.14.0 in /js [arrow]

2024-11-01 Thread via GitHub
dependabot[bot] opened a new pull request, #44609: URL: https://github.com/apache/arrow/pull/44609 Bumps [memfs](https://github.com/streamich/memfs) from 4.9.2 to 4.14.0. Release notes Sourced from https://github.com/streamich/memfs/releases";>memfs's releases. v4.14.0 ht

Re: [I] Define the relationship between nanoarrow and C++ [arrow-nanoarrow]

2024-11-01 Thread via GitHub
paleolimbot commented on issue #599: URL: https://github.com/apache/arrow-nanoarrow/issues/599#issuecomment-2452078248 After #668 merges I'll put together a draft PR. Maybe a better place to start would be the `Schema` wrapper since most errors that occur there are very small allocation fa

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2451970538 I think everything is done and this is ready to be approved and merged. @assignUser or @jonkeane can you take one last look and mark approval if all looks good? Thanks for the reviews! -

Re: [I] [R][CI] Add r-devel/recheck workflow for doing reverse dependency checks on CI [arrow]

2024-11-01 Thread via GitHub
amoeba commented on issue #43547: URL: https://github.com/apache/arrow/issues/43547#issuecomment-2452019272 Issue resolved by pull request 43784 https://github.com/apache/arrow/pull/43784 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba merged PR #43784: URL: https://github.com/apache/arrow/pull/43784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2452021035 Merged, thanks again for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat(go/adbc/driver/snowflake): update to the latest 1.12.0 gosnowflake driver [arrow-adbc]

2024-11-01 Thread via GitHub
zeroshade merged PR #2298: URL: https://github.com/apache/arrow-adbc/pull/2298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2451997386 Added documentation in https://github.com/apache/arrow/pull/43784/commits/5d3e2383e99c5417b07f2f2cb46d34c0c48be449. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion [arrow-adbc]

2024-11-01 Thread via GitHub
birschick-bq commented on code in PR #2296: URL: https://github.com/apache/arrow-adbc/pull/2296#discussion_r1825896102 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs: ## @@ -178,6 +189,18 @@ internal static Date32Array ConvertToDate32(StringArray array, IArrowType _)

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2451977385 Don't mind at all, that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
jonkeane commented on PR #43784: URL: https://github.com/apache/arrow/pull/43784#issuecomment-2451975733 Sorry I should have put this earlier: would you mind adding a comment about the different between `most` and `strong`? I went looking in this PR to find it (I know I could RTFM or RTFS o

Re: [PR] WIP: [R] Verify CRAN release-18.0.0-rc0 [arrow]

2024-11-01 Thread via GitHub
amoeba commented on PR #44523: URL: https://github.com/apache/arrow/pull/44523#issuecomment-2451971400 Thanks @assignUser! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
amoeba commented on code in PR #43784: URL: https://github.com/apache/arrow/pull/43784#discussion_r1825885313 ## dev/tasks/tasks.yml: ## @@ -895,6 +895,13 @@ tasks: - r-pkg__bin__macosx__big-sur-arm64__contrib__4.3__arrow_{no_rc_r_version}\.tgz - r-pkg__src__contr

Re: [PR] feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion [arrow-adbc]

2024-11-01 Thread via GitHub
CurtHagenlocher commented on code in PR #2296: URL: https://github.com/apache/arrow-adbc/pull/2296#discussion_r1825879537 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs: ## @@ -178,6 +189,18 @@ internal static Date32Array ConvertToDate32(StringArray array, IArrowType _

[PR] feat(go/adbc/driver/snowflake): update to the latest 1.12.0 gosnowflake driver [arrow-adbc]

2024-11-01 Thread via GitHub
davidhcoe opened a new pull request, #2298: URL: https://github.com/apache/arrow-adbc/pull/2298 Resolves https://github.com/apache/arrow-adbc/issues/2295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] WIP: [R] Verify CRAN release-18.0.0-rc0 [arrow]

2024-11-01 Thread via GitHub
assignUser commented on PR #44523: URL: https://github.com/apache/arrow/pull/44523#issuecomment-2451891491 @amoeba yes we can use archive.a.o if we need an older version but imo if a newer version works we should update, I will create a blocker issue for 18.0.1 -- This is an automated mes

Re: [PR] GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc [arrow]

2024-11-01 Thread via GitHub
zanmato1984 commented on PR #43123: URL: https://github.com/apache/arrow/pull/43123#issuecomment-2451847398 Hi @flashzxi , I've created a PR in your fork https://github.com/flashzxi/arrow/pull/1 which includes my test to reproduce the issue and verify the fix. Could you merge it? Thanks.

Re: [PR] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA [arrow]

2024-11-01 Thread via GitHub
jonkeane commented on code in PR #43784: URL: https://github.com/apache/arrow/pull/43784#discussion_r1825796716 ## dev/tasks/tasks.yml: ## @@ -895,6 +895,13 @@ tasks: - r-pkg__bin__macosx__big-sur-arm64__contrib__4.3__arrow_{no_rc_r_version}\.tgz - r-pkg__src__con

Re: [I] [R] CRAN packaging checklist for version 18.0.0 [arrow]

2024-11-01 Thread via GitHub
jonkeane commented on issue #44496: URL: https://github.com/apache/arrow/issues/44496#issuecomment-2451831654 I second @thisisnic on holding our release for the 18.0.1. On the positive side, aside from the mirror selection thing that Bryce found in #44523 CI looks good (the devdocs failure

Re: [I] [C++] Implement basic functionality for new Binary/Utf8View types [arrow]

2024-11-01 Thread via GitHub
kevinli1993 commented on issue #39634: URL: https://github.com/apache/arrow/issues/39634#issuecomment-2451775440 > > I'm wondering if the cast functionality will be made available in pyarrow in a later release? Or we focusing on polishing up the remaining C++ tasks first? > > Which v

Re: [PR] Faster utf8 validation [arrow-rs]

2024-11-01 Thread via GitHub
Dandandan commented on PR #6668: URL: https://github.com/apache/arrow-rs/pull/6668#issuecomment-2451775521 FWIW some other projects are using `simdutf8` as well, like polars https://github.com/pola-rs/polars/blob/main/Cargo.toml#L77 -- This is an automated message from the Apache Git Serv

Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]

2024-11-01 Thread via GitHub
zanmato1984 commented on code in PR #44584: URL: https://github.com/apache/arrow/pull/44584#discussion_r1825712880 ## cpp/src/arrow/acero/asof_join_node_test.cc: ## @@ -1731,6 +1731,33 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) { ExecBatchFromJSON({int64(), utf8()}, R

Re: [PR] GH-41706: [C++][Acero] Enhance asof_join to work in multi-threaded execution by sequencing input [arrow]

2024-11-01 Thread via GitHub
gitmodimo commented on code in PR #44083: URL: https://github.com/apache/arrow/pull/44083#discussion_r1825726301 ## cpp/src/arrow/acero/source_node.cc: ## @@ -406,7 +407,7 @@ struct SchemaSourceNode : public SourceNode { struct RecordBatchReaderSourceNode : public SourceNode {

Re: [PR] GH-44555: [C++][Compute] Allow casting struct to bigger nullable struct [arrow]

2024-11-01 Thread via GitHub
Tom-Newton commented on code in PR #44587: URL: https://github.com/apache/arrow/pull/44587#discussion_r1825696951 ## cpp/src/arrow/dataset/scanner_test.cc: ## @@ -2328,7 +2328,7 @@ DatasetAndBatches MakeNestedDataset() { field("b", boolean()), field("c", struct_({

Re: [PR] GH-44590: [C++] Add `const` and `&` to `arrow::Array::statistics()` return type [arrow]

2024-11-01 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44592: URL: https://github.com/apache/arrow/pull/44592#issuecomment-2451437779 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e1fa7e5fb257fa9f83ffcc531efda8a4489b2961. There were no

Re: [PR] GH-41706: [C++][Acero] Enhance asof_join to work in multi-threaded execution by sequencing input [arrow]

2024-11-01 Thread via GitHub
EnricoMi commented on code in PR #44083: URL: https://github.com/apache/arrow/pull/44083#discussion_r1825495207 ## cpp/src/arrow/acero/source_node.cc: ## @@ -406,7 +407,7 @@ struct SchemaSourceNode : public SourceNode { struct RecordBatchReaderSourceNode : public SourceNode {