Re: [PR] ci: make token available when verifying binaries [arrow-adbc]

2024-11-06 Thread via GitHub
lidavidm merged PR #2308: URL: https://github.com/apache/arrow-adbc/pull/2308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-44667: [Archery] Suppress pull/push progress logs [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44669: URL: https://github.com/apache/arrow/pull/44669#issuecomment-2461526762 Revision: 30ff1a4375ea82a20945b3bffadc68bb4ca7d29c Submitted crossbow builds: [ursacomputing/crossbow @ actions-76ade52013](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-44667: [Archery] Suppress pull/push progress logs [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44669: URL: https://github.com/apache/arrow/pull/44669#issuecomment-2461522850 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-44667: [Archery] Suppress pull/push progress logs [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44669: URL: https://github.com/apache/arrow/pull/44669#issuecomment-2461523459 :warning: GitHub issue #44667 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-44667: [Archery] Suppress pull/push progress logs [arrow]

2024-11-06 Thread via GitHub
kou opened a new pull request, #44669: URL: https://github.com/apache/arrow/pull/44669 ### Rationale for this change They are useless and noisy in CI log. ### What changes are included in this PR? Add the `--quiet` option to `docker pull`/`docker push`. ### Are the

Re: [I] [Python][Packaging] Remove numpy required dependency from conda-forge packaging for PyArrow [arrow]

2024-11-06 Thread via GitHub
jorisvandenbossche commented on issue #44653: URL: https://github.com/apache/arrow/issues/44653#issuecomment-2461511515 One question here is if we remove numpy from all conda-forge outputs, or only from `pyarrow-core` ? -- This is an automated message from the Apache Git Service. To respo

Re: [I] python: add a package for bigquery plugin [arrow-adbc]

2024-11-06 Thread via GitHub
josevalim commented on issue #2110: URL: https://github.com/apache/arrow-adbc/issues/2110#issuecomment-2461485900 Hi @lidavidm, thank you for the new release candidate. Just to follow up on this one, I did not see the bigquery wheel package on the release page: https://github.com/apache/arr

Re: [I] Optimize take/filter from multiple input arrays to a single large output array [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on issue #6692: URL: https://github.com/apache/arrow-rs/issues/6692#issuecomment-2461447598 Not sure about other type but for StringView, I can only think of iterating all the filtered row and `append_value` one by one. If there is no optimization we can do, I think we

Re: [PR] MINOR: [Release] Support GitHub token in download_rc_binaries.py [arrow]

2024-11-06 Thread via GitHub
kou merged PR #44666: URL: https://github.com/apache/arrow/pull/44666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[PR] MINOR: [Release] Support GitHub token in download_rc_binaries.py [arrow]

2024-11-06 Thread via GitHub
lidavidm opened a new pull request, #44666: URL: https://github.com/apache/arrow/pull/44666 ### Rationale for this change See apache/arrow-adbc#2307. This script is getting rate-limited on GitHub Actions. ### What changes are included in this PR? Pick up GH_TOKEN if it e

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461368752 Revision: 68c2f4536912ae3716ce66eb6bd5cc8a7f96412b Submitted crossbow builds: [ursacomputing/crossbow @ actions-615a598afe](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461362482 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-44393: [C++][Compute] Placement vector functions [arrow]

2024-11-06 Thread via GitHub
zanmato1984 commented on PR #44394: URL: https://github.com/apache/arrow/pull/44394#issuecomment-2461350166 Hi @felipecrv , the renaming is done. Would you like to proceed with the review? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Optimize take/filter from multiple input arrays to a single large output array [arrow-rs]

2024-11-06 Thread via GitHub
tustvold commented on issue #6692: URL: https://github.com/apache/arrow-rs/issues/6692#issuecomment-2461304304 I think the idea is sound in principle, but needs a concrete API proposal. I'm not sure the proposed builder API makes sense, as the typing for nested types like ListBuilder

Re: [PR] GH-40488: [Swift] Add simple get swift example [arrow-experiments]

2024-11-06 Thread via GitHub
abandy commented on PR #41: URL: https://github.com/apache/arrow-experiments/pull/41#issuecomment-2461211733 > Thanks for doing this @abandy! > > ~Could you please remove the vendored Arrow package and set up `Package.swift` to install it from a URL?~ Edit: I see that this is not pos

Re: [I] [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou commented on issue #44656: URL: https://github.com/apache/arrow/issues/44656#issuecomment-2461203566 Issue resolved by pull request 44659 https://github.com/apache/arrow/pull/44659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou merged PR #44659: URL: https://github.com/apache/arrow/pull/44659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831951051 ## c_glib/arrow-glib/type.h: ## @@ -70,6 +70,8 @@ G_BEGIN_DECLS * @GARROW_TYPE_LARGE_LIST: A list of some logical data type with 64-bit offsets. * @GARROW_TYPE_MONTH_D

Re: [I] Optimize take/filter from multiple input arrays to a single large output array [arrow-rs]

2024-11-06 Thread via GitHub
devanbenz commented on issue #6692: URL: https://github.com/apache/arrow-rs/issues/6692#issuecomment-2461147087 @alamb just to clarify your idea is to modify the existing `take` & `filter` kernels. Not create a new one right? -- This is an automated message from the Apache Git Service. T

Re: [I] Optimize take/filter from multiple input arrays to a single large output array [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on issue #6692: URL: https://github.com/apache/arrow-rs/issues/6692#issuecomment-2461151884 > @alamb just to clarify your idea is to modify the existing `take` & `filter` kernels. Not create a new one right? If creating a new one helps, no reason not to do it.

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461134785 Revision: 881899948a769ddfe7f9019b9cb6d9aa9d015eda Submitted crossbow builds: [ursacomputing/crossbow @ actions-2a7277a14b](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461132807 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
hiroyuki-sato commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831894502 ## c_glib/arrow-glib/type.h: ## @@ -116,7 +118,10 @@ typedef enum { GARROW_TYPE_LARGE_LIST, GARROW_TYPE_MONTH_DAY_NANO_INTERVAL, GARROW_TYPE_RUN_END_ENCO

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461110748 Revision: 5a7981a9ae73df2e10760b0452b48f07ea3713a8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c9231388ac](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461108551 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461098437 Revision: d865f52e2750a629acc898839028b74f8ef0a161 Submitted crossbow builds: [ursacomputing/crossbow @ actions-7cfd1d2a87](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [Docs][Python] Update `python_test.cc` reference [arrow]

2024-11-06 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44622: URL: https://github.com/apache/arrow/pull/44622#issuecomment-2461097615 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9b27f42e02d9c4208698a324357cafaaa3e308ce. There were no

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461096260 @github-actions crossbow submit wheel-macos-monterey-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-43808: [C++] skip `-0117` in StrptimeZoneOffset for old glibc [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44621: URL: https://github.com/apache/arrow/pull/44621#issuecomment-2461095564 :warning: GitHub issue #43808 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-43808: [C++] skip `-0117` in StrptimeZoneOffset for old glibc [arrow]

2024-11-06 Thread via GitHub
h-vetinari commented on PR #44621: URL: https://github.com/apache/arrow/pull/44621#issuecomment-2461095702 > If so, we should set `kStrptimeSupportsZone` to `true` for the glibc. You're right, that existing skip was a red herring. I think the only issue is with the `-0117` timezone.

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
hiroyuki-sato commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831894041 ## c_glib/arrow-glib/basic-data-type.h: ## @@ -418,6 +418,22 @@ struct _GArrowTemporalDataTypeClass GArrowFixedWidthDataTypeClass parent_class; }; +#define

Re: [I] [Java] MapVector written data does not meet expectations [arrow]

2024-11-06 Thread via GitHub
hawk9821 commented on issue #44664: URL: https://github.com/apache/arrow/issues/44664#issuecomment-2461088407 > I think this belongs on apache/arrow and not apache/arrow-adbc? yes , here are the dependencies ``` org.apache.arrow arrow-vecto

Re: [PR] GH-43631: [C][Format] Add ArrowAsyncDeviceStreamHandler interface [arrow]

2024-11-06 Thread via GitHub
bkietz commented on PR #43632: URL: https://github.com/apache/arrow/pull/43632#issuecomment-2461021652 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] [Java] MapVector written data does not meet expectations [arrow-adbc]

2024-11-06 Thread via GitHub
lidavidm commented on issue #2306: URL: https://github.com/apache/arrow-adbc/issues/2306#issuecomment-2460952925 I think this belongs on apache/arrow and not apache/arrow-adbc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] Speed up [arrow-rs]

2024-11-06 Thread via GitHub
Dandandan opened a new pull request, #6699: URL: https://github.com/apache/arrow-rs/pull/6699 # Which issue does this PR close? ``` filter context string (kept 1/2) time: [385.65 µs 394.58 µs 405.71 µs] change: [-52.835% -5

Re: [PR] GH-44657: [CI][Dev] Add write permission to the crossbow comment bot [arrow]

2024-11-06 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44658: URL: https://github.com/apache/arrow/pull/44658#issuecomment-2460909197 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbda6b1e1322c5a9b8c107a03343d18b759694c1. There were no

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460880375 Revision: 00a007f8fce89c716bf8ed65746c61cbf83cff8d Submitted crossbow builds: [ursacomputing/crossbow @ actions-4a3af5f17f](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460877053 @github-actions crossbow submit wheel-manylinux-2014-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-44010: [C++] Add `arrow::RecordBatch::MakeStatisticsArray()` [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44252: URL: https://github.com/apache/arrow/pull/44252#discussion_r1831764065 ## cpp/src/arrow/array/statistics.h: ## @@ -34,6 +35,22 @@ namespace arrow { struct ARROW_EXPORT ArrayStatistics { using ValueType = std::variant; + static const std

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460857286 Revision: 00a007f8fce89c716bf8ed65746c61cbf83cff8d Submitted crossbow builds: [ursacomputing/crossbow @ actions-a8277982cb](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460853995 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831714365 ## c_glib/arrow-glib/basic-data-type.h: ## @@ -418,6 +418,22 @@ struct _GArrowTemporalDataTypeClass GArrowFixedWidthDataTypeClass parent_class; }; +#define GARROW_TYP

Re: [PR] GH-44657: [CI][Dev] Add write permission to the crossbow comment bot [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44658: URL: https://github.com/apache/arrow/pull/44658#issuecomment-2460796731 No problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831715971 ## c_glib/arrow-glib/type.h: ## @@ -116,7 +118,10 @@ typedef enum { GARROW_TYPE_LARGE_LIST, GARROW_TYPE_MONTH_DAY_NANO_INTERVAL, GARROW_TYPE_RUN_END_ENCODED, - /*

Re: [I] [C++][Parquet] lz4-hadoop doesn't support block compression [arrow]

2024-11-06 Thread via GitHub
nanoric commented on issue #43745: URL: https://github.com/apache/arrow/issues/43745#issuecomment-2460792489 But which format refers to LZ4_RAW? It sesms there is only LZ4, LZ4_FRAME, LZ4_HADOOP: https://github.com/apache/arrow/blob/9b27f42e02d9c4208698a324357cafaaa3e308ce/cpp/src/arro

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460769334 Revision: db1c666da549a2920b1c11389f67ed66beab5b7a Submitted crossbow builds: [ursacomputing/crossbow @ actions-3ad2ff1cde](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460765348 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460748552 Revision: 0378e7997944e20d36213f6772d2528fa8eb0267 Submitted crossbow builds: [ursacomputing/crossbow @ actions-8d57352c40](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460744530 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [Format][Docs] Describe C device interface on C data interface and C stream interface docs pages [arrow]

2024-11-06 Thread via GitHub
ianmcook commented on issue #44535: URL: https://github.com/apache/arrow/issues/44535#issuecomment-2460661390 > we should be careful about the wording Agreed, thanks @jorisvandenbossche > ... we should consolidate the C data interface / C stream interface pages ... keeping them se

Re: [I] [Python][Packaging] Remove numpy required dependency from conda-forge packaging for PyArrow [arrow]

2024-11-06 Thread via GitHub
amoeba commented on issue #44653: URL: https://github.com/apache/arrow/issues/44653#issuecomment-2460517051 As discussed on Zulip, we may retroactively update the conda-forge packages for v18.0.0, see work in https://github.com/conda-forge/pyarrow-feedstock/pull/138. We should evaluate whe

Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459487806 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] check sign_payload instead of skip_signature before computing checksum [arrow-rs]

2024-11-06 Thread via GitHub
mherrerarendon opened a new pull request, #6698: URL: https://github.com/apache/arrow-rs/pull/6698 # Which issue does this PR close? Closes #6697 # What changes are included in this PR? Checks for `sign_payload` instead of `!skip_signature` before generating the payload checksum

Re: [I] `with_unsigned_payload` shouldn't generate payload hash [arrow-rs]

2024-11-06 Thread via GitHub
mherrerarendon commented on issue #6697: URL: https://github.com/apache/arrow-rs/issues/6697#issuecomment-2460440678 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] `with_unsigned_payload` shouldn't generate payload hash [arrow-rs]

2024-11-06 Thread via GitHub
mherrerarendon opened a new issue, #6697: URL: https://github.com/apache/arrow-rs/issues/6697 **Describe the bug** The AWS S3 variant of the interface has an option to do an unsigned payload, which should skip computing the payload checksum. However, in reality, the checksum is computed

Re: [PR] GH-43631: [C][Format] Add ArrowAsyncDeviceStreamHandler interface [arrow]

2024-11-06 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #43632: URL: https://github.com/apache/arrow/pull/43632#issuecomment-2460386224 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 40b2fca4742e2692a917755fd8db2939e10fa02d. There were no

Re: [PR] ARROW-15735: [C++] Hash aggregate functions to return first and last value from a group. [arrow]

2024-11-06 Thread via GitHub
nealrichardson closed pull request #15159: ARROW-15735: [C++] Hash aggregate functions to return first and last value from a group. URL: https://github.com/apache/arrow/pull/15159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] [Format][Docs] Describe C device interface on C data interface and C stream interface docs pages [arrow]

2024-11-06 Thread via GitHub
jorisvandenbossche commented on issue #44535: URL: https://github.com/apache/arrow/issues/44535#issuecomment-2460319439 > The note boxes should clearly state that the CPU-only C data/stream interfaces are in "maintenance mode." I think we should be careful about the wording, so it is

Re: [PR] MINOR: [Docs][Python] Update `python_test.cc` reference [arrow]

2024-11-06 Thread via GitHub
jorisvandenbossche merged PR #44622: URL: https://github.com/apache/arrow/pull/44622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: Bump github.com/substrait-io/substrait-go from 1.1.0 to 1.2.0 [arrow-go]

2024-11-06 Thread via GitHub
zeroshade merged PR #183: URL: https://github.com/apache/arrow-go/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [PR] GH-44464: [C++] Added rvalue-reference-qualified overload for arrow::Result::status() returning value instead of reference [arrow]

2024-11-06 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44477: URL: https://github.com/apache/arrow/pull/44477#issuecomment-2460261475 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6decf1cca077488ec58aadd5a0a43408342ab612. There were no

Re: [I] Fuzz tests for Arrow/Parquet [arrow-rs]

2024-11-06 Thread via GitHub
jp0317 commented on issue #5332: URL: https://github.com/apache/arrow-rs/issues/5332#issuecomment-2460195372 > not panicking for a bunch of seemingly random kernel computations (esp. in the DataFusion context) is hard to avoid, i agree that it's tricky to fully eliminate panics, tho

Re: [PR] GH-40488: [Swift] Add simple get swift example [arrow-experiments]

2024-11-06 Thread via GitHub
ianmcook commented on PR #41: URL: https://github.com/apache/arrow-experiments/pull/41#issuecomment-2460084963 Thanks for doing this @abandy! Could you please remove the vendored Arrow package and set up `Package.swift` to install it from a URL? Could you also please add me (`i

Re: [PR] GH-40488: [Swift] Add simple get swift example [arrow-experiments]

2024-11-06 Thread via GitHub
ianmcook commented on PR #41: URL: https://github.com/apache/arrow-experiments/pull/41#issuecomment-2460115630 @abandy Here's a workaround that I think is better than vendoring the full Swift package here: We can just provide instructions in a readme file for how to install it locally by ru

Re: [PR] GH-40488: [Swift] Add simple get swift example [arrow-experiments]

2024-11-06 Thread via GitHub
ianmcook commented on PR #41: URL: https://github.com/apache/arrow-experiments/pull/41#issuecomment-2460102600 > Could you please remove the vendored Arrow package and set up `Package.swift` to install it from a URL? Oh, I see now that this might not be possible, as discussed at http

Re: [I] Documentation: C API reference missing information [arrow-nanoarrow]

2024-11-06 Thread via GitHub
paleolimbot commented on issue #676: URL: https://github.com/apache/arrow-nanoarrow/issues/676#issuecomment-2460073282 Thank you for reporting! That was definitely unintentional. We shuffled some of the files around and the one containing the definitions for those (src/nanoarrow/common/typ

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1830759019 ## c_glib/arrow-glib/basic-data-type.cpp: ## @@ -813,6 +815,35 @@ garrow_binary_data_type_new(void) return data_type; } +G_DEFINE_TYPE(GArrowBinaryViewDataType, +

[I] Documentation: C API reference missing information [arrow-nanoarrow]

2024-11-06 Thread via GitHub
stephen-a-stc opened a new issue, #676: URL: https://github.com/apache/arrow-nanoarrow/issues/676 This issue refers to the documentation hosted here: https://arrow.apache.org/nanoarrow/0.6.0/reference/c.html#arrow-c-data-interface The C API reference documentation for version `0.6.0`

Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459505051 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Minor: fix misleading comment in byte view [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 merged PR #6695: URL: https://github.com/apache/arrow-rs/pull/6695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-44501: [C#] Use an index lookup for `O(1)` field index access [arrow]

2024-11-06 Thread via GitHub
CurtHagenlocher commented on PR #44633: URL: https://github.com/apache/arrow/pull/44633#issuecomment-2459646525 I'm a bit tied up with work but will look at this by Friday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]

2024-11-06 Thread via GitHub
kou commented on code in PR #44584: URL: https://github.com/apache/arrow/pull/44584#discussion_r1830744719 ## cpp/src/arrow/acero/asof_join_node_test.cc: ## @@ -1732,5 +1732,37 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) { AssertExecBatchesEqualIgnoringOrder(result.schema,

Re: [I] [CI][Dev] `crossbow submit` can't write a comment to the target PR [arrow]

2024-11-06 Thread via GitHub
assignUser commented on issue #44657: URL: https://github.com/apache/arrow/issues/44657#issuecomment-2459940950 Issue resolved by pull request 44658 https://github.com/apache/arrow/pull/44658 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
hiroyuki-sato commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1830903587 ## c_glib/arrow-glib/basic-data-type.h: ## @@ -418,6 +418,22 @@ struct _GArrowTemporalDataTypeClass GArrowFixedWidthDataTypeClass parent_class; }; +#define

Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459455328 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-44657: [CI][Dev] Add write permission to the crossbow comment bot [arrow]

2024-11-06 Thread via GitHub
assignUser merged PR #44658: URL: https://github.com/apache/arrow/pull/44658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.ap

[I] Speed up `BitIndexIterator` by unrolling [arrow-rs]

2024-11-06 Thread via GitHub
Dandandan opened a new issue, #6696: URL: https://github.com/apache/arrow-rs/issues/6696 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** `BitIndexIterator` is critical to performance of lots of kernels (filter / take and anything

Re: [I] [JavaScript] Can't create table if it contains an array of strings ("Unable to infer Vector type") [arrow]

2024-11-06 Thread via GitHub
timspro commented on issue #44136: URL: https://github.com/apache/arrow/issues/44136#issuecomment-2459561114 I did ultimately figure out a workaround for this: https://github.com/kylebarron/parquet-wasm/issues/606. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Support Duration in JSON Reader [arrow-rs]

2024-11-06 Thread via GitHub
simonvandel commented on PR #6683: URL: https://github.com/apache/arrow-rs/pull/6683#issuecomment-2459896017 I tried pyarrow here: https://gist.github.com/simonvandel/ff420a412cc9a34d95a23086ecec3b15 using `uv run python hello.py` It seems like duration is not supported: ``` py

Re: [I] [IPC] Expose `schema` on `StreamDecoder` [arrow-rs]

2024-11-06 Thread via GitHub
fsdvh commented on issue #6420: URL: https://github.com/apache/arrow-rs/issues/6420#issuecomment-2459832778 Also interested in this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #44659: URL: https://github.com/apache/arrow/pull/44659#issuecomment-2459192097 :warning: GitHub issue #44656 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]

2024-11-06 Thread via GitHub
kou commented on PR #44644: URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459470048 @github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [C++] Hash aggregate functions to return first and last value from a group. [arrow]

2024-11-06 Thread via GitHub
nealrichardson commented on issue #31183: URL: https://github.com/apache/arrow/issues/31183#issuecomment-2459723995 Done in #34912. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] ARROW-15735: [C++] Hash aggregate functions to return first and last value from a group. [arrow]

2024-11-06 Thread via GitHub
nealrichardson commented on PR #15159: URL: https://github.com/apache/arrow/pull/15159#issuecomment-2459723160 Looks like #34912 achieved this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] GH-44656: [GLib] Add GArrowBinaryViewDataType [arrow]

2024-11-06 Thread via GitHub
hiroyuki-sato opened a new pull request, #44659: URL: https://github.com/apache/arrow/pull/44659 ### Rationale for this change The `arrow::BinaryViewType` has been introduced. GLib needs to be implemented as the `GArrowBinaryViewDataType`. ### What changes are

Re: [PR] Let std::fmt::Debug for StructArray output Null/Validity info [arrow-rs]

2024-11-06 Thread via GitHub
tustvold merged PR #6655: URL: https://github.com/apache/arrow-rs/pull/6655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [PR] Support Duration in JSON Reader [arrow-rs]

2024-11-06 Thread via GitHub
tustvold commented on PR #6683: URL: https://github.com/apache/arrow-rs/pull/6683#issuecomment-2459169977 > Do you think the current PR can be merged as-is I don't think we should merge this if it isn't consistent with other implementations -- This is an automated message from the

Re: [PR] Minor: fix misleading comment in byte view [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on code in PR #6695: URL: https://github.com/apache/arrow-rs/pull/6695#discussion_r1830703463 ## arrow-array/src/cast.rs: ## @@ -778,34 +778,34 @@ pub trait AsArray: private::Sealed { self.as_bytes_opt().expect("binary array") } -/// Down

Re: [PR] Minor: fix misleading comment in byte view [arrow-rs]

2024-11-06 Thread via GitHub
tustvold commented on code in PR #6695: URL: https://github.com/apache/arrow-rs/pull/6695#discussion_r1830701744 ## arrow-array/src/cast.rs: ## @@ -778,34 +778,34 @@ pub trait AsArray: private::Sealed { self.as_bytes_opt().expect("binary array") } -/// Downca

Re: [PR] Reimplement `PartialEq` of `GenericByteViewArray` compares by logical value [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on PR #6689: URL: https://github.com/apache/arrow-rs/pull/6689#issuecomment-2459168041 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] minor fix on checking index [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on PR #6694: URL: https://github.com/apache/arrow-rs/pull/6694#issuecomment-2459167276 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Reimplement `PartialEq` of `GenericByteViewArray` compares by logical value [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 merged PR #6689: URL: https://github.com/apache/arrow-rs/pull/6689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 closed issue #6679: `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value URL: https://github.com/apache/arrow-rs/issues/6679 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [JavaScript] Can't create table if it contains an array of strings ("Unable to infer Vector type") [arrow]

2024-11-06 Thread via GitHub
chrsan commented on issue #44136: URL: https://github.com/apache/arrow/issues/44136#issuecomment-2459145056 I just stumbled upon this. I can't really wrap my head around why the `id` is included when using the `is` operator since a new `id` is generated in the `Dictionary` constructor of on

Re: [PR] GH-43631: [C][Format] Add ArrowAsyncDeviceStreamHandler interface [arrow]

2024-11-06 Thread via GitHub
zeroshade merged PR #43632: URL: https://github.com/apache/arrow/pull/43632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [I] [Format][C] Add ArrowAsyncDeviceStreamHandler to C Data Interface [arrow]

2024-11-06 Thread via GitHub
zeroshade commented on issue #43631: URL: https://github.com/apache/arrow/issues/43631#issuecomment-2459153795 Issue resolved by pull request 43632 https://github.com/apache/arrow/pull/43632 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Minor: fix misleading comment in byte view [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 commented on PR #6695: URL: https://github.com/apache/arrow-rs/pull/6695#issuecomment-2459146693 Tiny fix, I think we don't need review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] parquet from_thrift_helper incorrectly checks index [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 closed issue #6693: parquet from_thrift_helper incorrectly checks index URL: https://github.com/apache/arrow-rs/issues/6693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] minor fix on checking index [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 merged PR #6694: URL: https://github.com/apache/arrow-rs/pull/6694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[PR] Minor: fix misleading comment in byte view [arrow-rs]

2024-11-06 Thread via GitHub
jayzhan211 opened a new pull request, #6695: URL: https://github.com/apache/arrow-rs/pull/6695 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

  1   2   >