[I] object_store returns an error when other compression features are enabled in reqwest [arrow-rs]

2025-02-15 Thread via GitHub
kylewlacy opened a new issue, #7142: URL: https://github.com/apache/arrow-rs/issues/7142 **Describe the bug** #6842 describes the problems that occur when the optional `gzip` feature is enabled in reqwest. The fix in #6843 addressed this by calling the [`reqwest::ClientBuilder.no_gzi

Re: [PR] GH-45508: [CI][R] Remove Ubuntu version from sanitizer jobs [arrow]

2025-02-15 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45509: URL: https://github.com/apache/arrow/pull/45509#issuecomment-2661296624 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4e65a94092cf81eb0ea9378e9bf9a35176fe5e94. There were no

Re: [PR] GH-45537: [CI][C++] Add missing includes (iwyu) to file_skyhook.cc [arrow]

2025-02-15 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45538: URL: https://github.com/apache/arrow/pull/45538#issuecomment-2661295700 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 71e214c0736be24124d134ed5f784eeb085612bf. There were no

Re: [PR] `Date` data types can cast to a time zone-specific timestamp [arrow-rs]

2025-02-15 Thread via GitHub
friendlymatthew commented on code in PR #7141: URL: https://github.com/apache/arrow-rs/pull/7141#discussion_r1957243281 ## arrow-cast/src/cast/mod.rs: ## @@ -5217,6 +5228,52 @@ mod tests { }}; } +#[test] +fn test_cast_date64_to_timestamp_with_timezone() {

[PR] `Date` data types can cast to a time zone-specific timestamp [arrow-rs]

2025-02-15 Thread via GitHub
friendlymatthew opened a new pull request, #7141: URL: https://github.com/apache/arrow-rs/pull/7141 Closes #7140. Related: https://github.com/apache/datafusion/issues/14638 Currently, you can only cast `Date32`/`Date64` into a `Timestamp` without a time zone. This commit updates the c

Re: [PR] feat(csharp/src/Drivers/BigQuery): add support for net472 [arrow-adbc]

2025-02-15 Thread via GitHub
CurtHagenlocher merged PR #2527: URL: https://github.com/apache/arrow-adbc/pull/2527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[PR] docs: update java quickstart to use the PARAM_URI instead of the legacy PARAM_URL [arrow-adbc]

2025-02-15 Thread via GitHub
shuozel opened a new pull request, #2530: URL: https://github.com/apache/arrow-adbc/pull/2530 Fixes #2528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] docs: update java quickstart to use the PARAM_URI instead of the legacy PARAM_URL [arrow-adbc]

2025-02-15 Thread via GitHub
shuozel closed pull request #2529: docs: update java quickstart to use the PARAM_URI instead of the legacy PARAM_URL URL: https://github.com/apache/arrow-adbc/pull/2529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
github-actions[bot] commented on PR #45542: URL: https://github.com/apache/arrow/pull/45542#issuecomment-2661183212 Revision: eac5d11f20a9aff66d9f5a678407587f091f22eb Submitted crossbow builds: [ursacomputing/crossbow @ actions-16ee689b85](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
hiroyuki-sato commented on PR #45542: URL: https://github.com/apache/arrow/pull/45542#issuecomment-2661182552 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]

2025-02-15 Thread via GitHub
kou commented on PR #595: URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2661182430 Ah, we need to expire a cache when we change vcpkg version. Could you try this? ```diff diff --git a/compose.yaml b/compose.yaml index 58a19676..b125c3c9 100644 --- a/compose.

Re: [PR] GH-45540: [Docs][C++] Adding some more Functions to API docs [arrow]

2025-02-15 Thread via GitHub
github-actions[bot] commented on PR #45539: URL: https://github.com/apache/arrow/pull/45539#issuecomment-2661180166 :warning: GitHub issue #45540 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] Update java quickstart to use the PARAM_URI instead of the legacy PARAM_URL [arrow-adbc]

2025-02-15 Thread via GitHub
shuozel opened a new pull request, #2529: URL: https://github.com/apache/arrow-adbc/pull/2529 Fixes #2528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] [CI][R] Lint failure [arrow]

2025-02-15 Thread via GitHub
kou commented on issue #45521: URL: https://github.com/apache/arrow/issues/45521#issuecomment-2661173632 Issue resolved by pull request 45524 https://github.com/apache/arrow/pull/45524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-45521: [CI][Dev][R] Install required cyclocomp package to be used with R lintr [arrow]

2025-02-15 Thread via GitHub
kou merged PR #45524: URL: https://github.com/apache/arrow/pull/45524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-45505: [CI][R] Use Ubuntu 22.04 instead of 20.04 for nightly jobs [arrow]

2025-02-15 Thread via GitHub
kou commented on PR #45507: URL: https://github.com/apache/arrow/pull/45507#issuecomment-2661167466 We can use Ubuntu 20.04 for 1.0.0-3.0.0 but we need to remove them eventually because Ubuntu 20.04 will reach EOL. Should we keep 1.0.0-3.0.0 while we don't get any error with Ubuntu 20

Re: [PR] GH-45505: [CI][R] Use Ubuntu 22.04 instead of 20.04 for nightly jobs [arrow]

2025-02-15 Thread via GitHub
kou commented on code in PR #45507: URL: https://github.com/apache/arrow/pull/45507#discussion_r1957216096 ## dev/tasks/r/github.linux.arrow.version.back.compat.yml: ## @@ -89,7 +89,7 @@ jobs: - { old_arrow_version: '1.0.1', r: '4.0' } env: ARROW_R_DEV: "TRU

Re: [I] [CI][R] Remove Ubuntu versions from sanitizer jobs [arrow]

2025-02-15 Thread via GitHub
kou commented on issue #45508: URL: https://github.com/apache/arrow/issues/45508#issuecomment-2661166237 Issue resolved by pull request 45509 https://github.com/apache/arrow/pull/45509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-45508: [CI][R] Remove Ubuntu version from sanitizer jobs [arrow]

2025-02-15 Thread via GitHub
kou merged PR #45509: URL: https://github.com/apache/arrow/pull/45509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [CI][C++] test-skyhook-integration fails on nightly jobs [arrow]

2025-02-15 Thread via GitHub
kou commented on issue #45537: URL: https://github.com/apache/arrow/issues/45537#issuecomment-2661164402 Issue resolved by pull request 45538 https://github.com/apache/arrow/pull/45538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-45537: [CI][C++] Add missing includes (iwyu) to file_skyhook.cc [arrow]

2025-02-15 Thread via GitHub
kou merged PR #45538: URL: https://github.com/apache/arrow/pull/45538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[I] Support casting `Date32`/`Date64` to time zone aware `Timestamp`s. [arrow-rs]

2025-02-15 Thread via GitHub
friendlymatthew opened a new issue, #7140: URL: https://github.com/apache/arrow-rs/issues/7140 The `Date` data types can cast to a `Timestamp`, as long as no time zone is specified. But you can't cast into a timezone aware timestamp. For example: ```bash > select to_char(arrow_

Re: [PR] Avro codec enhancements + Avro Reader [arrow-rs]

2025-02-15 Thread via GitHub
jecsand838 commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2661149042 @tustvold @alamb I have removed all changes and functionality not related to Avro reader type support and `.avro` file tests. Based on the plan outlined above, this should strictly al

Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

2025-02-15 Thread via GitHub
gstvg commented on code in PR #7103: URL: https://github.com/apache/arrow-rs/pull/7103#discussion_r1957208019 ## arrow-data/src/data.rs: ## @@ -1929,7 +1929,7 @@ impl ArrayDataBuilder { /// Creates an array data, without any validation /// -/// Note: This is shor

Re: [PR] Minor: Add doctest to ArrayDataBuilder::build_unchecked [arrow-rs]

2025-02-15 Thread via GitHub
gstvg commented on PR #7139: URL: https://github.com/apache/arrow-rs/pull/7139#issuecomment-2661144091 Render as: ![image](https://github.com/user-attachments/assets/41bdc769-d09d-41f4-ae2d-fa36505fd3f6) -- This is an automated message from the Apache Git Service. To respond to

[PR] Minor: Add doctest to ArrayDataBuilder::build_unchecked [arrow-rs]

2025-02-15 Thread via GitHub
gstvg opened a new pull request, #7139: URL: https://github.com/apache/arrow-rs/pull/7139 # Which issue does this PR close? Follow on to #7103 # Rationale for this change As suggested by @Jefffrey in https://github.com/apache/arrow-rs/pull/7103#discussion_r1948665705,

[PR] feat(parquet/cmd/parquet_reader): Add command to dump the column and offset indices [arrow-go]

2025-02-15 Thread via GitHub
zeroshade opened a new pull request, #281: URL: https://github.com/apache/arrow-go/pull/281 ### Rationale for this change Makes it easier to visualize the Column and Offset indices that may exist in a parquet file. ### What changes are included in this PR? A new command `column-

[PR] feat(internal/encoding): add Discard method to decoders [arrow-go]

2025-02-15 Thread via GitHub
zeroshade opened a new pull request, #280: URL: https://github.com/apache/arrow-go/pull/280 ### Rationale for this change Building towards proper support for Skipping rows to address #278 we need to be able to efficiently discard values from decoders rather than actively having to alloca

Re: [PR] ffi_stream.rs: Align buffers when importing arrays [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv closed pull request #7138: ffi_stream.rs: Align buffers when importing arrays URL: https://github.com/apache/arrow-rs/pull/7138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] ffi_stream.rs: Align buffers when importing arrays [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv opened a new pull request, #7138: URL: https://github.com/apache/arrow-rs/pull/7138 Cherry picked upstream PR: https://github.com/apache/arrow-rs/pull/7137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
tustvold commented on PR #7137: URL: https://github.com/apache/arrow-rs/pull/7137#issuecomment-2661108200 > Note that arrow-rs is effectively asking other Arrow implementations to provide 16-byte aligned buffers for some types Most arrow implementations actually provide 64 byte alignm

Re: [PR] Parquet Modular decryption support [arrow-rs]

2025-02-15 Thread via GitHub
etseidl commented on code in PR #6637: URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1956641647 ## parquet/src/file/metadata/reader.rs: ## @@ -68,6 +76,28 @@ pub struct ParquetMetaDataReader { // Size of the serialized thrift metadata plus the 8 byte footer.

Re: [PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv commented on PR #7137: URL: https://github.com/apache/arrow-rs/pull/7137#issuecomment-2661058317 > I personally think the former is better as it drives the ecosystem forwards, but appreciate some people are more in the camp of "I just want it to work". Note that `arrow-rs`

Re: [I] rust: ADBC driver crashes when consuming Arrow batches without properly aligned buffers [arrow-adbc]

2025-02-15 Thread via GitHub
felipecrv commented on issue #2526: URL: https://github.com/apache/arrow-adbc/issues/2526#issuecomment-2661051639 > It would be nice to know which data type Rust is complaining about (are there any data types that require an alignment >8 bytes anywhere in the spec?) The integers comin

Re: [PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
tustvold commented on PR #7137: URL: https://github.com/apache/arrow-rs/pull/7137#issuecomment-2661050645 I think it boils down to a subjective judgement over which of the following is better. * arrow-adbc produces unaligned buffers * error reported consuming data * bug filed on

Re: [PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv commented on PR #7137: URL: https://github.com/apache/arrow-rs/pull/7137#issuecomment-2661046691 > I wonder if we could make this behaviour opt-in I considered that, but couldn't think of any scenario where a Rust program importing data from another system would not want to

Re: [I] Memory-Access Methods in sun.misc.Unsafe are deprecated for removal [arrow-java]

2025-02-15 Thread via GitHub
wendigo commented on issue #511: URL: https://github.com/apache/arrow-java/issues/511#issuecomment-2661039698 @jbonofre we (Trino project) can help test it out since we are now on JDK 23 and moving soon to 24 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [I] Array data imported through the FFI might contain unaligned buffers [arrow-rs]

2025-02-15 Thread via GitHub
tustvold commented on issue #7136: URL: https://github.com/apache/arrow-rs/issues/7136#issuecomment-2661034495 Changing this to an enhancement, as the current behaviour is intentional, even if it could be improved (e.g. returning an error instead of panicking). It would be a bug if buffer m

Re: [I] rust: ADBC driver crashes when consuming Arrow batches without properly aligned buffers [arrow-adbc]

2025-02-15 Thread via GitHub
tustvold commented on issue #2526: URL: https://github.com/apache/arrow-adbc/issues/2526#issuecomment-2661032826 FWIW I wonder if this is the same issue as https://github.com/apache/arrow/issues/32276, I wonder if snowflake is using flight under the hood. The C Data interface has the

Re: [PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
tustvold commented on PR #7137: URL: https://github.com/apache/arrow-rs/pull/7137#issuecomment-2661030064 I wonder if we could make this behaviour opt-in, whilst I accept systems may produce unaligned data, and people may want to accommodate this (although historically the consensus has bee

Re: [PR] feat: add ListView equal [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv commented on code in PR #6969: URL: https://github.com/apache/arrow-rs/pull/6969#discussion_r1957164663 ## arrow-data/src/equal/list_view.rs: ## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[PR] Align buffers of array data imported through the FFI if they aren't aligned [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv opened a new pull request, #7137: URL: https://github.com/apache/arrow-rs/pull/7137 Closes #7136. This will also fix this issue in `arrow-adbc` once the `arrow-array` crate version is bumped. -- This is an automated message from the Apache Git Service. To respond to the m

[I] Array data imported through the FFI might contain unaligned buffers [arrow-rs]

2025-02-15 Thread via GitHub
felipecrv opened a new issue, #7136: URL: https://github.com/apache/arrow-rs/issues/7136 **Describe the bug** I described the issue in detail on the `arrow-adbc` bug tracker: https://github.com/apache/arrow-adbc/issues/2526 **To Reproduce** Executing a query throug

Re: [I] rust: ADBC driver crashes when consuming Arrow batches without properly aligned buffers [arrow-adbc]

2025-02-15 Thread via GitHub
paleolimbot commented on issue #2526: URL: https://github.com/apache/arrow-adbc/issues/2526#issuecomment-2660990954 It would be nice to know which data type Rust is complaining about (are there any data types that require an alignment >8 bytes anywhere in the spec?) -- This is an automate

Re: [PR] GH-18036: [Packaging] Build Python wheel for musllinux [arrow]

2025-02-15 Thread via GitHub
nveloso commented on PR #45470: URL: https://github.com/apache/arrow/pull/45470#issuecomment-2660981238 > > I'm not able to run `python-wheel-musllinux-test-unittests` because there are 2 tests failing and I don't think they are related with my changes. Can you please confirm? The failing t

Re: [PR] feat(csharp/src/Drivers/BigQuery): add support for net472 [arrow-adbc]

2025-02-15 Thread via GitHub
CurtHagenlocher commented on PR #2527: URL: https://github.com/apache/arrow-adbc/pull/2527#issuecomment-2660978594 This is interesting because the core Arrow assembly targets netstandard2.0 and not net472 and I guess that one doesn't cause a problem in this scenario? Let's be consiste

Re: [PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
github-actions[bot] commented on PR #45542: URL: https://github.com/apache/arrow/pull/45542#issuecomment-2660925742 Revision: 439c66d5784eed8cdd4549b6524ff069e924967c Submitted crossbow builds: [ursacomputing/crossbow @ actions-77659648ea](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
hiroyuki-sato commented on PR #45542: URL: https://github.com/apache/arrow/pull/45542#issuecomment-2660925113 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
hiroyuki-sato opened a new pull request, #45542: URL: https://github.com/apache/arrow/pull/45542 ### Rationale for this change [union c_type]https://arrow.apache.org/docs/cpp/api/datatype.html#_CPPv4N5arrow14BinaryViewType6c_typeE in the BinaryViewType class describes data layout usi

Re: [PR] GH-45541: WIP [Doc][C++] Render ASCII art as is [arrow]

2025-02-15 Thread via GitHub
github-actions[bot] commented on PR #45542: URL: https://github.com/apache/arrow/pull/45542#issuecomment-2660924774 :warning: GitHub issue #45541 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] [Java] Avro write support - will you accept a patch? [arrow-java]

2025-02-15 Thread via GitHub
martin-traverse commented on issue #615: URL: https://github.com/apache/arrow-java/issues/615#issuecomment-2660896546 Yes that is exactly how it is ;-) I've made a start so there should be a draft PR for review in the next few days. I think there might be some interesting questions a

Re: [PR] arrow-ord: add support for partitioning nested types [arrow-rs]

2025-02-15 Thread via GitHub
alamb commented on code in PR #7131: URL: https://github.com/apache/arrow-rs/pull/7131#discussion_r1957085257 ## arrow-ord/src/partition.rs: ## @@ -156,7 +157,14 @@ fn find_boundaries(v: &dyn Array) -> Result { let slice_len = v.len() - 1; let v1 = v.slice(0, slice_len

Re: [PR] Update prost-build requirement from =0.13.4 to =0.13.5 [arrow-rs]

2025-02-15 Thread via GitHub
alamb merged PR #7127: URL: https://github.com/apache/arrow-rs/pull/7127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache