[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-27 Thread GitBox
BryanCutler commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-634963132 merged to master, thanks @liyafan82 ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-22 Thread GitBox
BryanCutler commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-632887913 Thanks @liyafan82 , looks like they didn't pass on this first try. Any idea what was causing the error: ``` Error accessing files Current token (VALUE_STRING) not

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-18 Thread GitBox
BryanCutler commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-630444330 The `generate_primitive_large_offsets_case` looks like it is just testing 'largebinary', 'largeutf8'. Are large lists somehow part of that? ```python def

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-15 Thread GitBox
BryanCutler commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-629419409 I think you should be removing the skip Java here