[GitHub] [arrow] Dandandan commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-12 Thread GitBox
Dandandan commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817946446 > > At least would be best to remove support for sum, as we don't have an absolute zero for timestamps. For average, I think it may make some more sense, but I think the use

[GitHub] [arrow] Dandandan commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-11 Thread GitBox
Dandandan commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817317167 > > What are the exact use cases for summing timestamps? When does it make sense? > > @Dandandan that is an excellent question. I will freely admit I was just heads down

[GitHub] [arrow] Dandandan commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-10 Thread GitBox
Dandandan commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817118938 Hey @alamb this is looking good. I'm wondering whether we should support sum/avg for timestamp? -- This is an automated message from the Apache Git Service. To respond to