[GitHub] [arrow] Kopilov commented on pull request #8605: ARROW-10508 [Java] Allow FixedSizeListVector to have empty children

2020-11-15 Thread GitBox
Kopilov commented on pull request #8605: URL: https://github.com/apache/arrow/pull/8605#issuecomment-727626118 @liyafan82 seems working correctly in all cases if we add `writer.startList` and `writer.endList` together with `vector.setNull`. I have refactored `writeListVector` function

[GitHub] [arrow] Kopilov commented on pull request #8605: ARROW-10508 [Java] Allow FixedSizeListVector to have empty children

2020-11-12 Thread GitBox
Kopilov commented on pull request #8605: URL: https://github.com/apache/arrow/pull/8605#issuecomment-726169585 @liyafan82 good idea, added test case to PR. Also tested together with C++ in my demo project: