[GitHub] [arrow] alamb commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-12 Thread GitBox
alamb commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817979546 I have removed `SUM` from this PR and will figure out what IOx is doing that seems to require sum and doesn't make sense. Thanks @Dandandan -- This is an automated message from

[GitHub] [arrow] alamb commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-12 Thread GitBox
alamb commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817915042 > At least would be best to remove support for sum, as we don't have an absolute zero for timestamps. For average, I think it may make some more sense, but I think the use case

[GitHub] [arrow] alamb commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-12 Thread GitBox
alamb commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817874943 > At least would be best to remove support for sum, as we don't have an absolute zero for timestamps. For average, I think it may make some more sense, but I think the use case

[GitHub] [arrow] alamb commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-11 Thread GitBox
alamb commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817279890 > What are the exact use cases for summing timestamps? When does it make sense? @Dandandan that is an excellent question. I will freely admit I was just heads down trying

[GitHub] [arrow] alamb commented on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

2021-04-10 Thread GitBox
alamb commented on pull request #9970: URL: https://github.com/apache/arrow/pull/9970#issuecomment-817113666 FYI @Dandandan / @returnString -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the