[GitHub] [arrow] andygrove commented on pull request #8034: ARROW-9464: [Rust] [DataFusion] Physical plan optimization rule to insert MergeExec when needed

2020-08-24 Thread GitBox
andygrove commented on pull request #8034: URL: https://github.com/apache/arrow/pull/8034#issuecomment-679426900 Thanks for the reviews @alamb and @jorgecarleitao .. I have implemented the suggested and also improved the error handling so we return `Err` results rather than panic if the

[GitHub] [arrow] andygrove commented on pull request #8034: ARROW-9464: [Rust] [DataFusion] Physical plan optimization rule to insert MergeExec when needed

2020-08-23 Thread GitBox
andygrove commented on pull request #8034: URL: https://github.com/apache/arrow/pull/8034#issuecomment-678809178 > It looks fantastic! Super excited to see this! > > Gave it a quick look, and my understanding so far: > > * Physical nodes have requirements

[GitHub] [arrow] andygrove commented on pull request #8034: ARROW-9464: [Rust] [DataFusion] Physical plan optimization rule to insert MergeExec when needed

2020-08-23 Thread GitBox
andygrove commented on pull request #8034: URL: https://github.com/apache/arrow/pull/8034#issuecomment-678805566 @alamb @jorgecarleitao I'm pretty excited about this PR. This is a good example of how we can write optimizer rules against a trait-based plan.